DaniWeb Forum Index > Software Development > C++

C++ RSS

Does this programme have any memory Leaks?

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Aug 2009

Posts: 7

Reputation: invisi is an unknown quantity at this point

Solved Threads: 0

invisi

Offline

Newbie Poster

Does this programme have any memory Leaks?

Sep 1st, 2009

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <cstdlib>
#include <ctime>
#include <string>
 
using namespace std;
 
void RandomArrayFill(int* array, int size)
{
	//int* array = new int[size];
 
	cout << "Creating and filling the array with integers..." << endl;
	for(int i = 0; i< size; ++i)
	{
		array[i] = rand() % 101;
	}
 
 
	cout << "Array = {";
 
	for(int i = 0; i < size; ++i)
	{
		cout << array[i] << " ";  
	}
	cout << "}" << endl;
 
 
}
 
int main()
{
 
	srand((unsigned)time(0));
 
	int size;
	cout << "Enter Size: ";
	cin >> size;
	int* newArray = new int[size];
	RandomArrayFill(newArray, size);
 
	delete[] newArray;
	newArray = 0;
}
#include <iostream>
#include <cstdlib>
#include <ctime>
#include <string>

using namespace std;

void RandomArrayFill(int* array, int size)
{
	//int* array = new int[size];
	
	cout << "Creating and filling the array with integers..." << endl;
	for(int i = 0; i< size; ++i)
	{
		array[i] = rand() % 101;
	}
	
	
	cout << "Array = {";

	for(int i = 0; i < size; ++i)
	{
		cout << array[i] << " ";  
	}
	cout << "}" << endl;
	
	
}

int main()
{

	srand((unsigned)time(0));
	
	int size;
	cout << "Enter Size: ";
	cin >> size;
	int* newArray = new int[size];
	RandomArrayFill(newArray, size);

	delete[] newArray;
	newArray = 0;
}

•

Join Date: Aug 2009

Posts: 7

Reputation: invisi is an unknown quantity at this point

Solved Threads: 0

invisi

Offline

Newbie Poster

Re: Does this programme have any memory Leaks?

Sep 1st, 2009

This is the same programme but done using a vector. Alsthough it works it still comes up with this warning twice:

Warning 1 warning C4018: '<' : signed/unsigned mismatch Line 15

Why is that anyone know?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <cstdlib>
#include <ctime>
#include <vector>
#include <string>
#include <cmath>
 
using namespace std;
 
 
void RandomArrayFill(std::vector<int>& vec)
{
 
	cout << "Creating and filling the array with integers..." << endl;
	for(int i = 0; i< vec.size(); ++i)
	{
		vec[i] = rand() % 101;
	}
 
 
	cout << "Array = {";
 
	for(int i = 0; i < vec.size(); ++i)
	{
		cout << vec[i] << " ";  
	}
	cout << "}" << endl;	
}
 
 
int main()
{
 
	srand((unsigned)time(0));
 
	int size = 0;
 
	vector<int> intVector;
 
	cout << "New Size: " ;
	cin >> size;
 
	intVector.resize(size);
 
	RandomArrayFill(intVector);
 
	cout << endl;
}
#include <iostream>
#include <cstdlib>
#include <ctime>
#include <vector>
#include <string>
#include <cmath>

using namespace std;


void RandomArrayFill(std::vector<int>& vec)
{

	cout << "Creating and filling the array with integers..." << endl;
	for(int i = 0; i< vec.size(); ++i)
	{
		vec[i] = rand() % 101;
	}
	
	
	cout << "Array = {";

	for(int i = 0; i < vec.size(); ++i)
	{
		cout << vec[i] << " ";  
	}
	cout << "}" << endl;	
}


int main()
{
	
	srand((unsigned)time(0));

	int size = 0;

	vector<int> intVector;
	
	cout << "New Size: " ;
	cin >> size;
	
	intVector.resize(size);
	
	RandomArrayFill(intVector);

	cout << endl;
}

•

Join Date: May 2009

Posts: 21

Reputation: Topi Ojala is an unknown quantity at this point

Solved Threads: 5

Topi Ojala Topi Ojala is offline

Offline

Newbie Poster

Re: Does this programme have any memory Leaks?

Sep 1st, 2009

vector sizes are always in unsigned integers, so change the for-iterator i into an unsigned int.

•

Join Date: Apr 2009

Posts: 219

Reputation: NathanOliver is an unknown quantity at this point

Solved Threads: 37

NathanOliver NathanOliver is offline

Offline

Posting Whiz in Training

Re: Does this programme have any memory Leaks?

Sep 1st, 2009

also in the first program there is no memory leak.

if you write using namespace std; you do not need to write std::something in your program.
If your thread is solved please mark it as solved

•

Join Date: Jun 2008

Posts: 147

Reputation: GDICommander is an unknown quantity at this point

Solved Threads: 19

GDICommander GDICommander is offline

Offline

Junior Poster

Re: Does this programme have any memory Leaks?

Sep 1st, 2009

If you are using UNIX, you can use valgrind to check for memory leaks. You need to add --tool=memcheck on the command line to check for leaks.

•

Join Date: Dec 2008

Posts: 1,142

Reputation: firstPerson is just really nice

Solved Threads: 144

firstPerson firstPerson is offline

Offline

Veteran Poster

Re: Does this programme have any memory Leaks?

Sep 2nd, 2009

•

Originally Posted by NathanOliver

also in the first program there is no memory leak.

Are you sure. His program is tricky in a sense that there is a memory
leak. His function is definitely not doing what he thinks its doing.

One way to tell if you have memory leak is to see if every new
is matched with delete. In your function, you allocate new memory for the array
that is passed, which already has been allocated memory. So when
inside the function, the arrays thats passed is located in whatever
memory address that was reserved inside the function. When he
exits out that functions, that memory is no longer in play. Inside
main he has already the array pointing at a specific address.

So the memory inside the function has a leak. Also you use
2 instances of new but only 1 delete. Does that give you a hint?

Last edited by firstPerson; Sep 2nd, 2009 at 2:53 am.

Help with Code Tags

(Toggle Plain Text)

I give up! 
1) What word becomes shorter if you add a letter to it? [ Solved by : niek_e ]
2) What does this sequence  equal to :  (.5u - .5a)(.5u-.5b)(.5u-.5c) ...
3) What is the 123456789 prime numer?

•

Join Date: Jun 2009

Posts: 681

Reputation: Tom Gunn has much to be proud of

Solved Threads: 132

Tom Gunn

Offline

Practically a Master Poster

Re: Does this programme have any memory Leaks?

Sep 2nd, 2009

•

vector sizes are always in unsigned integers, so change the for-iterator i into an unsigned int.

The type might not be unsigned int . It is safer to use the actual type that is typedef'd in the vector class:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void RandomArrayFill(vector<int>& vec)
{
    cout << "Creating and filling the array with integers..." << endl;
 
    for (vector<int>::size_type i = 0; i < vec.size(); ++i)
    {
        vec[i] = rand() % 101;
    }
 
    cout << "Array = {";
 
    for (vector<int>::size_type i = 0; i < vec.size(); ++i)
    {
        cout << vec[i] << " ";  
    }
 
    cout << "}" << endl;	
}
void RandomArrayFill(vector<int>& vec)
{
    cout << "Creating and filling the array with integers..." << endl;

    for (vector<int>::size_type i = 0; i < vec.size(); ++i)
    {
        vec[i] = rand() % 101;
    }

    cout << "Array = {";

    for (vector<int>::size_type i = 0; i < vec.size(); ++i)
    {
        cout << vec[i] << " ";  
    }

    cout << "}" << endl;	
}

•

•

•

•

•

also in the first program there is no memory leak.

Are you sure.

I am. The allocation in the function is commented and will not run. If you uncomment it, there will be a compiler error because array is redefined.

-Tommy (For Great Justice!) Gunn

•

Join Date: Oct 2007

Posts: 792

Reputation: siddhant3s has much to be proud of

Solved Threads: 135

siddhant3s siddhant3s is offline

Offline

Master Poster

Re: Does this programme have any memory Leaks?

Sep 2nd, 2009

>In your function, you allocate new memory for the array
>that is passed, which already has been allocated memory.

I suppose he has commented that line.
Hence technically, there are no memory leaks in the first program.

OP>Why is that anyone know?
That is because the .size() member function of the std::vector returns a size_t and not a int. size_t is usually a unsigned int defined by your implementation. Hence it is actually safe to do for(size_t i = 0; i< vec.size(); ++i)

By the way, in your second program, rather than first creating a vector and then resizing, it would have been better if you could have constructed a vector of the given size before hand.
Anyways, it wont matter here for the problem in hand.

Edit: I replied a bit slow.

Last edited by siddhant3s; Sep 2nd, 2009 at 10:42 am.

Siddhant Sanyam
(Not posting much)
Migrate to Standard C++ :When to tell your C++ Code is Non-Standard.
Please Read before posting: How To Ask Questions The Smart Way

•

Join Date: Dec 2008

Posts: 1,142

Reputation: firstPerson is just really nice

Solved Threads: 144

firstPerson firstPerson is offline

Offline

Veteran Poster

Re: Does this programme have any memory Leaks?

Sep 2nd, 2009

•

Originally Posted by siddhant3s

>In your function, you allocate new memory for the array
>that is passed, which already has been allocated memory.

I suppose he has commented that line.
Hence technically, there are no memory leaks in the first program.

I guess it was late. Didn't see the backlashes.

Help with Code Tags

(Toggle Plain Text)

I give up! 
1) What word becomes shorter if you add a letter to it? [ Solved by : niek_e ]
2) What does this sequence  equal to :  (.5u - .5a)(.5u-.5b)(.5u-.5c) ...
3) What is the 123456789 prime numer?

•

Join Date: Aug 2009

Posts: 7

Reputation: invisi is an unknown quantity at this point

Solved Threads: 0

invisi

Offline

Newbie Poster

Re: Does this programme have any memory Leaks?

#10

Sep 2nd, 2009

•

Originally Posted by firstPerson

Are you sure. His program is tricky in a sense that there is a memory
leak. His function is definitely not doing what he thinks its doing.

One way to tell if you have memory leak is to see if every new
is matched with delete. In your function, you allocate new memory for the array
that is passed, which already has been allocated memory. So when
inside the function, the arrays thats passed is located in whatever
memory address that was reserved inside the function. When he
exits out that functions, that memory is no longer in play. Inside
main he has already the array pointing at a specific address.

So the memory inside the function has a leak. Also you use
2 instances of new but only 1 delete. Does that give you a hint?

Actually the second instance of new in the function is a comment.

Anyway for those you said I didn't have any memory leaks, thanks thats what I though, just wanted to make sure