DaniWeb Forum Index > Software Development > C++

C++ RSS

what is the error

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2005

Posts: 129

Reputation: some one is an unknown quantity at this point

Solved Threads: 0

some one

Offline

Junior Poster

what is the error

Apr 8th, 2005

please where is the error in this code doesn't run

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include<iostream>
#include<cstdlib>
using namespace std;
int main()
{
  int ages[1000];
  int size=1000;
  int i,a,b;
  for( i=0;i<size;i++)
  {
    ages[i]=rand();
    for( a=1;a<size;a++)
    {
      for( b=size-1;b>=a;b--)
      {
        if(ages[b-1]<ages[b])
        {
          i=ages[b-1];
          ages[b-1]=ages[i];
          ages[b]=i;
        }
      }
    }
  }
  cout<<ages[i];
 
  return 0;
}
#include<iostream>
#include<cstdlib>
using namespace std;
int main()
{
  int ages[1000];
  int size=1000;
  int i,a,b;
  for( i=0;i<size;i++)
  {
    ages[i]=rand();
    for( a=1;a<size;a++)
    {
      for( b=size-1;b>=a;b--)
      {
        if(ages[b-1]<ages[b])
        {
          i=ages[b-1];
          ages[b-1]=ages[i];
          ages[b]=i;
        }
      }
    }
  }
  cout<<ages[i];

  return 0;
}

Code indented and tags added. -Narue

•

Join Date: Sep 2004

Posts: 7,596

Reputation: Narue has a reputation beyond repute

Solved Threads: 712

Narue

Offline

Code Goddess

Re: what is the error

Apr 8th, 2005

>ages[b-1]=ages[i];
That's your error. i isn't an index, it's a content value, and the value could very well exceed 999, which is the largest possible index for ages. Change that line to:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
ages[b-1]=ages[b];
ages[b-1]=ages[b];

You probably also want to restructure your code so that it has specific sections for initializing the array, sorting the array, and printing the sorted array:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include<iostream>
#include<cstdlib>
using namespace std;
int main()
{
  int ages[1000];
  int size=1000;
  int i,a,b;
  for(i=0;i<size;i++)
  {
    ages[i]=rand();
  }
  for( a=1;a<size;a++)
  {
    for( b=size-1;b>=a;b--)
    {
      if(ages[b-1]<ages[b])
      {
        i=ages[b-1];
        ages[b-1]=ages[b];
        ages[b]=i;
      }
    }
  }
  for( i=0;i<size;i++)
  {
    cout<<ages[i]<<' ';
  }
 
  return 0;
}
#include<iostream>
#include<cstdlib>
using namespace std;
int main()
{
  int ages[1000];
  int size=1000;
  int i,a,b;
  for(i=0;i<size;i++)
  {
    ages[i]=rand();
  }
  for( a=1;a<size;a++)
  {
    for( b=size-1;b>=a;b--)
    {
      if(ages[b-1]<ages[b])
      {
        i=ages[b-1];
        ages[b-1]=ages[b];
        ages[b]=i;
      }
    }
  }
  for( i=0;i<size;i++)
  {
    cout<<ages[i]<<' ';
  }

  return 0;
}

I'm also not sure if you really wanted this functionality or not, but as it is the sort is descending, not ascending, which is the most common preference.