Pascal and Delphi

Pascal and Delphi RSS

How to spead a loop?

Please support our Pascal and Delphi advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Sep 2009

Posts: 8

Reputation: marygreen is an unknown quantity at this point

Solved Threads: 0

marygreen

Offline

Newbie Poster

How to spead a loop?

-1

Sep 17th, 2009

Hello to guys/girls on the forum. Question I have is following. How to speed this loop?

 Help with Code Tags 
 Pascal and Delphi Syntax (Toggle Plain Text) 
begin
var
i:integer;
begin
for i:=1 to 9999999 do
begin
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
Application.ProcessMessages;
if GetKeyState(VK_Escape) AND 128 = 128 then break;
end;
end;
begin
var
i:integer;
begin
for i:=1 to 9999999 do
begin
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
//do something
Memo1.Lines.Add ((floattostr(a1.value))+' + '+(floattostr(a2.value))+' + '+(floattostr(a3.value));
Application.ProcessMessages;
if GetKeyState(VK_Escape) AND 128 = 128 then break;
end;
end;

The loop is very slow. To generate 2,000,000 lines it needs 2:45 hours. As it continues, it gets slower and slower still.

Any help to this problem of mine is greatly appreciated.

Regards,
marygreen

•

Join Date: Jul 2006

Posts: 858

Reputation: pritaeas will become famous soon enough

Solved Threads: 140

pritaeas

Offline

Practically a Posting Shark

Re: How to spead a loop?

Sep 17th, 2009

Is it required to see those lines as they are generated. If you could send them to a file, you can speed it up. The memo is really awful for this amount of data.

Also, the processmessages slows things down. You could call it every 100 loops instead for example.

In the Lines.Add you use floattostr three times. Have a look at the Format() function.

"If it is NOT source, it is NOT software."
-- NASA

•

Join Date: Sep 2009

Posts: 8

Reputation: marygreen is an unknown quantity at this point

Solved Threads: 0

marygreen

Offline

Newbie Poster

Re: How to spead a loop?

Sep 17th, 2009

Pitaeas,
Thank you for answering. Indeed, I tried to send lines to a file with this:

 Help with Code Tags 
 Pascal and Delphi Syntax (Toggle Plain Text) 
var
keep : textfile;
text   : string;
begin
AssignFile(keep, 'c:\lines.txt');
ReWrite(keep);
WriteLn(keep,(floattostr(avf1.value)),' + ',(floattostr(avf2.value), '+', (floattostr(avf2.value) ));
CloseFile(keep);
end;
var
keep : textfile;
text   : string;
begin
AssignFile(keep, 'c:\lines.txt');
ReWrite(keep);
WriteLn(keep,(floattostr(avf1.value)),' + ',(floattostr(avf2.value), '+', (floattostr(avf2.value) ));
CloseFile(keep);
end;

But the loop is even slower than with memo option.

Format function is new for me, I’ll look into it.

•

Join Date: Feb 2009

Posts: 455

Reputation: FlamingClaw will become famous soon enough

Solved Threads: 109

FlamingClaw FlamingClaw is offline

Offline

Posting Pro in Training

Re: How to spead a loop?

Sep 19th, 2009

"The loop is very slow. To generate 2,000,000 lines it needs 2:45 hours. As it continues, it gets slower and slower still."

I wrote a same program like yours.....
what if you leave out floattostr function from the loop?
button1 coded:

 Help with Code Tags 
 delphi Syntax (Toggle Plain Text) 
procedure TForm1.Button1Click(Sender: TObject);
 
var i:integer;
    s:string;
 
begin
  s:=floattostr(3.14);
  for i:=1 to 2000000 do
  begin
    memo1.Lines.add(s);
  end;
end;
procedure TForm1.Button1Click(Sender: TObject);

var i:integer;
    s:string;

begin
  s:=floattostr(3.14);
  for i:=1 to 2000000 do
  begin
    memo1.Lines.add(s);
  end;
end;

it takes 8 minute to me to accomplish...my processor is clear pentium 3000 mhz

Be a good part of the community.Don't be ungrateful.
If you ask something on the forum and you got the right answer then mark as solved!
If my opinion helped to you a lot then sometimes give reputation point to me.
I'm just a pascal programmer from Hungary.
Farewell...

•

Join Date: Sep 2009

Posts: 8

Reputation: marygreen is an unknown quantity at this point

Solved Threads: 0

marygreen

Offline

Newbie Poster

Re: How to spead a loop?

Sep 19th, 2009

FlamingClaw,

wow, that's one clean and elegant piece of code. Thanks.

•

Join Date: Sep 2009

Posts: 1

Reputation: jng is an unknown quantity at this point

Solved Threads: 0

jng

Offline

Newbie Poster

Re: How to spead a loop?

Sep 23rd, 2009

Most likely the delays deal with the memo box. Each time you add lines the list gets longer. Check the limits in you memo component and perhaps overwrite the handling of the memo field to change the update/display process.

Also, if the float conversions can be done beforehand (in the "do something else") you might increase the speed.

JNG