DaniWeb Forum Index > Software Development > C++

Help with String Class

•

Join Date: Sep 2009

Posts: 15

Reputation: Wolf CCMLG is an unknown quantity at this point

Solved Threads: 0

Wolf CCMLG Wolf CCMLG is offline

Offline

Newbie Poster

Help with String Class

Oct 4th, 2009

Can someone help me please, I am getting this error:

stringdefinition.cpp(7) : error C2448: 'stringClass::wordCount' : function-style initializer appears to be a function definition

When trying to compile this code:

StringHeader.h

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef H_StringHeader
#define H_StringHeader
#include <iostream>
#include <string>
#include <cstring>
#include <algorithm>
using namespace std;
 
const int strLength = 51;
char strArray[strLength];
int charAmount;
string line;
int total;
 
class stringClass
{
public:
int wordCount(string);
};
#endif
#ifndef H_StringHeader
#define H_StringHeader
#include <iostream>
#include <string>
#include <cstring>
#include <algorithm>
using namespace std;

const int strLength = 51;
char strArray[strLength];
int charAmount;
string line;
int total;

class stringClass
{
public:
int wordCount(string);
};
#endif

StringDefinitions.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "StringHeader.H"
 
int stringClass::wordCount(line)
{
	cout << "\nThe String you entered in is: " << strArray << endl;
	charAmount = strlen(strArray);
	cout << "\nThere are " << charAmount << " characters in your String" << endl;
	line = strArray;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
	(n+1) = total;
 
return total;
}
#include "StringHeader.H"

int stringClass::wordCount(line)
{
	cout << "\nThe String you entered in is: " << strArray << endl;
	charAmount = strlen(strArray);
	cout << "\nThere are " << charAmount << " characters in your String" << endl;
	line = strArray;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
	(n+1) = total;

return total;
}

RunStrings.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "StringHeader.H"
 
int main()
{
	stringClass Obj;
	cout << "Enter a String" << endl;
	cin.getline(strArray, strLength);
	line = strArray;
	Obj.wordCount(line);
 
	cin.ignore();
	return 0;
}
#include "StringHeader.H"

int main()
{
	stringClass Obj;
	cout << "Enter a String" << endl;
	cin.getline(strArray, strLength);
	line = strArray;
	Obj.wordCount(line);

	cin.ignore();
	return 0;
}

•

Join Date: Oct 2008

Posts: 3,955

Reputation: adatapost has a brilliant future

Solved Threads: 707

adatapost

Offline

Senior Poster

Re: Help with String Class

Oct 4th, 2009

Missing typename of argument in method definition,

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
 int stringClass::wordCount(string line){
   .....
  //(n+1) = total;   // <---------------Remove this
  ....
}
 int stringClass::wordCount(string line){
   .....
  //(n+1) = total;   // <---------------Remove this
  ....
}

•

Join Date: Sep 2009

Posts: 15

Reputation: Wolf CCMLG is an unknown quantity at this point

Solved Threads: 0

Wolf CCMLG Wolf CCMLG is offline

Offline

Newbie Poster

Re: Help with String Class

Oct 4th, 2009

I'm sorry, I still don't understand which part of the code is missing. It tells me line 7 in the compiler error, but line 7 only contains a {.

int stringClass::wordCount(line) <--- Is the error here?

StringDefinitions.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void stringClass::wordCount(line)
{
	cout << "\nThe String you entered in is: " << strArray << endl;
	charAmount = strlen(strArray);
	cout << "\nThere are " << charAmount << " characters in your String" << endl;
	line = strArray;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
}
void stringClass::wordCount(line)
{
	cout << "\nThe String you entered in is: " << strArray << endl;
	charAmount = strlen(strArray);
	cout << "\nThere are " << charAmount << " characters in your String" << endl;
	line = strArray;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
}

Last edited by Wolf CCMLG; Oct 4th, 2009 at 4:40 am.

•

Join Date: Oct 2008

Posts: 3,955

Reputation: adatapost has a brilliant future

Solved Threads: 707

adatapost

Offline

Senior Poster

Re: Help with String Class

Oct 4th, 2009

int stringClass::wordCount( string line)

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int stringClass::wordCount(string line){
 
  cout << "\nThe String you entered in is: " << strArray << endl;
  charAmount = strlen(strArray);
  cout << "\nThere are " << charAmount << " characters in your String" 
                  << endl;
  line = strArray;
  int n = count(line.begin(), line.end(), ' ');
  cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
 
 return n;
}
int stringClass::wordCount(string line){

  cout << "\nThe String you entered in is: " << strArray << endl;
  charAmount = strlen(strArray);
  cout << "\nThere are " << charAmount << " characters in your String" 
                  << endl;
  line = strArray;
  int n = count(line.begin(), line.end(), ' ');
  cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
 
 return n;
}

•

Join Date: Oct 2009

Posts: 8

Reputation: venkat arun has a little shameless behaviour in the past

Solved Threads: 0

venkat arun venkat arun is offline

Offline

Newbie Poster

Re: Help with String Class

Oct 4th, 2009

While defining a function there needs to be a type with the variable name. So you need to put it as string line instead of just line.

PS: are you trying to make a string class? If yes then some of the global variables should be inside the class, so that multiple objects can be handled effectively.

•

Join Date: Oct 2009

Posts: 8

Reputation: venkat arun has a little shameless behaviour in the past

Solved Threads: 0

venkat arun venkat arun is offline

Offline

Newbie Poster

Re: Help with String Class

Oct 4th, 2009

Sorry, I just read the second post of yours, it is giving an error there because sometimes compilers aren't able to pinpoint the exact spot of the error, so it is advisable to look at the surrounding code when a compiler gives an error.

Tip: I have noticed that some compilers give an unreasonably large no of errors, this is usually because of an unbalanced parentheses (unequal no. of closing and opening brackets). But of course it can be genuine also

•

Join Date: Sep 2009

Posts: 15

Reputation: Wolf CCMLG is an unknown quantity at this point

Solved Threads: 0

Wolf CCMLG Wolf CCMLG is offline

Offline

Newbie Poster

Re: Help with String Class

Oct 4th, 2009

Thanks for the help everyone, but I am getting a new error now. I tried to put more variables into the class. I left the char * array and const int out. The error is:
StringDefinition.obj : error LNK2005: "char * strArray" (?strArray@@3PADA) already defined in RunStrings.obj
It looks like I may be defining my char * array twice, but I don't know where I am doing this.

Here is my updated code:

StringHeader.H

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef H_StringHeader
#define H_StringHeader
#include <iostream>
#include <string>
#include <cstring>
#include <algorithm>
using namespace std;
 
const int strLength = 51;
char strArray[strLength];
class stringClass
{
public:
int charAmount;
int total;
int wordCount(string);
};
#endif
#ifndef H_StringHeader
#define H_StringHeader
#include <iostream>
#include <string>
#include <cstring>
#include <algorithm>
using namespace std;

const int strLength = 51;
char strArray[strLength];
class stringClass
{
public:
int charAmount;
int total;
int wordCount(string);
};
#endif

StringDefinitions.CPP

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "StringHeader.H"
 
int stringClass::wordCount(string line)
{
	cout<<"\nThe String you entered in is: "<<line<<endl;
	charAmount = strlen(strArray);
	cout<<"\nThere are "<<charAmount<<" characters in your String"<< endl;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
	return n;
}
#include "StringHeader.H"

int stringClass::wordCount(string line)
{
	cout<<"\nThe String you entered in is: "<<line<<endl;
	charAmount = strlen(strArray);
	cout<<"\nThere are "<<charAmount<<" characters in your String"<< endl;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
	return n;
}

RunStrings.CPP

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "StringHeader.H"
 
string line;
int main()
{
	stringClass Obj;
	cout << "Enter a String" << endl;
	cin.getline(strArray, strLength);
	line = strArray;
	Obj.wordCount(line);
 
	cin.ignore();
	return 0;
}
#include "StringHeader.H"

string line;
int main()
{
	stringClass Obj;
	cout << "Enter a String" << endl;
	cin.getline(strArray, strLength);
	line = strArray;
	Obj.wordCount(line);

	cin.ignore();
	return 0;
}

•

Join Date: Sep 2009

Posts: 15

Reputation: Wolf CCMLG is an unknown quantity at this point

Solved Threads: 0

Wolf CCMLG Wolf CCMLG is offline

Offline

Newbie Poster

Re: Help with String Class

Oct 4th, 2009

Should I not declare the char * array in the header file? I can't seem to find where I am defining it twice. Any help would be greatly appreciated.

•

Originally Posted by Wolf CCMLG

Thanks for the help everyone, but I am getting a new error now. I tried to put more variables into the class. I left the char * array and const int out. The error is:
StringDefinition.obj : error LNK2005: "char * strArray" (?strArray@@3PADA) already defined in RunStrings.obj
It looks like I may be defining my char * array twice, but I don't know where I am doing this.
Here is my updated code:

StringHeader.H
Help with Code Tags

C++ Syntax (Toggle Plain Text)
#ifndef H_StringHeader
#define H_StringHeader
#include <iostream>
#include <string>
#include <cstring>
#include <algorithm>
using namespace std;
 
const int strLength = 51;
char strArray[strLength];
class stringClass
{
public:
int charAmount;
int wordCount(string);
};
#endif
#ifndef H_StringHeader #define H_StringHeader #include <iostream> #include <string> #include <cstring> #include <algorithm> using namespace std; const int strLength = 51; char strArray[strLength]; class stringClass { public: int charAmount; int wordCount(string); }; #endif
StringDefinitions.CPP
Help with Code Tags

C++ Syntax (Toggle Plain Text)
#include "StringHeader.H"
 
int stringClass::wordCount(string line)
{
	cout<<"\nThe String you entered in is: "<<line<<endl;
	charAmount = strlen(strArray);
	cout<<"\nThere are "<<charAmount<<" characters in your String"<< endl;
	int n = count(line.begin(), line.end(), ' ');
	cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl;
	return n;
}
#include "StringHeader.H" int stringClass::wordCount(string line) { cout<<"\nThe String you entered in is: "<<line<<endl; charAmount = strlen(strArray); cout<<"\nThere are "<<charAmount<<" characters in your String"<< endl; int n = count(line.begin(), line.end(), ' '); cout<<"\nThere are "<< n + 1 <<" words in your String"<<endl; return n; }
RunStrings.CPP
Help with Code Tags

C++ Syntax (Toggle Plain Text)
#include "StringHeader.H"
 
string line;
int main()
{
	stringClass Obj;
	cout << "Enter a String" << endl;
	cin.getline(strArray, strLength);
	line = strArray;
	Obj.wordCount(line);
 
	cin.ignore();
	return 0;
}
#include "StringHeader.H" string line; int main() { stringClass Obj; cout << "Enter a String" << endl; cin.getline(strArray, strLength); line = strArray; Obj.wordCount(line); cin.ignore(); return 0; }