DaniWeb Forum Index > Software Development > C++

C++ RSS

Student needs help..please

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Student needs help..please

Oct 18th, 2009

I've written a C++ program that compiles successfully but is give me some logic error. It's giving me some negative numbers can someone please run the code and see what ive done wrong.

Built with Visual Studio 2008

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include"stdafx.h"
#include<string>
#include<iostream>
using namespace std;
 
class vowels
{
public:
       vowels();void getdata();void processdata();void display();string input;
private:
		int a;int e;int i; int o; int u; int y;
};
vowels::vowels ()
{
	int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input="";
}
void vowels::getdata()
{
	cout<<"Enter String of Characters->>";
	getline(cin,input);
}
void vowels::processdata()
{
if(input=="A" && input=="a")
{
a=a++;
}
else if(input=="E" && input=="e")
{
e=e++;
}
else if(input=="I" && input=="i")
{
i=i++;
}
else if(input=="O" && input=="o")
{
o=o++;
}
else if(input=="U" && input=="u")
{
u=u++;
}
}
void vowels::display()
{
printf("Vowels present in the typed string are:\n");
cout<<"A="<<a<<endl;
cout<<"E="<<e<<endl;
cout<<"I="<<i<<endl;
cout<<"O="<<o<<endl;
cout<<"U="<<u<<endl;
}
int main()
{
	vowels countvowels;
	countvowels.getdata();
	countvowels.processdata();
	countvowels.display();
system("pause");
}
#include"stdafx.h"
#include<string>
#include<iostream>
using namespace std;

class vowels
{
public:
       vowels();void getdata();void processdata();void display();string input;
private:
		int a;int e;int i; int o; int u; int y;
};
vowels::vowels ()
{
	int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input="";
}
void vowels::getdata()
{
	cout<<"Enter String of Characters->>";
	getline(cin,input);
}
void vowels::processdata()
{
if(input=="A" && input=="a")
{
a=a++;
}
else if(input=="E" && input=="e")
{
e=e++;
}
else if(input=="I" && input=="i")
{
i=i++;
}
else if(input=="O" && input=="o")
{
o=o++;
}
else if(input=="U" && input=="u")
{
u=u++;
}
}
void vowels::display()
{
printf("Vowels present in the typed string are:\n");
cout<<"A="<<a<<endl;
cout<<"E="<<e<<endl;
cout<<"I="<<i<<endl;
cout<<"O="<<o<<endl;
cout<<"U="<<u<<endl;
}
int main()
{
	vowels countvowels;
	countvowels.getdata();
	countvowels.processdata();
	countvowels.display();
system("pause");
}

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Oct 18th, 2009

And the code's purpose is to count number of vowels in a string. In this order:
A
E
I
O
U
with constructor with outside class function definition.

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Oct 18th, 2009

no help at all...but thanks anyway. Im gonna try somewhere else.

•

Join Date: Jan 2009

Posts: 476

Reputation: csurfer is just really nice

Solved Threads: 76

csurfer

Offline

Posting Pro in Training

Oct 18th, 2009

You need to pay more attention in your classes.Very silly mistakes.

1)

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
vowels::vowels ()
{
	int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input="";
}
vowels::vowels ()
{
	int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input="";
}

Class functions are used to manipulate the variables declared within the class.Here by declaring the variables again you are just removing the whole sense out of it.You just need to initialise the variables declared within the class.

2)

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
if(input=="A" && input=="a")
if(input=="A" && input=="a")

If input equals 'A' how in the world can it be equal to 'a' at the same time....??? And && requires both the condition to be true.What you really need here is the"||" "or" and not "&&" "and".

Last edited by csurfer; Oct 18th, 2009 at 2:30 pm.

I Surf in "C"....

•

Join Date: Sep 2004

Posts: 7,619

Reputation: Narue has a reputation beyond repute

Solved Threads: 713

Narue

Offline

Code Goddess

Oct 18th, 2009

>no help at all...but thanks anyway.
Your capacity for patience is staggering. I mean, you couldn't even wait a full hour when it's either SUNDAY, or the wee hours of Monday all over the world. Good luck passing your class, and succeeding at a programming career, because you'll clearly need it.

I'm here to prove you wrong.

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Oct 18th, 2009

•

Originally Posted by csurfer

You need to pay more attention in your classes.Very silly mistakes.

1)
Help with Code Tags

c++ Syntax (Toggle Plain Text)
vowels::vowels ()
{
	int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input="";
}
vowels::vowels () { int a=0; int e=0; int i=0; int o=0; int u=0; int y=0;input=""; }
Class functions are used to manipulate the variables declared within the class.Here by declaring the variables again you are just removing the whole sense out of it.You just need to initialise the variables declared within the class.

2)
Help with Code Tags

c++ Syntax (Toggle Plain Text)
if(input=="A" && input=="a")
if(input=="A" && input=="a")
If input equals 'A' how in the world can it be equal to 'a' at the same time....??? And && requires both the condition to be true.What you really need here is the"||" "or" and not "&&" "and".

Thanks for the help but im getting these answers below.
Click link for picture(i didnt see any[image] [/image])

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Oct 18th, 2009

•

Originally Posted by Narue

>no help at all...but thanks anyway.
Your capacity for patience is staggering. I mean, you couldn't even wait a full hour when it's either SUNDAY, or the wee hours of Monday all over the world. Good luck passing your class, and succeeding at a programming career, because you'll clearly need it.

Ive been reading alot of threads and im getting the impression that students asking for help and getting it is like a taboo. "NO homework allowed".... but now i see that there are people on this forum that will help and when i get the a better level in programming i will be willing to help.

•

Join Date: Jan 2009

Posts: 476

Reputation: csurfer is just really nice

Solved Threads: 76

csurfer

Offline

Posting Pro in Training

Oct 18th, 2009

•

Originally Posted by jamdownian

Ive been reading alot of threads and im getting the impression that students asking for help and getting it is like a taboo. "NO homework allowed".... but now i see that there are people on this forum that will help and when i get the a better level in programming i will be willing to help.

You have a very wrong impression about DANIWEB and the culture here... We don't say "No Home Work" we say "We wont help until you put in some effort",and even you would agree that we are not wrong.

We are here to learn and to help others learn. And none here are workless and come here for fun. Everyone is really busy but take some time out to help others who want to learn, so have a bit of patience.

And ya NARUE was the one who guided me when I was new and helped me a lot and DANIWEB is the reason for what I am.

I Surf in "C"....

•

Join Date: Oct 2009

Posts: 8

Reputation: jamdownian is an unknown quantity at this point

Solved Threads: 0

jamdownian jamdownian is offline

Offline

Newbie Poster

Oct 18th, 2009

•

Originally Posted by csurfer

You have a very wrong impression about DANIWEB and the culture here... We don't say "No Home Work" we say "We wont help until you put in some effort",and even you would agree that we are not wrong.

We are here to learn and to help others learn. And none here are workless and come here for fun. Everyone is really busy but take some time out to help others who want to learn, so have a bit of patience.

And ya NARUE was the one who guided me when I was new and helped me a lot and DANIWEB is the reason for what I am.

thanks for re-assuring that Dani is a ace site. But i hope im not too much of a bother. Did you see the pic...? Its giving negative numbers.

•

Join Date: Jan 2009

Posts: 476

Reputation: csurfer is just really nice

Solved Threads: 76

csurfer

Offline

Posting Pro in Training

#10

Oct 18th, 2009

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
if(input=="A" && input=="a")
//Same applies to all other vowel statements also
if(input=="A" && input=="a")
//Same applies to all other vowel statements also

Help with Code Tags

c++ Syntax (Toggle Plain Text)

a=a++;
//Same applies to all other vowel statements also

The two most foolish statements in your code are the ones shown above.

1) What you really want to do is to compare every character of string input with character 'A' and 'a' . But you are taking the whole "input" string and comparing it with string "a" and "A". That means you will never get anything more than 0.

2) This is a bit complicated concept called sequence points.In case you want to know you can read it.

Generally when we try to manipulate the same variable more than once within a sequence point the result is always compiler dependent.It can be anything.Moreover here a++ alone efficiently replace the whole statement (2).

I Surf in "C"....