DaniWeb Forum Index > Software Development > C

C program for arrays

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Aug 2005

Posts: 15,684

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1505

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

-7

#11

Oct 29th, 2009

line 12: its int main().

The rest is just too difficult to read because of terrible formatting. Don't be afraid to use some spaces to indent lines.

Last edited by Ancient Dragon; Oct 29th, 2009 at 8:52 pm.

I told Santa what I wanted for Christmas and he washed my mouth out with soap.

•

Join Date: Oct 2009

Posts: 65

Reputation: neithan is an unknown quantity at this point

Solved Threads: 2

neithan

Offline

Junior Poster in Training

#12

Oct 29th, 2009

•

Originally Posted by wangatang126

K here is what i've got. However the program immediatley termanates. Why? Also if you could take my program and edit it it would be heavily appreciated.

Your code looks kind of crazy. I don't understand any of this, why would you need 6 variables just to create a simple array with that serie? I don't get it.

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
 void displayArray(int nArray[])
{
int b;
printf("%d",nArray[b]);
}
 void displayArray(int nArray[])
{
int b;
printf("%d",nArray[b]);
}

Why would you want b for? And by the way it isn't initialized so you'll print random memory stuff there.

Anyways I strongly recommend you to throw all that code away, even if it's working, and write us a pseudocode of how you want your program to run, and we will work by there. If you don't know what pseudocode is try google it. Now is the best point to start for you in my opinion.
Seriously.

Last edited by neithan; Oct 29th, 2009 at 9:04 pm.

•

Join Date: Oct 2009

Posts: 23

Reputation: wangatang126 is an unknown quantity at this point

Solved Threads: 0

wangatang126 wangatang126 is offline

Offline

Newbie Poster

#13

Oct 29th, 2009

•

Originally Posted by neithan

Your code looks kind of crazy. I don't understand any of this, why would you need 6 variables just to create a simple array with that serie? I don't get it.
Help with Code Tags

C Syntax (Toggle Plain Text)
 void displayArray(int nArray[])
{
int b;
printf("%d",nArray[b]);
}
void displayArray(int nArray[]) { int b; printf("%d",nArray[b]); }
Why would you want b for? And by the way it isn't initialized so you'll print random memory stuff there.

Anyways I strongly recommend you to throw all that code away, even if it's working, and write us a pseudocode of how you want your program to run, and we will work by there. If you don't know what pseudocode is try google it. Now is the best point to start for you in my opinion.
Seriously.

HOw would you initialize b, since if you initialize it in the function then it will constantly keep b at the same number. However if i initialize it in the program it will still keep b at the same number.
here i indented the program. Here is it reposted

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# include "strlib.h"
# define maxElements 500
 void displayArray(int nArray[])
{
int b;
printf("%d",nArray[b]);
}
 
int main()
{
      int a,b,c,d,e,f,g;
      int nArray[b];
 
      printf("what is the max amount of 2's you want?");
      a=GetInteger();
      b=0;
      c=a;
      d=2;
      while(c!=0)
      {
      e=a;
      while(e!=0)
           {
      d=d*2;
      e=e-1;
            }
      if(e==0)
                 {
      d=1;
      a=a-1;
      nArray[b]=d;
      displayArray(nArray);
      b=b+1;
      c=c-1;
      break;
                 }
else  
      a=a-1;
      nArray[b]=d;
      displayArray(nArray);
      b=b+1;
      c=c-1;
      }
      getchar();
}
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# include "strlib.h"
# define maxElements 500
 void displayArray(int nArray[])
{
int b;
printf("%d",nArray[b]);
}

int main()
{
      int a,b,c,d,e,f,g;
      int nArray[b];
      
      printf("what is the max amount of 2's you want?");
      a=GetInteger();
      b=0;
      c=a;
      d=2;
      while(c!=0)
      {
      e=a;
      while(e!=0)
           {
      d=d*2;
      e=e-1;
            }
      if(e==0)
                 {
      d=1;
      a=a-1;
      nArray[b]=d;
      displayArray(nArray);
      b=b+1;
      c=c-1;
      break;
                 }
else  
      a=a-1;
      nArray[b]=d;
      displayArray(nArray);
      b=b+1;
      c=c-1;
      }
      getchar();
}

•

Join Date: Oct 2009

Posts: 23

Reputation: wangatang126 is an unknown quantity at this point

Solved Threads: 0

wangatang126 wangatang126 is offline

Offline

Newbie Poster

#14

Oct 29th, 2009

HOw come this always terminates? Plz help and write out the problem and post the code that fixes it.

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# define SIZE 500
void displayArray(int nArray[])
{
int f;
printf("%d        ",nArray[f]);
}
 
 
main()
{
      int a,b,c,d,e,f,g,h;
      int nArray[SIZE];
 
      printf("what is the max amount of 2's you want?");
      a=GetInteger();
      b=a;
      c=a;
      e=0;
      f=0;
      h=1;
      for(d=0;d<=c;d++)
      {
      if(e==0)
      {
      d=1;
      nArray[f]=d;
      displayArray(nArray);
      f=f+1;
      }
else
      g=f;
      while(g!=0)
      {
      h=2*h;
      g=g-1;
      }
      nArray[f]=d;
      displayArray(nArray);
      }
      getchar();
}
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# define SIZE 500
void displayArray(int nArray[])
{
int f;
printf("%d        ",nArray[f]);
}


main()
{
      int a,b,c,d,e,f,g,h;
      int nArray[SIZE];
      
      printf("what is the max amount of 2's you want?");
      a=GetInteger();
      b=a;
      c=a;
      e=0;
      f=0;
      h=1;
      for(d=0;d<=c;d++)
      {
      if(e==0)
      {
      d=1;
      nArray[f]=d;
      displayArray(nArray);
      f=f+1;
      }
else
      g=f;
      while(g!=0)
      {
      h=2*h;
      g=g-1;
      }
      nArray[f]=d;
      displayArray(nArray);
      }
      getchar();
}

•

Join Date: Oct 2009

Posts: 23

Reputation: wangatang126 is an unknown quantity at this point

Solved Threads: 0

wangatang126 wangatang126 is offline

Offline

Newbie Poster

#15

Oct 29th, 2009

alright i totally revamped it, but it still immidiatly terminates. Why. Help fix please

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# define SIZE 500
void displayArray(int nArray[])
{
int arraynum;
printf("%d        ",nArray[arraynum]);
}
 
 
main()
{     
      int amount,count,num1,num2,result,arraynum;
      int nArray[arraynum];
      amount=GetInteger();
      count=amount;
      num1=count;
      num2=num1;
      result=1;
      arraynum=0;
      while(num2!=0)
      {
      while(num1!=0)
      {
      result=result*2;
      num1=num1-1;
      }
      displayArray(nArray);
      arraynum=arraynum+1;
      num2=num2-1;
      }
      getchar();
}
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# define SIZE 500
void displayArray(int nArray[])
{
int arraynum;
printf("%d        ",nArray[arraynum]);
}


main()
{     
      int amount,count,num1,num2,result,arraynum;
      int nArray[arraynum];
      amount=GetInteger();
      count=amount;
      num1=count;
      num2=num1;
      result=1;
      arraynum=0;
      while(num2!=0)
      {
      while(num1!=0)
      {
      result=result*2;
      num1=num1-1;
      }
      displayArray(nArray);
      arraynum=arraynum+1;
      num2=num2-1;
      }
      getchar();
}

•

Join Date: Oct 2009

Posts: 65

Reputation: neithan is an unknown quantity at this point

Solved Threads: 2

neithan

Offline

Junior Poster in Training

#16

Oct 30th, 2009

•

Originally Posted by wangatang126

alright i totally revamped it, but it still immidiatly terminates. Why. Help fix please
Help with Code Tags

C Syntax (Toggle Plain Text)
# include <stdio.h>
# include "simpio.h"
# include "genlib.h"
# define SIZE 500
void displayArray(int nArray[])
{
int arraynum;
printf("%d        ",nArray[arraynum]);
}
 
 
main()
{     
      int amount,count,num1,num2,result,arraynum;
      int nArray[arraynum];
      amount=GetInteger();
      count=amount;
      num1=count;
      num2=num1;
      result=1;
      arraynum=0;
      while(num2!=0)
      {
      while(num1!=0)
      {
      result=result*2;
      num1=num1-1;
      }
      displayArray(nArray);
      arraynum=arraynum+1;
      num2=num2-1;
      }
      getchar();
}
# include <stdio.h> # include "simpio.h" # include "genlib.h" # define SIZE 500 void displayArray(int nArray[]) { int arraynum; printf("%d ",nArray[arraynum]); } main() { int amount,count,num1,num2,result,arraynum; int nArray[arraynum]; amount=GetInteger(); count=amount; num1=count; num2=num1; result=1; arraynum=0; while(num2!=0) { while(num1!=0) { result=result*2; num1=num1-1; } displayArray(nArray); arraynum=arraynum+1; num2=num2-1; } getchar(); }

Ok, you didn't pay attention to my first post trying to help you, so just answer this one.

Do you want us to fix your code or do you want to learn how to fix it by yourself?

Last edited by neithan; Oct 30th, 2009 at 6:49 am.