DaniWeb Forum Index > Software Development > C++

C++ RSS

Error reading file

Thread Solved

•

Join Date: Jul 2005

Posts: 15

Reputation: desidude is an unknown quantity at this point

Solved Threads: 0

desidude

Offline

Newbie Poster

Error reading file

Jul 9th, 2005

i tried this

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;
 
 
int main() 
{
    // Declare input stream
    ifstream fin;
    int min, max, val;
    int isFirst = true;
    fin.open("inFile.txt");
 
 
 
	fin >> isFirst;
    min = isFirst;
    max = isFirst;
 
    while (fin >> val)
    {
 
          fin >> val;
          if (val < min)
          val = min;
          else
          val = max;
 
    }
 
 
 
    fin.close();
 
    cout << "Largest value is " << max << ", smallest value is " << min << "\n";
	return 0;
}
#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;


int main() 
{
    // Declare input stream
    ifstream fin;
    int min, max, val;
    int isFirst = true;
    fin.open("inFile.txt");



	fin >> isFirst;
    min = isFirst;
    max = isFirst;

    while (fin >> val)
    {

          fin >> val;
          if (val < min)
          val = min;
          else
          val = max;
		  
    }



    fin.close();

    cout << "Largest value is " << max << ", smallest value is " << min << "\n";
	return 0;
}

<< moderator edit: added code tags: [code][/code] >>
and it prints this
Largest value is 1, smallest value is 1
Press any key to continue
can someone suggest me what's i am doing wrong here

•

Join Date: Apr 2004

Posts: 4,319

Reputation: Dave Sinkula has a brilliant future

Solved Threads: 230

Dave Sinkula Dave Sinkula is offline

Offline

long time no c

Re: Error reading file

Jul 9th, 2005

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
    while (fin >> val)
    {
 
          fin >> val;
          if (val < min)
          val = min;
          else
          val = max;
 
    }
    while (fin >> val)
    {

          fin >> val;
          if (val < min)
          val = min;
          else
          val = max;
		  
    }

Change min and/or max, not val.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
   while ( fin >> val )
   {
      if ( val < min )
      {
         min = val;
      }
      if ( val > max )
      {
         max = val;
      }
   }
   while ( fin >> val )
   {
      if ( val < min )
      {
         min = val;
      }
      if ( val > max )
      {
         max = val;
      }
   }

It might also be helpful to post the contents of "inFile.txt".

"One of the methods used by statists to destroy capitalism consists in establishing controls that tie a given industry hand and foot, making it unable to solve its problems, then declaring that freedom has failed and stronger controls are necessary." --Ayn Rand

•

Join Date: Jul 2005

Posts: 15

Reputation: desidude is an unknown quantity at this point

Solved Threads: 0

desidude

Offline

Newbie Poster

Re: Error reading file

Jul 9th, 2005

i tried the way u suggested me but it still gives same output
the content of "inFile.txt" is
100
45
74
45
86
94
75
96
56
85
82
88
88
56
77

•

Join Date: Apr 2004

Posts: 4,319

Reputation: Dave Sinkula has a brilliant future

Solved Threads: 230

Dave Sinkula Dave Sinkula is offline

Offline

long time no c

Re: Error reading file

Jul 9th, 2005

>i tried the way u suggested me but it still gives same output
Odd.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <fstream>
#include <iostream>
using namespace std;
 
 
int main() 
{
   ifstream fin("inFile.txt");
   int min, max, val;
   if ( fin >> val )
   {
      min = max = val;
      while ( fin >> val )
      {
         if ( val < min )
         {
            min = val;
         }
         if ( val > max )
         {
            max = val;
         }
      }
   }
   cout << "Largest value is " << max << ", smallest value is " << min << "\n";
   return 0;
}
 
/* my output
Largest value is 100, smallest value is 45
*/
#include <fstream>
#include <iostream>
using namespace std;


int main() 
{
   ifstream fin("inFile.txt");
   int min, max, val;
   if ( fin >> val )
   {
      min = max = val;
      while ( fin >> val )
      {
         if ( val < min )
         {
            min = val;
         }
         if ( val > max )
         {
            max = val;
         }
      }
   }
   cout << "Largest value is " << max << ", smallest value is " << min << "\n";
   return 0;
}

/* my output
Largest value is 100, smallest value is 45
*/

•

Join Date: Jul 2005

Posts: 15

Reputation: desidude is an unknown quantity at this point

Solved Threads: 0

desidude

Offline

Newbie Poster

Re: Error reading file

Jul 9th, 2005

i tried every possible way u suggested me and it still doesnt work. could it be some other problem?

•

Join Date: Feb 2005

Posts: 466

Reputation: winbatch is on a distinguished road

Solved Threads: 18

winbatch

Offline

Posting Pro in Training

Re: Error reading file

Jul 9th, 2005

Did you copy and paste what dave wrote and compiled it?

•

Join Date: Sep 2004

Posts: 7,541

Reputation: Narue has a reputation beyond repute

Solved Threads: 704

Narue

Offline

Code Goddess

Re: Error reading file

Jul 9th, 2005

>fin >> isFirst;
I think you mean:

Help with Code Tags

C++ Syntax (Toggle Plain Text)

fin>> val;

isFirst doesn't strike me as a data variable, it seems more like a status variable. You don't even need it. Oddly enough, I didn't bother looking at Dave's code, but my solution is only slightly different (but it avoids undefined behavior in the case of an empty or non-existent file):

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <fstream>
#include <iostream>
using namespace std;
 
int main() 
{
  ifstream fin("inFile.txt");
  int val;
 
  if (fin >> val) {
    int min, max;
 
    min = max = val;
 
    while (fin >> val)
    {
      if (val < min)
        min = val;
 
      if (val > max)
        max = val;
    }
 
    cout << "Largest value is " << max << ", smallest value is " << min << "\n";
  }
 
  return 0;
}
#include <fstream>
#include <iostream>
using namespace std;

int main() 
{
  ifstream fin("inFile.txt");
  int val;

  if (fin >> val) {
    int min, max;

    min = max = val;

    while (fin >> val)
    {
      if (val < min)
        min = val;

      if (val > max)
        max = val;
    }

    cout << "Largest value is " << max << ", smallest value is " << min << "\n";
  }

  return 0;
}

Great minds think alike, I suppose.

>i tried every possible way u suggested me and it still doesnt work.
Then instead of looking at the suggestions and implementing them they way you think they should be done, actually try them as they are written. In my experience, Dave doesn't post untested code.

I'm here to prove you wrong.

•

Join Date: Jul 2005

Posts: 15

Reputation: desidude is an unknown quantity at this point

Solved Threads: 0

desidude

Offline

Newbie Poster

Re: Error reading file

Jul 9th, 2005

thx a bunch guys
i am sorry dave it was my fault in implementing codes . its working
thx

•

Join Date: Jul 2005

Posts: 15

Reputation: desidude is an unknown quantity at this point

Solved Threads: 0

desidude

Offline

Newbie Poster

Re: Error reading file

Jul 9th, 2005

again need help guys
trying to calculate average of all numbers in previous program
here is what i did but it gives average = 77

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;
 
 
 
int main() 
 
{
 
   ifstream fin("inFile.txt");
   ofstream fout("outFile.txt");
 
   if (fin.fail())
   {
	   cout<<"Input file opening failed.\n";
	   exit(1);
   }
   if (fout.fail())
   {
	   cout<<"output file opening failed.\n";
	   exit(1);
   }
   int min, max, val;
   double sum = 0;
   int count = 0, next ;
 
 
 
   if ( fin >> val )
 
   {
 
 
      min = max = val;
      while ( fin >> val )
      {
 
 
         if ( val < min )
         {
            min = val;
         }
 
         if ( val > max )
         {
            max = val;
		 }
 
      }
	  sum = sum+val;
	   count=count++;
 
   }
 
 
 
 sum=sum/count;
 
 
 
   fout<<"average score is:"<< sum << "\n";
   cout<<"average score is:"<< sum << "\n";
 
 
   fout << "Largest value is " << max << ", smallest value is " << min << "\n";
   cout << "Largest value is " << max << ", smallest value is " << min << "\n";
   fin.close();
   fout.close();
 
   return 0;
}
#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;



int main() 

{
   	
   ifstream fin("inFile.txt");
   ofstream fout("outFile.txt");
   
   if (fin.fail())
   {
	   cout<<"Input file opening failed.\n";
	   exit(1);
   }
   if (fout.fail())
   {
	   cout<<"output file opening failed.\n";
	   exit(1);
   }
   int min, max, val;
   double sum = 0;
   int count = 0, next ;
          
 
	  
   if ( fin >> val )
	   
   {
	     
	  
      min = max = val;
      while ( fin >> val )
      {
		 
			  
         if ( val < min )
         {
            min = val;
         }
		 
         if ( val > max )
         {
            max = val;
		 }
		  
      }
	  sum = sum+val;
	   count=count++;

   }
           
   

 sum=sum/count;
	

   
   fout<<"average score is:"<< sum << "\n";
   cout<<"average score is:"<< sum << "\n";

   
   fout << "Largest value is " << max << ", smallest value is " << min << "\n";
   cout << "Largest value is " << max << ", smallest value is " << min << "\n";
   fin.close();
   fout.close();
   
   return 0;
}