DaniWeb Forum Index > Software Development > C++

Character Arrays

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Oct 2005

Posts: 11

Reputation: kdw3 is an unknown quantity at this point

Solved Threads: 0

kdw3

Offline

Newbie Poster

Character Arrays

Dec 4th, 2005

Im trying to create a simple RLC program. Im n ot sure the best way about it, but im trying to to use to 20 character arrays. One to read in the characters to be compressed (buffer) and the other is used to as a check. Either way, the buffer[20] reads in from a file and is fine, but other array (outputs[20]) does not read anything in, so when i set the first element of outputs[0] = buffer[0], i get the first letter of buffer, followed by a gibberish, which throws off all calculations. Code is below:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int Readchar(ifstream& fileread)
{
    char buffer[20];
    char temp;
    int space, count, length;
    count = 0;
    cout << fileread.peek() << endl;
    while (fileread.peek() != EOF)
    {
         fileread >> buffer;
         Checkbuffer(buffer);
         count ++;  
    }
    return 0;
}
 
 
int Checkbuffer(char buffer[])
{
    char outputs[20];
    int k, length, count, adj;
    adj = 0;
    count = 0;
    length = strlen(buffer);
    outputs[0] = buffer[0];
    cout << outputs;   
    for (k = 1; k <= length; k++)
    {
        if (buffer[k] == outputs[k-1])
        {
            outputs[k] = buffer[k];
        }
        else
        {
            Outputstring(outputs,k);
        }             
    }
    return 0;
}
int Readchar(ifstream& fileread)
{
    char buffer[20];
    char temp;
    int space, count, length;
    count = 0;
    cout << fileread.peek() << endl;
    while (fileread.peek() != EOF)
    {
         fileread >> buffer;
         Checkbuffer(buffer);
         count ++;  
    }
    return 0;
}


int Checkbuffer(char buffer[])
{
    char outputs[20];
    int k, length, count, adj;
    adj = 0;
    count = 0;
    length = strlen(buffer);
    outputs[0] = buffer[0];
    cout << outputs;   
    for (k = 1; k <= length; k++)
    {
        if (buffer[k] == outputs[k-1])
        {
            outputs[k] = buffer[k];
        }
        else
        {
            Outputstring(outputs,k);
        }             
    }
    return 0;
}

If anyone can suggest how to empty outputs[20] so it contains nothing, it would be appreciated.
Regards
Kevin

Last edited by Dave Sinkula; Dec 4th, 2005 at 2:08 pm. Reason: Added [code][/code] tags.

•

Join Date: Aug 2005

Posts: 15,569

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1484

Ancient Dragon Ancient Dragon is online now

Online

Still Learning

Re: Character Arrays

Dec 4th, 2005

cout << buffer -- buffer needs to be a null-terminated character array. when you defined buffer you did not initialize it to anything, that means it contains random characters and the buffer may or may not contain a null-terminating 0. So cout just keeps displaying characters searching all memory for the first 0, which may be considerably beyond the end of the buffer.

To avoid that problem, declare buffer like this

Help with Code Tags

(Toggle Plain Text)