DaniWeb Forum Index > Software Development > C

miserable fgets and a 2d array

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Apr 2005

Posts: 105

Reputation: jhdobbins is an unknown quantity at this point

Solved Threads: 3

jhdobbins

Offline

Junior Poster

miserable fgets and a 2d array

Apr 24th, 2006

Alright... first off I hate fgets with a passion

Anyway, I am wanting to read a file into a 2 dimensional array and then randomly select one of those lines to output...

What am I missing here?

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
void displayQuestion() {
 
/* fp is a FILE pointer.  This pointer will read text from 
   the "questions.txt" file */
 
     int aRandom, i, x;	
     char questions[25][300];	
     FILE *fp = fopen("questions.txt", "rt");
 
     if (*fp == NULL) {
	printf("Invalid File\n");
     }
 
     for(x = 0; x < 25; x++){
 
     	while( fgets(questions[x], sizeof(questions), fp) != NULL) {
 
     	}
 
     }
 
     aRandom = (rand()%25)+1;
 
    for(i = 0; i < 300; i++)
      {
      temp2=SCISR1;
      temp2=SCIDRL;
 
      while((SCISR1 & 0b10000000) != 0b10000000){}
 
      SCIDRL = question[aRandom][i];
      }
 
     //closes the file
     fclose(fp);
 
     getButtonPress();
 
}
void displayQuestion() {

/* fp is a FILE pointer.  This pointer will read text from 
   the "questions.txt" file */

     int aRandom, i, x;	
     char questions[25][300];	
     FILE *fp = fopen("questions.txt", "rt");

     if (*fp == NULL) {
	printf("Invalid File\n");
     }
	    
     for(x = 0; x < 25; x++){
	
     	while( fgets(questions[x], sizeof(questions), fp) != NULL) {
    
     	}
     
     }
	
     aRandom = (rand()%25)+1;

    for(i = 0; i < 300; i++)
      {
      temp2=SCISR1;
      temp2=SCIDRL;
     
      while((SCISR1 & 0b10000000) != 0b10000000){}
     
      SCIDRL = question[aRandom][i];
      }
          	
     //closes the file
     fclose(fp);

     getButtonPress();

}

Where

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
   for(i = 0; i < 300; i++)
      {
      temp2=SCISR1;
      temp2=SCIDRL;
 
      while((SCISR1 & 0b10000000) != 0b10000000){}
 
 
      SCIDRL = question[aRandom][i];
      }
   for(i = 0; i < 300; i++)
      {
      temp2=SCISR1;
      temp2=SCIDRL;
     
      while((SCISR1 & 0b10000000) != 0b10000000){}
     
     
      SCIDRL = question[aRandom][i];
      }

Prints out the question onto a terminal from a certain processor.

•

Join Date: Aug 2005

Posts: 5,273

Reputation: iamthwee is a splendid one to behold

Solved Threads: 378

iamthwee

Offline

Posting Expert

Re: miserable fgets and a 2d array

Apr 24th, 2006

If you don't like fgets, why don't u read the whole file in as single chars... using the '\n' to distinguish newlines.

a Ha ha.

Piworld ™
[Tis simple as Pie]

•

Join Date: Apr 2006

Posts: 26

Reputation: dude543 is an unknown quantity at this point

Solved Threads: 0

dude543

Offline

Light Poster

Re: miserable fgets and a 2d array

Apr 24th, 2006

Why do you hate fgets. Its my faviorate function.

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
char* fgets(char *s, int n, FILE *stream);
char* fgets(char *s, int n, FILE *stream);

fgets reads at most the next n-1 characters into the array s, stopping
if a newline is encounterd; the newline is included in the array, which
is terminated by '\0'. fgets returns s, or NULL if end of file or error
occurs.

replace

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
fgets(questions[x], sizeof(questions), fp)
fgets(questions[x], sizeof(questions), fp)

with

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
fgets(questions[x], sizeof(questions[0]), fp)
fgets(questions[x], sizeof(questions[0]), fp)

Notes for your code.
1) If fopen fail on the file, you still calling fgets. Error.
2) replace

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
aRandom = (rand()%25)+1;
aRandom = (rand()%25)+1;

why add 1 ?

array subscript from 0 to 24 !!

•

Join Date: Aug 2005

Posts: 5,273

Reputation: iamthwee is a splendid one to behold

Solved Threads: 378

iamthwee

Offline

Posting Expert

Re: miserable fgets and a 2d array

Apr 24th, 2006

gets() is my favourite function. :lol:

Piworld ™
[Tis simple as Pie]

•

Join Date: Sep 2004

Posts: 7,810

Reputation: Narue has a reputation beyond repute

Solved Threads: 747

Narue

Offline

Senior Bitch

Re: miserable fgets and a 2d array

Apr 24th, 2006

>Alright... first off I hate fgets with a passion
How can you hate something you don't completely understand? Don't confuse ignorance of fgets (or C in this case) with any legitimate problems that it has.

Just because you don't know how to use something doesn't mean there's anything wrong with it.

New members chased away this month: 3

•

Join Date: Dec 2005

Posts: 5,850

Reputation: Salem has a reputation beyond repute

Solved Threads: 751

Salem

Offline

Void main'ers are DOOMed

Re: miserable fgets and a 2d array

Apr 25th, 2006

> if (*fp == NULL)
You could start here - never mind the rest of it.

Say
if (fp == NULL)

Man, didn't your compiler complain about that line?

> while( fgets(questions[x], sizeof(questions), fp) != NULL)
If you lie about the buffer size, then it's no better than gets()

Besides, if you want to read up to 25 lines, its

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
for ( x = 0 ;
      x < 25 && fgets(questions[x], sizeof(questions[x]), fp) != NULL )
      x++ ) {
  char *p = strchr( questions[x], '\n' );
  if ( p ) *p = '\0';  /* blow away a newline - if you want to that is */
}
for ( x = 0 ;
      x < 25 && fgets(questions[x], sizeof(questions[x]), fp) != NULL )
      x++ ) {
  char *p = strchr( questions[x], '\n' );
  if ( p ) *p = '\0';  /* blow away a newline - if you want to that is */
}