DaniWeb Forum Index > Software Development > C++

sequencer

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2006

Posts: 6

Reputation: ontrix is an unknown quantity at this point

Solved Threads: 0

ontrix

Offline

Newbie Poster

sequencer

May 13th, 2006

hi there im having some problems, im trying to write a simple software sequencer in visual C++ under windows. I have a few problems my first two menus open up fine but the third wont open it just loops on the title menu. The second probelm i have is that all the sections dont play together any help would be great cheers ontrix code attached

Attached Files

code.txt (24.5 KB, 3 views)

•

Join Date: Dec 2005

Posts: 5,850

Reputation: Salem has a reputation beyond repute

Solved Threads: 751

Salem

Offline

Void main'ers are DOOMed

Re: sequencer

May 13th, 2006

You really need to discover the magic of
a) indentation
b) functions.

A 800+ lines of code in main(), c'mon be serious.
Nobody is going to wade through that lot just to spot what might be wrong.

A rough rule of thumb - if you can't see the entire function on screen at the same time (from it's opening brace to it's closing brace), then it's probably too big to manage.

I bet all those header files have code inside them as well right?

How about a separate function for each top-level menu choice.

>> snipped from the code...

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
  float edit_instrument1[5]; //edit the instrument for a note
  Instrmnt *instrument1 = 0; // This variable will hold the instrument information
  // snip
  float edit_instrument2[5]; //edit the instrument for a note
  Instrmnt *instrument2 = 0; // This variable will hold the instrument information
  float edit_instrument1[5]; //edit the instrument for a note
  Instrmnt *instrument1 = 0; // This variable will hold the instrument information
  // snip
  float edit_instrument2[5]; //edit the instrument for a note
  Instrmnt *instrument2 = 0; // This variable will hold the instrument information

Why isn't this screaming at you to be
a) a struct containing several things
b) an array of that struct.
That would cut down significantly on the number of variables you have.