DaniWeb Forum Index > Software Development > C++

Quick Question

Please support our C++ advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Oct 2006

Posts: 1

Reputation: The Leprechaun is an unknown quantity at this point

Solved Threads: 0

The Leprechaun The Leprechaun is offline

Offline

Newbie Poster

Quick Question

Oct 19th, 2006

ok well i started out with making my own source code then compiling and running with Dev-C++ and when i run it, its working fine until the last line, here let me past my code

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
// just a test
#include <iostream>
#include <string>
 
using namespace std;
 
int main ()
{
    string mystr;
    cout << "Hello, whats your name? ";
    getline (cin, mystr);
    cout << "Hello " << mystr << ".\n";
    cout << "What grade are you in" << mystr << "? ";
    getline (cin, mystr);
    cout << "Thats cool, I used to be in " << mystr << "too.\n";
    cout << "Well i'm going to go now, goodbye.";
    return 0;
}
// just a test
#include <iostream>
#include <string>

using namespace std;

int main ()
{
    string mystr;
    cout << "Hello, whats your name? ";
    getline (cin, mystr);
    cout << "Hello " << mystr << ".\n";
    cout << "What grade are you in" << mystr << "? ";
    getline (cin, mystr);
    cout << "Thats cool, I used to be in " << mystr << "too.\n";
    cout << "Well i'm going to go now, goodbye.";
    return 0;
}

i know its stupid, i just started and wanted to do something, but ok when i get to the part "what grade are you in << mystr << "? "; and when i enter my grade or w/e the box just closes, is there any way to fix this, would i have to put something like Press "q" to quit or something like that? Any help would be nice, thankyou

Last edited by The Leprechaun; Oct 19th, 2006 at 1:43 am.

•

Join Date: May 2006

Posts: 1,580

Reputation: Infarction has a spectacular aura about

Solved Threads: 52

Infarction Infarction is offline

Offline

Battle Programmer

Re: Quick Question

Oct 19th, 2006

try putting cin.get(); before your return statement.

•

Join Date: Oct 2006

Posts: 21

Reputation: easy is an unknown quantity at this point

Solved Threads: 0

easy

Offline

Newbie Poster

Re: Quick Question

Oct 22nd, 2006

run the in a command prompt then ull be able to see all the output before it quits. or try placing system("PAUSE") before the return statement, but i think thats bad practise to do that

Last edited by easy; Oct 22nd, 2006 at 1:11 am.

•

Join Date: Jun 2006

Posts: 7,652

Reputation: ~s.o.s~ has much to be proud of

Solved Threads: 474

~s.o.s~

Offline

Failure as a human

Re: Quick Question

Oct 22nd, 2006

•

Originally Posted by easy

run the in a command prompt then ull be able to see all the output before it quits. or try placing system("PAUSE") before the return statement, but i think thats bad practise to do that

Correct .
Its bad practice to use system calls to achieve such a trivial function.
Better use getchar() if using C and cin.get() when using C++.

I don't accept change; I don't deserve to live.

•

Join Date: Oct 2006

Posts: 21

Reputation: easy is an unknown quantity at this point

Solved Threads: 0

easy

Offline

Newbie Poster

Re: Quick Question

Oct 22nd, 2006

•

Originally Posted by ~s.o.s~

Correct .
Its bad practice to use system calls to achieve such a trivial function.
Better use getchar() if using C and cin.get() when using C++.

is this because the code isnt portable to other systems?

•

Join Date: Jun 2006

Posts: 7,652

Reputation: ~s.o.s~ has much to be proud of

Solved Threads: 474

~s.o.s~

Offline

Failure as a human

Re: Quick Question

Oct 23rd, 2006

Yes that and many other things to be considered like the kind of overhead introduced when you call system functions for trivial tasks.

A very good tutorial by my friend and forum member Mr. WaltP can be found here which introduces some of the things which should be avoided.
http://www.gidnetwork.com/b-61.html

I don't accept change; I don't deserve to live.

•

Join Date: Oct 2006

Posts: 57

Reputation: may4life is an unknown quantity at this point

Solved Threads: 2

may4life

Offline

Junior Poster in Training

Re: Quick Question

Nov 1st, 2006

getline() throws away the \n null character at the end of a string and therefore makes a mess when trying to fluch the buffer. Using cin.get() makes everything much more comfortable