DaniWeb Forum Index > Software Development > C++

C++ RSS

What's Wrong with my Array?

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Feb 2005

Posts: 21

Reputation: compshooter is an unknown quantity at this point

Solved Threads: 0

compshooter compshooter is offline

Offline

Newbie Poster

What's Wrong with my Array?

Nov 10th, 2006

I am just trying to print out my array of binary values from 0 to 15. The output I get is wrong, very very wrong.

Can someone take a look at my code and enlighten me?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <conio.h>
using namespace std;
int binA[16][4] = {
  (0,0,0,0),(0,0,0,1),(0,0,1,0),(0,0,1,1),
  (0,1,0,0),(0,1,0,1),(0,1,1,0),(0,1,1,1),
  (1,0,0,0),(1,0,0,1),(1,0,1,0),(1,0,1,1),
  (1,1,0,0),(1,1,0,1),(1,1,1,0),(1,1,1,1)}; 
int main()
{
  cout<<"This is the bin array:"<<endl;
  for (int r=0; r<16; r++)
  {
      for (int v=0; v<4; v++)
      {
        int t=v%4;
        cout<<binA[r][v];
        if (v==3)
          cout<<" ";
      }
  } 
getch();
return 0;
}
#include <iostream>
#include <conio.h>
using namespace std;
int binA[16][4] = {
  (0,0,0,0),(0,0,0,1),(0,0,1,0),(0,0,1,1),
  (0,1,0,0),(0,1,0,1),(0,1,1,0),(0,1,1,1),
  (1,0,0,0),(1,0,0,1),(1,0,1,0),(1,0,1,1),
  (1,1,0,0),(1,1,0,1),(1,1,1,0),(1,1,1,1)}; 
int main()
{
  cout<<"This is the bin array:"<<endl;
  for (int r=0; r<16; r++)
  {
      for (int v=0; v<4; v++)
      {
        int t=v%4;
        cout<<binA[r][v];
        if (v==3)
          cout<<" ";
      }
  } 
getch();
return 0;
}

The result I get is...

0101 0101 0101 0101 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000

What's going on

•

Join Date: Apr 2006

Posts: 5,051

Reputation: John A is a splendid one to behold

Solved Threads: 332

John A

Offline

Vampirical Lurker

Re: What's Wrong with my Array?

Nov 10th, 2006

It's because you are declaring your array like this:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int binA[16][4] = {
  (0,0,0,0),(0,0,0,1),(0,0,1,0),(0,0,1,1),
  (0,1,0,0),(0,1,0,1),(0,1,1,0),(0,1,1,1),
  (1,0,0,0),(1,0,0,1),(1,0,1,0),(1,0,1,1),
  (1,1,0,0),(1,1,0,1),(1,1,1,0),(1,1,1,1)};
int binA[16][4] = {
  (0,0,0,0),(0,0,0,1),(0,0,1,0),(0,0,1,1),
  (0,1,0,0),(0,1,0,1),(0,1,1,0),(0,1,1,1),
  (1,0,0,0),(1,0,0,1),(1,0,1,0),(1,0,1,1),
  (1,1,0,0),(1,1,0,1),(1,1,1,0),(1,1,1,1)};

When you should only be using braces:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int binA[16][4] = {
  {0,0,0,0},{0,0,0,1},{0,0,1,0},{0,0,1,1},
  {0,1,0,0},{0,1,0,1},{0,1,1,0},{0,1,1,1},
  {1,0,0,0},{1,0,0,1},{1,0,1,0},{1,0,1,1},
  {1,1,0,0},{1,1,0,1},{1,1,1,0},{1,1,1,1}};
int binA[16][4] = {
  {0,0,0,0},{0,0,0,1},{0,0,1,0},{0,0,1,1},
  {0,1,0,0},{0,1,0,1},{0,1,1,0},{0,1,1,1},
  {1,0,0,0},{1,0,0,1},{1,0,1,0},{1,0,1,1},
  {1,1,0,0},{1,1,0,1},{1,1,1,0},{1,1,1,1}};