DaniWeb Forum Index > Software Development > C

C RSS

Saving to a file from an array in C ?

•

Join Date: Apr 2005

Posts: 13

Reputation: Goldfish691 is an unknown quantity at this point

Solved Threads: 0

Goldfish691 Goldfish691 is offline

Offline

Newbie Poster

Saving to a file from an array in C ?

Nov 28th, 2006

Hi there,

I'm trying to write a simple encryption program that reads normal text from a txt file - encrypts it using a Vigenère Table - then outputs the results to another file. This process should obviously be reversible as well.

I have written this for the encryption part of the program:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
 
            input = fopen(argv[3], "r");
            output = fopen(argv[4], "w");
 
          flag = 0;
 
               while(flag==0)
                {
                   for(i=0;i<MAX;i++)
                    {
                         if((c = getc(input)) != EOF)
                         {
                           file[i] = c; 
                         }
                         else
                         {
                           file[i] = -1;
                           break;
                         }
 
                    }
 
                  encrypt(key,file,cipher);
 
                   for(i=0;i<MAX;i++)
                   { 
                        if(cipher[i]!=-1)
                        {
                        fprintf(output,"%c",cipher[i]);
                        }
                        else
                        {
                         fprintf(output,"%c",cipher[i]);
                         i = MAX;
                         flag = 1;  //this a flag that exits a while loop not included in this code.
                        } 
                   }        
                }  
                fclose(input);
                fclose(output);
 
            input = fopen(argv[3], "r");
            output = fopen(argv[4], "w");
    
          flag = 0;

               while(flag==0)
                {
                   for(i=0;i<MAX;i++)
                    {
                         if((c = getc(input)) != EOF)
                         {
                           file[i] = c; 
                         }
                         else
                         {
                           file[i] = -1;
                           break;
                         }
                            
                    }
                
                  encrypt(key,file,cipher);
    
                   for(i=0;i<MAX;i++)
                   { 
                        if(cipher[i]!=-1)
                        {
                        fprintf(output,"%c",cipher[i]);
                        }
                        else
                        {
                         fprintf(output,"%c",cipher[i]);
                         i = MAX;
                         flag = 1;  //this a flag that exits a while loop not included in this code.
                        } 
                   }        
                }  
                fclose(input);
                fclose(output);

The 'encrypt' function looks like this:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
 void encrypt(char *key,char *plainTxt,char *cipherTxt)
{
 int i,vig[MAX][MAX];
 char a,b;
 
 createVig(vig);            // Creates a standard Vig 128 x 128 table 
 
     for(i=0;i<MAX;i++)         // Loops for 128 characters
     {
      a = key[i];               // Assigns the value of key[i] to a    
      b = plainTxt[i];
 
      if(b!=-1)
      {            
      cipherTxt[i] = vig[a][b]; // Finds the new cipherTxt character and assigns it to cipherTxt[i]        
      }
      else
      {
      cipherTxt[i]=-1;
      i = MAX;
      }
     } 
}
 void encrypt(char *key,char *plainTxt,char *cipherTxt)
{
 int i,vig[MAX][MAX];
 char a,b;

 createVig(vig);            // Creates a standard Vig 128 x 128 table 
  
     for(i=0;i<MAX;i++)         // Loops for 128 characters
     {
      a = key[i];               // Assigns the value of key[i] to a    
      b = plainTxt[i];
      
      if(b!=-1)
      {            
      cipherTxt[i] = vig[a][b]; // Finds the new cipherTxt character and assigns it to cipherTxt[i]        
      }
      else
      {
      cipherTxt[i]=-1;
      i = MAX;
      }
     } 
}

I decrypt in almost the same way with a few differences. The problem im having is when I decrypt from the cipher text file it only gets about 200 characters in and then finds an EOF (-1) in the text file although there isnt one there.

I tested my algorithms by encrypting and decrypting without writing them to a file and they worked fine. I believe this has narrowed it down to how it is written to the file however, I don't know of any other ways in which to do it.

I hope that made sense to some one out there. Any help would be greatly appreciated.

Many Thanks

Craig

Free entry to win £1000

http://www.win1000free.co.uk

•

Join Date: Aug 2005

Posts: 5,264

Reputation: iamthwee is a splendid one to behold

Solved Threads: 377

iamthwee

Offline

Posting Expert

Re: Saving to a file from an array in C ?

Nov 29th, 2006

Try reading and writing in binary mode

I know from experience, that encryption programs have problems if you're using just .txt files.

Reading and writing in binary mode with a .dat file worked for me.

*Voted best profile in the world*

•

Join Date: May 2006

Posts: 3,114

Reputation: WaltP has much to be proud of

Solved Threads: 281

WaltP

Offline

Posting Sensei

Re: Saving to a file from an array in C ?

Nov 29th, 2006

Since only you know how the encryption works, we can only guess. And my guess is:
If your encryption changes a valid character to 0x1A, you get EOF in your file. To solve this, change your encrypted file to a binary file instead of text and that should solve your problem.

The 3 Laws of the Procrastination Society:
1) Never do today that which can be put off until tomorrow
2) Tomorrow never comes

•

Join Date: Apr 2005

Posts: 13

Reputation: Goldfish691 is an unknown quantity at this point

Solved Threads: 0

Goldfish691 Goldfish691 is offline

Offline

Newbie Poster

Re: Saving to a file from an array in C ?

Nov 29th, 2006

Hiya,

Thanks for your replies. I can say that i did try changing the extension to '.dat' however, I didn't realize that you could change the way the file is written. How do I change to writing in binary mode?

Regards

Craig

•

Join Date: Jun 2005

Posts: 275

Reputation: andor has a spectacular aura about

Solved Threads: 29

andor

Offline

Posting Whiz in Training

Re: Saving to a file from an array in C ?

Nov 29th, 2006

First of all you open the file in binary mode:



input = fopen(argv[3], "rb");

output = fopen(argv[4], "wb");

and then using fwrite function.

If you want to win, you must not loose (Alan Ford)

•

Join Date: Apr 2005

Posts: 13

Reputation: Goldfish691 is an unknown quantity at this point

Solved Threads: 0

Goldfish691 Goldfish691 is offline

Offline

Newbie Poster

Re: Saving to a file from an array in C ?

Nov 29th, 2006

Thanks for all the help...

I'm new to the fread and fwrite functions however, i have managed to get most of it working to try and keep it simple for testing i have made this algorithm.

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
 while(fread(file,128,1, input))
                 {
 
                       encrypt(key,file,cipher); //function that encrypts 128 bits at a time
 
                       decrypt(key,plain,cipher);//function that decrypts128 bits at a time
 
                      fwrite(plain, 128, 1,output);
 
                }
 while(fread(file,128,1, input))
                 {
                      
                       encrypt(key,file,cipher); //function that encrypts 128 bits at a time
                       
                       decrypt(key,plain,cipher);//function that decrypts128 bits at a time

                      fwrite(plain, 128, 1,output);

                }

this works however,cuts about 100 bits of the end. I thought it was because the while loop exits before the last bytes have been written so i added a fwrite outside of the loop but it writes the full 128 bites that were in the array. Is there a way of finding out how many bytes there are left before it reached the EOF marker so that i can set a variable? Or have a gone completely in the wrong direction and there is a super easy way to make this work?

thanks again.

Free entry to win £1000

http://www.win1000free.co.uk

•

Join Date: Jun 2005

Posts: 275

Reputation: andor has a spectacular aura about

Solved Threads: 29

andor

Offline

Posting Whiz in Training

Re: Saving to a file from an array in C ?

Nov 29th, 2006

Try something like this after the loop:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
printf("current position = %d\n", curr = ftell(file));
fseek(file, SEEK_END, 1); /* go to end of file */
printf("last position = %d\n", last = ftell(file));
printf("left = %d\n", last - curr);
printf("current position = %d\n", curr = ftell(file));
fseek(file, SEEK_END, 1); /* go to end of file */
printf("last position = %d\n", last = ftell(file));
printf("left = %d\n", last - curr);