DaniWeb Forum Index > Software Development > C

C RSS

What errors can occur while reading a file?

•

Join Date: May 2005

Posts: 86

Reputation: vicky_dev is an unknown quantity at this point

Solved Threads: 2

vicky_dev

Offline

Junior Poster in Training

What errors can occur while reading a file?

Dec 18th, 2006

I want to read a file which contains a list of integers. The first 4 bytes( or whatever sizeof(int) is ) indicates how many numbers the file has.
Suppose I check the file size before reading so that I know I won't encounter EOF. Do I still need to check for file read errors? Is yes, why and what would be the correct way to do it (i.e. check after each read or once at the end )

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
 
istream fin;
fin = open( "input.num", ios::in );
if( !fin )
... // Error
 
fin.seekg( 0, ios::end )	// Find file size
fileSize = fin.tellg( );
 
if( fileSize < sizeof( int ))	// Need atleast one int
...// Error	
 
fin.seekg( 0, ios::beg );
 
fin<<count;	// First int tells the number of ints in the file
// if( fin.bad( ))         // Check here too?
 
if( fileSize != (count+1)*sizeof(int)) // Verify file size
...// Error
 
for( i = 0; i < count; i++ )
{
	fin<<numbers[i];
//	if( fin.bad( ))         // Or shoud I use fin.fail( )? It wont be EOF
//		           // Should this be checked each time?
	...// Error		
}
 
// if( fin.fail( ))	// Or check error only once after reading?
	... // Error
 
 	...
istream fin;
fin = open( "input.num", ios::in );
if( !fin )
... // Error

fin.seekg( 0, ios::end )	// Find file size
fileSize = fin.tellg( );

if( fileSize < sizeof( int ))	// Need atleast one int
...// Error	

fin.seekg( 0, ios::beg );

fin<<count;	// First int tells the number of ints in the file
// if( fin.bad( ))         // Check here too?

if( fileSize != (count+1)*sizeof(int)) // Verify file size
...// Error
	
for( i = 0; i < count; i++ )
{
	fin<<numbers[i];
//	if( fin.bad( ))         // Or shoud I use fin.fail( )? It wont be EOF
//		           // Should this be checked each time?
	...// Error		
}

// if( fin.fail( ))	// Or check error only once after reading?
	... // Error

 	...

Does the same thing apply to writing to a file?

•

Join Date: Aug 2005

Posts: 15,348

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1461

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: What errors can occur while reading a file?

Dec 18th, 2006

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
fin.seekg( 0, ios::end )	// Find file size
fileSize = fin.tellg( );
 
if( fileSize < sizeof( int ))	// Need atleast one in
fin.seekg( 0, ios::end )	// Find file size
fileSize = fin.tellg( );

if( fileSize < sizeof( int ))	// Need atleast one in

Is the file a binary file or text file? If you view it in Notepad or some other text editor are the numbers readable? If they are, then more than likely it is a text file which means the test you are using to see if the file contains an integer will not work. Why? because the number '1' is only one byte long, not four bytes. Use Notepad or some other text editor to write the number '1' to a file then check the file size with Explorer or some other command-line program (depending on the os you are using). The file size will be from 1 to 3 depending on whether it contains the CR, or CR/LF line terminators.

>>fin<<count; // First int tells the number of ints in the file
this is wrong. should be
fin >> count;

And the extraction operator >> is for text files, not binary files. If the file is truely binary then use this
fin.read((char *)&count, sizeof(int));

>>fin<<numbers[i];
again, you used the wrong operator
fin >> numbers[i];

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
for( i = 0; i < count; i++ )
{
	fin<<numbers[i];
//	if( fin.bad( ))         // Or shoud I use fin.fail( )? It wont be EOF
//		           // Should this be checked each time?
	...// Error		
}
for( i = 0; i < count; i++ )
{
	fin<<numbers[i];
//	if( fin.bad( ))         // Or shoud I use fin.fail( )? It wont be EOF
//		           // Should this be checked each time?
	...// Error		
}

this is how I would have coded it

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
i = 0;
while( i < count && fin >> numbers[i] )
{
   ++i;
}
i = 0;
while( i < count && fin >> numbers[i] )
{
   ++i;
}

Last edited by Ancient Dragon; Dec 18th, 2006 at 12:26 pm.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: May 2005

Posts: 86

Reputation: vicky_dev is an unknown quantity at this point

Solved Threads: 2

vicky_dev

Offline

Junior Poster in Training

Re: What errors can occur while reading a file?

Dec 19th, 2006

>> Is the file a binary file or text file?

It is a text file, because I am creating the file in some other program.

>>this is how I would have coded it

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
i = 0;
while( i < count && fin >> numbers[i] )
{
   ++i;
}
i = 0;
while( i < count && fin >> numbers[i] )
{
   ++i;
}

Then how do you check if the file was read correctly, i.e. if all the numbers were read correctly or not?

•

Join Date: Oct 2006

Posts: 2,826

Reputation: niek_e has a reputation beyond repute

Solved Threads: 297

niek_e

Offline

Roasting Maven

Re: What errors can occur while reading a file?

Dec 19th, 2006

•

Originally Posted by vicky_dev

The first 4 bytes( or whatever sizeof(int) is ) indicates how many numbers the file has.

•

Originally Posted by vicky_dev

Then how do you check if the file was read correctly, i.e. if all the numbers were read correctly or not?

You could read the first integer into a variabel (for example x), then jump in the loop which you already have and when you reach EOF compare 'i ' with 'x'. If the numbers match, the file was read correctly.

Regards Niek

•

Join Date: May 2004

Posts: 178

Reputation: jim mcnamara is on a distinguished road

Solved Threads: 10

jim mcnamara jim mcnamara is offline

Offline

Junior Poster

Re: What errors can occur while reading a file?

Dec 19th, 2006

But yiu have to put the integer values out ther in the file in such a way that you can guarantee a read, ie, put it on a separate line with demarcation so you can see it is not part of the list (in case you forgot to write it in the first place, for example):

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
!5
1
2
3
4
5
!5
1
2
3
4
5

I just picked an "!" at random. If humans are going to read the file as well, try something like "linecount:5" so it doesn't confuse readers.

•

Join Date: Aug 2005

Posts: 15,348

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1461

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: What errors can occur while reading a file?

Dec 19th, 2006

•

Originally Posted by vicky_dev

Then how do you check if the file was read correctly, i.e. if all the numbers were read correctly or not?

fin will fail and return null if it encounters an error or on end-of-file.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

Quick Reply to Thread

Show Printable Version

Similar Threads

First year assigment on reading file, sorting and outputting invoice (C++)
Bubble sort & File output jibrish errors??? (C)
Reading from a file to fill an array (Java)
Error Message Concerning Reading File From A Drive (C++)
Errors with Linux file system (*nix Hardware Configuration)
reading a file into code (Java)

Other Threads in the C Forum

Previous Thread: Help me quickly please
Next Thread: question about sorting

Thread Tools	Search this Thread
Show Printable Version Email this Page

You need to join our community in order to build your list of favorite forums. You can visit the forum index for a listing of all forums.

Related Forum Features

C Forum

Software Development Forum

C Upvoted Threads (243)

C Solved Threads (1,202)

C News Stories (4)

C Code Snippets (232)

C Tutorials (1)

C Forum Search

Latest C Posts

Today's Posts
Unanswered Threads

DaniWeb Message

Cancel Changes