array output came many times (char,int array)

Please support our C++ advertiser: Programming Forums - DaniWeb Sister Site
Reply
1 2

•
•
Join Date: Nov 2006
Posts: 25
Reputation: sTorM is an unknown quantity at this point 
Solved Threads: 0
sTorM sTorM is offline Offline
Light Poster

array output came many times (char,int array)

 
0
  #1
Jan 2nd, 2007
Hi all,
How can make the output not to repeat again for many players. here is part of code.

C++ Syntax (Toggle Plain Text) 
  1. struct
  2. {
  3. int face;
  4. unsigned int value;
  5. } 
  6. card[13] = 
  7. {   {'2', 2},{'2', 3},{'2', 4},
  8.     {'5', 5},{'6', 6},{'7', 7},
  9.     {'8', 8},{'9', 9},{'X', 10},
  10.     {'J', 13},{'Q', 12},{'K', 11},
  11.     {'A', 1}
  12. };
  13. char suit[4]={'D','C','H','S'};


ex of output is (1 player): D9 ,H2,SQ....
(2 player) : CX,H8,D9...

D9 came to second time again!!! pls help me :eek:
Reply With Quote Quick reply to this message  
•
•
Join Date: Dec 2006
Posts: 209
Reputation: Ravalon is on a distinguished road 
Solved Threads: 15
Ravalon's Avatar
Ravalon Ravalon is offline Offline
Posting Whiz in Training

Re: array output came many times (char,int array)

 
0
  #2
Jan 2nd, 2007
I would create more of a deck than you have right now, and treat it as a stack. You would have 52 cards, each card would have a suit, a face, and a value, and you can shuffle and deal from it easily.
C++ Syntax (Toggle Plain Text) 
  1. #include <algorithm>
  2. #include <iostream>
  3. #include <string>
  4.  
  5. struct {
  6.   char suit;
  7.   std::string face;
  8.   int value;
  9. } deck[52];
  10.  
  11. struct {
  12.   const char *face;
  13.   int value;
  14. } cardValues[] = {
  15.   {"2", 2},{"3", 3},{"4", 4},
  16.   {"5", 5},{"6", 6},{"7", 7},
  17.   {"8", 8},{"9", 9},{"10", 10},
  18.   {"J", 13},{"Q", 12},{"K", 11},
  19.   {"A", 1}
  20. };
  21.  
  22. const char cardSuits[] = {'D','C','H','S'};
  23.  
  24. int main()
  25. {
  26.   using namespace std;
  27.  
  28.   int i = 0;
  29.  
  30.   // Build the deck
  31.   for ( int suit = 0; suit < 4; suit++ ) {
  32.     for ( int face = 0; face < 13; face++ ) {
  33.       deck[i].face = cardValues[face].face;
  34.       deck[i].value = cardValues[face].value;
  35.       deck[i].suit = cardSuits[suit];
  36.       ++i;
  37.     }
  38.   }
  39.  
  40.   // Shuffle the deck
  41.   random_shuffle( deck, deck + 52 );
  42.  
  43.   // Pop off hands of at most 5 until the deck is empty
  44.   int n = 1;
  45.  
  46.   for ( i = 0; i < 52; ) {
  47.     cout << "Hand #" << n++ << '\n';
  48.     for ( int j = 0; i < 52 && j < 5; i++, j++ )
  49.       cout << deck[i].suit << " -- " << deck[i].face << " -- " << deck[i].value << '\n';
  50.     cout << '\n';
  51.   }
  52.  
  53.   return 0;
  54. }
It's hard to be humble when you're as gifted as I am at pretending to be an expert.
Reply With Quote Quick reply to this message  
•
•
Join Date: Nov 2006
Posts: 25
Reputation: sTorM is an unknown quantity at this point 
Solved Threads: 0
sTorM sTorM is offline Offline
Light Poster

Re: array output came many times (char,int array)

 
0
  #3
Jan 2nd, 2007
Thank you! But when everytime i ran the program, output came the same. for example:

C++ Syntax (Toggle Plain Text) 
  1.  
  2. Hand #1
  3. D --A--1
  4. D--3--3
  5. D--J--13
  6. S--Q--12
  7. D--2--2

like that for Hand 1 for everytime.
And other hands too.:rolleyes:
Reply With Quote Quick reply to this message  
•
•
Join Date: Dec 2006
Posts: 209
Reputation: Ravalon is on a distinguished road 
Solved Threads: 15
Ravalon's Avatar
Ravalon Ravalon is offline Offline
Posting Whiz in Training

Re: array output came many times (char,int array)

 
0
  #4
Jan 2nd, 2007
•
•
•
•
Originally Posted by sTorM View Post
Thank you!
You're welcome!
•
•
•
•
Originally Posted by sTorM View Post
But when everytime i ran the program, output came the same.
Your random_shuffle() uses rand() to generate the shuffle and rand() is always seeded by default to 1. You can just change the seed each time and get something different.
C++ Syntax (Toggle Plain Text) 
  1. #include <cstdlib>
  2. #include <ctime>
  3. // Other includes...
  4.  
  5. // Deck definitions...
  6.  
  7. int main()
  8. {
  9.   using namespace std;
  10.  
  11.   // Build the deck...
  12.  
  13.   // Shuffle the deck
  14.   srand( (unsigned int)time( 0 ) );
  15.   random_shuffle( deck, deck + 52 );
  16.  
  17.   // Display the hands...
  18.  
  19.   return 0;
  20. }
Last edited by Ravalon; Jan 2nd, 2007 at 12:48 pm.
It's hard to be humble when you're as gifted as I am at pretending to be an expert.
Reply With Quote Quick reply to this message  
•
•
Join Date: Feb 2006
Posts: 505
Reputation: Bench has a spectacular aura about Bench has a spectacular aura about Bench has a spectacular aura about 
Solved Threads: 51
Bench's Avatar
Bench Bench is offline Offline
Posting Pro

Re: array output came many times (char,int array)

 
0
  #5
Jan 2nd, 2007
•
•
•
•
Originally Posted by Ravalon View Post
Your random_shuffle() uses rand() to generate the shuffle and rand() is always seeded by default to 1. You can just change the seed each time and get something different.
Edit - sorry, I misunderstood your post

Be careful with how you phrase that bit of advice. Seeding rand with time is a good idea, however, the call to srand() should only occur once - usually at the beginning of the program will do, in order to use a different seed whenever rand() is called.
Multiple calls to srand() will generally have the opposite effect
Last edited by Bench; Jan 2nd, 2007 at 1:06 pm.
¿umop apisdn upside down?
Reply With Quote Quick reply to this message  
•
•
Join Date: Dec 2006
Posts: 209
Reputation: Ravalon is on a distinguished road 
Solved Threads: 15
Ravalon's Avatar
Ravalon Ravalon is offline Offline
Posting Whiz in Training

Re: array output came many times (char,int array)

 
0
  #6
Jan 2nd, 2007
•
•
•
•
Originally Posted by Bench View Post
Be careful with how you phrase that bit of advice. Seeding rand with time is a good idea, however, the call to srand() should only occur once - usually at the beginning of the program will do, in order to use a different seed whenever rand() is called.
Multiple calls to srand() will generally have the opposite effect
Thank you, I will be more careful next time to say how one call to srand() takes care of multiple calls to rand().
It's hard to be humble when you're as gifted as I am at pretending to be an expert.
Reply With Quote Quick reply to this message  
•
•
Join Date: Nov 2006
Posts: 25
Reputation: sTorM is an unknown quantity at this point 
Solved Threads: 0
sTorM sTorM is offline Offline
Light Poster

Re: array output came many times (char,int array)

 
0
  #7
Jan 2nd, 2007
Oh ! now it comes real. I do appreicate of that .
But can i ask one more Q?
I want to know what is following ths:

C++ Syntax (Toggle Plain Text) 
  1. random_shuffle( deck, deck + 52 );

it seem to be function call. but no....:rolleyes:

And other one is when I ran with rand() I got one message..

C++ Syntax (Toggle Plain Text) 
  1. Error	1	error C2661: 'rand' : no overloaded function takes 1 arguments
Last edited by sTorM; Jan 2nd, 2007 at 1:43 pm. Reason: error
Reply With Quote Quick reply to this message  
•
•
Join Date: Dec 2006
Posts: 209
Reputation: Ravalon is on a distinguished road 
Solved Threads: 15
Ravalon's Avatar
Ravalon Ravalon is offline Offline
Posting Whiz in Training

Re: array output came many times (char,int array)

 
0
  #8
Jan 2nd, 2007
•
•
•
•
Originally Posted by sTorM View Post
Oh ! now it comes real. I do appreicate of that .
But can i ask one more Q?
I want to know what is following ths:

C++ Syntax (Toggle Plain Text) 
  1. random_shuffle( deck, deck + 52 );

it seem to be function call. but no....:rolleyes:
It is a function call. random_shuffle() is a standard C++ function from the <algorithm> header. It saves you the trouble of writing your own shuffling code. If you really wanted to, you could fake random_shuffle() manually.
C++ Syntax (Toggle Plain Text) 
  1. namespace Raye {
  2.   template <class T>
  3.   inline void swap( T& a, T& b )
  4.   {
  5.     T temp = a;
  6.     a = b;
  7.     b = temp;
  8.   }
  9.  
  10.   template <class T>
  11.   inline void random_shuffle( T *first, T *last )
  12.   {
  13.     if ( first != last) {
  14.       for ( T *i = first + 1; i != last; i++ ) {
  15.         T *b = first + rand() % ( i - first + 1 );
  16.         T temp = *i;
  17.         *i = *b;
  18.         *b = temp;
  19.       }
  20.     }
  21.   }
  22. }
But why bother when the standard library already gives it to you for free?
•
•
•
•
Originally Posted by sTorM View Post
And other one is when I ran with rand() I got one message..

C++ Syntax (Toggle Plain Text) 
  1. Error	1	error C2661: 'rand' : no overloaded function takes 1 arguments
It looks like you didn't use rand() the right way. I can't offer any other advice without seeing the code that caused that error. But I can guess that you wanted to limit the range of rand and tried to do that with an argument.
C++ Syntax (Toggle Plain Text) 
  1. // This does not give you a random number from 0 to 5
  2. rand( 5 );
  3.  
  4. // This does give you a random number from 0 to 5
  5. rand() % 5;
  6.  
  7. // This does too, and it's theoretically better, but more cryptic
  8.  rand() * ( 1.0 / ( RAND_MAX + 1.0 ) ) * 5;
It's hard to be humble when you're as gifted as I am at pretending to be an expert.
Reply With Quote Quick reply to this message  
•
•
Join Date: Jun 2006
Posts: 7,651
Reputation: ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of ~s.o.s~ has much to be proud of 
Solved Threads: 474
Super Moderator
Featured Poster
~s.o.s~'s Avatar
~s.o.s~ ~s.o.s~ is offline Offline
Failure as a human

Re: array output came many times (char,int array)

 
1
  #9
Jan 2nd, 2007
•
•
•
•
Originally Posted by Ravalon
c Syntax (Toggle Plain Text) 
  1. struct {
  2.   char suit;
  3.   std::string face;
  4.   int value;
  5. } deck[52];
Ravalon, have you enabled all the warnings in your compiler settings (-Wall) since the above flags a warning saying "error: no matching function for call to `random_shuffle(<anonymous struct>[52], <anonymous struct>*)' ". You better name the struct just for standard's sake, its not good to let warnings hang around in your programs.
•
•
•
•
Originally Posted by Ravalon View Post
It is a function call. random_shuffle() is a standard C++ function from the <algorithm> header. It saves you the trouble of writing your own shuffling code.
...with such talk of random_shuffle, I would recommend the people to read this.

•
•
•
•
namespace Raye {
  template <class T>
  inline void swap( T& a, T& b )
  {
    T temp = a;
    a = b;
    b = temp;
  }

  template <class T>
  inline void random_shuffle( T *first, T *last )
  {
    if ( first != last) {
      for ( T *i = first + 1; i != last; i++ ) {
        T *b = first + rand() % ( i - first + 1 );
         T temp = *i;
        *i = *b;
        *b = temp;
      }
    }
  }
}
I wonder why you wrote the swap subroutine...
I don't accept change; I don't deserve to live.

Jo Tujhe Jagaaye, Nindein Teri Udaaye Khwaab Hai Sachcha Wahi.
Nindon Mein Jo Aaye Jise To Bhul Jaaye Khawab Woh Sachcha Nahi.
Khwaab Ko Raag De, Nind Ko Aag De
Reply With Quote Quick reply to this message  
•
•
Join Date: Dec 2006
Posts: 209
Reputation: Ravalon is on a distinguished road 
Solved Threads: 15
Ravalon's Avatar
Ravalon Ravalon is offline Offline
Posting Whiz in Training

Re: array output came many times (char,int array)

 
0
  #10
Jan 2nd, 2007
•
•
•
•
Originally Posted by ~s.o.s~ View Post
Ravalon, have you enabled all the warnings in your compiler settings (-Wall) since the above flags a warning saying "error: no matching function for call to `random_shuffle(<anonymous struct>[52], <anonymous struct>*)' ". You better name the struct just for standard's sake, its not good to let warnings hang around in your programs.
I did compile with full warnings, but my compiler isn't that smart. I guess I was trying to be too C-like and got burned yet again. The best part is that I originally had the structs named and went out of my way to remove them.
•
•
•
•
Originally Posted by ~s.o.s~ View Post
I wonder why you wrote the swap subroutine...
Subconsciously making the snippet look more complex than it needed to be I guess.
It's hard to be humble when you're as gifted as I am at pretending to be an expert.
Reply With Quote Quick reply to this message  
Reply
1 2

Quick Reply to Thread
This thread is more than three months old.
Perhaps start a new thread instead?
•
•
•
•
•
•
•
•
Message:
•
•
•
•



Other Threads in the C++ Forum


Views: 2693 | Replies: 11
Thread Tools Search this Thread



Tag cloud for C++
6 add api array arrays beginner binary bitmap c++ c/c++ calculator char class classes code compile compiler console conversion convert count data delete desktop directshow dll encryption error file forms fstream function functions game getline givemetehcodez google graph homeworkhelper iamthwee ifstream input int integer java lazy lib linkedlist linux loop looping loops map math matrix memory microsoft newbie news node number output parameter pointer problem program programming project proxy python random read recursion recursive reference return sort string strings struct studio system template templates test text tree unix url variable vector video visual visualstudio win32 windows winsock word wordfrequency wxwidgets
About Us | Contact Us | Advertise | DaniWeb | Acceptable Use Policy | RSS Feed

©2003 - 2009 DaniWeb® LLC