problem in inserting data in msaccess

Reply

Join Date: Jan 2007
Posts: 1
Reputation: kiranme is an unknown quantity at this point 
Solved Threads: 0
kiranme kiranme is offline Offline
Newbie Poster

problem in inserting data in msaccess

 
0
  #1
Feb 8th, 2007
<%@ page language = "java" import = "java.sql.*" %>
<%@ page import = "java.sql.*" %>
<%@ page import = "java.text.*" %>
<%
String username,passw,passw1,compnam,tinn;
username= request.getParameter("username");
passw = request.getParameter("pwd");
passw1 = request.getParameter("pwd1");
compnam = request.getParameter("compname");
tinn=request.getParameter("TIN");


Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
String st = "jdbc:odbc:loginval";
Connection cn = DriverManager.getConnection(st," "," ");
Statement stmt = cn.createStatement();
String sql = "insert into register " ;
sql +="(username,pwd,pwd1,compname,TIN)";
sql += " values ('";
sql += username ;
sql += "','";
sql += passw;
sql += "','";
sql += passw1;
sql += "','" ;
sql += compnam ;
sql += "','" ;
sql += tinn;
sql += "')";
int val = stmt.executeUpdate(sql);
cn.close();
if(val==1)
{
%>
<jsp:forward page = "success.html"/>
<%
}
%>
-----------------------------------------------------------------------------------------------
this is my code, i am not able to insert any values in to my table thru this code, when i submit for the first time null values are stored in the table i mean "null" is getting displayed in the table.
when i submit for the second time then the server throws an error "general error"
some one help me plz
thanks in advance
Reply With Quote Quick reply to this message  
Join Date: Nov 2004
Posts: 6,143
Reputation: jwenting is just really nice jwenting is just really nice jwenting is just really nice jwenting is just really nice 
Solved Threads: 213
Team Colleague
jwenting's Avatar
jwenting jwenting is offline Offline
duckman

Re: problem in inserting data in msaccess

 
0
  #2
Feb 8th, 2007
YUGH!!!!!!

You don't properly close your database resource, you use String concatenation all over the place, you have massive scriptlets in a JSP, you place business logic in a JSP, you don't use code tags.

And you don't seem to understand what you're doing.

Of course it stores all null values when you call the page as those request parameters won't have been set.
And most likely the error on subsequent calls is a primary key violation from trying to insert another null value (I guess you declared username to be unique).
As people are clearly allowed to attack me but I'm not allowed to defend myself, I no longer post to this site.
Reply With Quote Quick reply to this message  
Reply

This thread is more than three months old.
Perhaps start a new thread instead?
Message:


Thread Tools Search this Thread



About Us | Contact Us | Advertise | DaniWeb | Acceptable Use Policy | RSS Feed

©2003 - 2009 DaniWeb® LLC