Python

Python RSS

just for fun

•

Join Date: Jul 2006

Posts: 608

Reputation: jrcagle is on a distinguished road

Solved Threads: 150

jrcagle

Offline

Practically a Master Poster

just for fun

Feb 13th, 2007

I'm re-creating the classic PacMan for the fun of it and needed a way to translate back and forth between directions and dx, dy for a sprite. Here was a fun solution that avoided cumbersome if...elif...elif...elif... chains. Any thoughts on readability, efficiency? Specifically, if this gets called by 4 monsters and 1 pacman every clock-tick = 1/60 sec, am I likely to run into trouble?

Jeff

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
def get_direction(dx,dy):
 
    dirs = {'dx == 0 and dy < 0': 'up',  # in actual program, maps to self.UP == 0
            'dx < 0 and dy == 0': 'left',
            'dx == 0 and dy > 0': 'down',
            'dx > 0 and dy == 0': 'right'}
 
    for d in dirs:
        if eval(d):
            return dirs[d]
    return None
def get_direction(dx,dy):

    dirs = {'dx == 0 and dy < 0': 'up',  # in actual program, maps to self.UP == 0
            'dx < 0 and dy == 0': 'left',
            'dx == 0 and dy > 0': 'down',
            'dx > 0 and dy == 0': 'right'}

    for d in dirs:
        if eval(d):
            return dirs[d]
    return None

Last edited by jrcagle; Feb 13th, 2007 at 3:36 pm.

•

Join Date: Sep 2005

Posts: 133

Reputation: mawe is an unknown quantity at this point

Solved Threads: 58

mawe

Offline

Junior Poster

Re: just for fun

Feb 13th, 2007

Hi!

Well, at least it's an interesting way to do it

Because Python is an OO language, I would probably have a class Monster and an instance-variable self.current_direction. I think this would be cleaner.

Regards, mawe

•

Join Date: Jul 2006

Posts: 608

Reputation: jrcagle is on a distinguished road

Solved Threads: 150

jrcagle

Offline

Practically a Master Poster

Re: just for fun

Feb 13th, 2007

I think you're right. The problem I was having was a disconnect between the direction and the dx, dy. The better solution is, IMO,

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
 
def get_direction(self):
   return self._direction
 
def set_direction(self, value):
  self._direction = value
  dx,dy = {UP:  (0,-1),
           LEFT: (-1,0),
           DOWN: (0,1),
           RIGHT:(1,0)} [self._direction]
 
direction = property(get_direction, set_direction)
def get_direction(self):
   return self._direction

def set_direction(self, value):
  self._direction = value
  dx,dy = {UP:  (0,-1),
           LEFT: (-1,0),
           DOWN: (0,1),
           RIGHT:(1,0)} [self._direction]

direction = property(get_direction, set_direction)