Java

Java RSS

compareTo Method

Please support our Java advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Jan 2007

Posts: 36

Reputation: cassyjack is an unknown quantity at this point

Solved Threads: 0

cassyjack

Offline

Light Poster

compareTo Method

Feb 28th, 2007

Hi need a little help I cant see whats wrong with this code can someone take a look at this and steer me in the right direction.

Specs say: I have to make hands comparable. I only comparing hands of the same length. One hand is bigger than another if the largest card of the first hand is larger than the largest card of the second hand:

Help with Code Tags

(Toggle Plain Text)

public int compareTo(Hand otherHand)
    {
        for (int i=theHand.length; i >theHand.length; i--)
        {
            if (getHand()[i]!= otherHand.getHand()[i])
                return getHand()[i].compareTo( otherHand.getHand()[i]);
            }
            return 0;
        }

In my driver this is what I have

Help with Code Tags

(Toggle Plain Text)

int biggestHand = playerHand.compareTo (computerHand);
            if (biggestHand > 0)
                JOptionPane.showMessageDialog(player wins);
            else if (biggestHand < 0)
                 JOptionPane.showMessageDialog(computers wins);
            else
                JOptionPane.showMessageDialog(tie);

it keeps tieing.

•

Join Date: Nov 2004

Posts: 6,143

Reputation: jwenting is just really nice

Solved Threads: 212

jwenting

Offline

duckman

Re: compareTo Method

Feb 28th, 2007

apart from your compareTo method never returning anything but 0 (at least from the part you posted)?

And of course you're violating the Comparable contract by having the signature of your compareTo method take a Hand instance instead of an Object, so it's quite possible it never gets called at all.

As people are clearly allowed to attack me but I'm not allowed to defend myself, I no longer post to this site.

•

Join Date: Jan 2007

Posts: 36

Reputation: cassyjack is an unknown quantity at this point

Solved Threads: 0

cassyjack

Offline

Light Poster

Re: compareTo Method

Feb 28th, 2007

Here's what I have now Im getting error array out of bounds

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
 public int compareTo(Object otherObject)
{   Hand otherHand = (Hand) otherObject;
    Card biggestCardHand = getHand()[0];
    Card  biggestCardotherHand = otherHand.getHand()[0];
 
    for ( int i = 0; i <= theHand.length; i++) /*assuming you start your array with 0 */
    {
        if (biggestCardHand.compareTo(getHand()[i])< 0)
       {
         biggestCardHand = getHand()[i];
       }
       if (biggestCardotherHand.compareTo(otherHand.getHand()[i])<0)
      {
        biggestCardotherHand = otherHand.getHand()[i];
      }
    }//end loop
        if (biggestCardHand.compareTo(biggestCardotherHand)< 0)
        {
          return 1;
         }
        else
            if (biggestCardHand.compareTo(biggestCardotherHand)> 0)
       {
          return -1;            
        }
 
 
        return 0;
}//end compareTO
 public int compareTo(Object otherObject)
{   Hand otherHand = (Hand) otherObject;
    Card biggestCardHand = getHand()[0];
    Card  biggestCardotherHand = otherHand.getHand()[0];
    
    for ( int i = 0; i <= theHand.length; i++) /*assuming you start your array with 0 */
    {
        if (biggestCardHand.compareTo(getHand()[i])< 0)
       {
         biggestCardHand = getHand()[i];
       }
       if (biggestCardotherHand.compareTo(otherHand.getHand()[i])<0)
      {
        biggestCardotherHand = otherHand.getHand()[i];
      }
    }//end loop
        if (biggestCardHand.compareTo(biggestCardotherHand)< 0)
        {
          return 1;
         }
        else
            if (biggestCardHand.compareTo(biggestCardotherHand)> 0)
       {
          return -1;            
        }
       
              
        return 0;
}//end compareTO