DaniWeb Forum Index > Software Development > C++

average array

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2007

Posts: 11

Reputation: mathgirl is an unknown quantity at this point

Solved Threads: 0

mathgirl

Offline

Newbie Poster

average array

May 3rd, 2007

I am trying to write a program that will prompt the user for six grades to be entered (one at a time), read in each grade entered by the user, and store them in an array of six elements. Grades should be on a 0 to 4.0 (inclusive) scale, and the program should accept only grades within that range. I.e. whenever the user enters a grade less than 0 or greater than 4.0, the program will prompt the user to re-enter that grade within the correct range (and do so repeatedly, as long as he/she continues to enter an invalid grade).
The program I wrote doesn't work properly, and I can't figure out what my problem is.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <iomanip>
using namespace std;
int main()
{
int grade[6];
int i, total = 0;
double average;

cout.setf(ios::fixed);
cout.setf(ios::showpoint);
cout.precision(2); 

for (i = 0; i <= 5; i++){
cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
cin >> grade[i]; 
{
while(grade[i] < 0.0 || grade[i] > 4.0)
{
cout << "Enter a grade on a scale of 0.0 to 4.0: ";
}
cin >> grade[i];
}
}

for(i = 0; i <= 5; i++)
total = total + grade[i];
average = total/6.0;
}
#include <iostream>
#include <iomanip>
using namespace std;
int main()
{
int grade[6];
int i, total = 0;
double average;

cout.setf(ios::fixed);
cout.setf(ios::showpoint);
cout.precision(2); 

for (i = 0; i <= 5; i++){
cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
cin >> grade[i]; 
{
while(grade[i] < 0.0 || grade[i] > 4.0)
{
cout << "Enter a grade on a scale of 0.0 to 4.0: ";
}
cin >> grade[i];
}
}

for(i = 0; i <= 5; i++)
total = total + grade[i];
average = total/6.0;
}

Last edited by cscgal; May 13th, 2007 at 2:12 pm. Reason: Added code tags

•

Join Date: Dec 2006

Posts: 2,048

Reputation: Aia has much to be proud of

Solved Threads: 179

Aia

Offline

Postaholic

Re: average array

May 3rd, 2007

>while(grade[i] < 0.0 || grade[i] > 4.0) Change to while( grade[i] < 0.0 && grade[i] > 4.0)

"If it moves, tax it. If it keeps moving, regulate it, and if it stops moving, subsidize it" - Ronald Reagan

•

Join Date: May 2006

Posts: 1,580

Reputation: Infarction has a spectacular aura about

Solved Threads: 52

Infarction Infarction is offline

Offline

Battle Programmer

Re: average array

May 3rd, 2007

•

Originally Posted by Aia

>while(grade[i] < 0.0 || grade[i] > 4.0) Change to while( grade[i] < 0.0 && grade[i] > 4.0)

No, don't, it would always be false. A number can't be less than 0 and greater than 4. Instead, try moving your second line cin>>grad[i]; into the while loop. Right now it just outputs the warning message and loops, since grade[i] never changes

[edit:] And for future reference, please post code between [code] and [/code] tags, which will automatically number them and maintain indentation. Thanks

Last edited by Infarction; May 3rd, 2007 at 8:40 pm.

•

Join Date: Dec 2006

Posts: 2,048

Reputation: Aia has much to be proud of

Solved Threads: 179

Aia

Offline

Postaholic

Re: average array

May 3rd, 2007

•

Originally Posted by Infarction

No, don't, it would always be false. A number can't be less than 0 and greater than 4. Instead, try moving your second line cin>>grad[i]; into the while loop. Right now it just outputs the warning message and loops, since grade[i] never changes

[edit:] And for future reference, please post code between [code] and [/code] tags, which will automatically number them and maintain indentation. Thanks

My apologies. You are correct. I don't know what I was thinking.

"If it moves, tax it. If it keeps moving, regulate it, and if it stops moving, subsidize it" - Ronald Reagan

•

Join Date: Apr 2007

Posts: 11

Reputation: mathgirl is an unknown quantity at this point

Solved Threads: 0

mathgirl

Offline

Newbie Poster

Re: average array

May 3rd, 2007

I moved the cin >> grade[i] into the while loop. I am having a problem because when I enter wrong numbers and it prompts me to enter a new number it includes it as a number in the array and prompts for less numbers.
Thanks!

•

Join Date: Apr 2007

Posts: 103

Reputation: mariocatch is an unknown quantity at this point

Solved Threads: 17

mariocatch mariocatch is offline

Offline

Junior Poster

Re: average array

May 3rd, 2007

post your new code and ill help you out.

•

Join Date: Apr 2007

Posts: 11

Reputation: mathgirl is an unknown quantity at this point

Solved Threads: 0

mathgirl

Offline

Newbie Poster

Re: average array

May 3rd, 2007

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
 #include <iostream>
#include <iomanip>
using namespace std;
int main()
{
    int grade[6];
    int i, total = 0;
    double average;
 
    cout.setf(ios::fixed);
    cout.setf(ios::showpoint);
    cout.precision(2);  
 
    for (i = 0; i <= 5; i++){
        cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
        {
        while(grade[i] < 0.0 || grade[i] > 4.0)
        cin >> grade[i];
        {
   cout << "Enter a grade on a scale of 0.0 to 4.0: ";
        }
        cin >> grade[i];
        }
    }
 
    for(i = 0; i <= 5; i++)
        total = total + grade[i];
    average = total/6.0;
    cout << average << endl;
}
 #include <iostream>
#include <iomanip>
using namespace std;
int main()
{
    int grade[6];
    int i, total = 0;
    double average;
         
    cout.setf(ios::fixed);
    cout.setf(ios::showpoint);
    cout.precision(2);  
         
    for (i = 0; i <= 5; i++){
        cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
        {
        while(grade[i] < 0.0 || grade[i] > 4.0)
        cin >> grade[i];
        {
   cout << "Enter a grade on a scale of 0.0 to 4.0: ";
        }
        cin >> grade[i];
        }
    }
        
    for(i = 0; i <= 5; i++)
        total = total + grade[i];
    average = total/6.0;
    cout << average << endl;
}

•

Join Date: Apr 2006

Posts: 5,051

Reputation: John A is a splendid one to behold

Solved Threads: 332

John A

Offline

Vampirical Lurker

Re: average array

May 3rd, 2007

Did you even change anything?

Look at it this way: you need to grab the user's input before the while loop, so that you can see if it was invalid or not. Then if it's invalid, the while loop kicks in, which keeps grabbing input until it's valid. Inside the braces { and } of the while loop, you need to have that cin statement.

Here's how it would look:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
    for (i = 0; i <= 5; i++){
            cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
//        { <- don't need these braces
            cin >> grade[i];
 
            while(grade[i] < 0.0 || grade[i] > 4.0)
            {
                cout << "Enter a grade on a scale of 0.0 to 4.0: ";
                cin >> grade[i];
            }
//        } <- don't need this
    }
    for (i = 0; i <= 5; i++){
            cout << "Enter grade " << i << " (on a scale of 0.0 to 4.0): ";
//        { <- don't need these braces
            cin >> grade[i];
            
            while(grade[i] < 0.0 || grade[i] > 4.0)
            {
                cout << "Enter a grade on a scale of 0.0 to 4.0: ";
                cin >> grade[i];
            }
//        } <- don't need this
    }

Last edited by John A; May 3rd, 2007 at 10:45 pm.

"Technological progress is like an axe in the hands of a pathological criminal."

All my posts may be freely redistributed under the terms of the MIT license.

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 30

Nichito

Offline

Nearly a Posting Virtuoso

Re: average array

May 3rd, 2007

why not better do it less complicated:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
for (i=0;i<=5;i++){
   do{
      cout<<"Enter grade "<<i<<" on a scale from 0.0 to 4.0: ";
      cin>>grade[i];
   }while ((grade[i]<0.00)||(grade[i]>4.00));
}
for (i=0;i<=5;i++){
   do{
      cout<<"Enter grade "<<i<<" on a scale from 0.0 to 4.0: ";
      cin>>grade[i];
   }while ((grade[i]<0.00)||(grade[i]>4.00));
}

Last edited by Nichito; May 3rd, 2007 at 11:34 pm.

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: Dec 2006

Posts: 8

Reputation: Gel is an unknown quantity at this point

Solved Threads: 2

Gel

Offline

Newbie Poster

Re: average array

#10

May 4th, 2007

do you know wat???

if you want the code to be in between 0 and 4.0,its should be
while(grade>0&&grade<4.0)

also int won't read floating point nos.,

sorry if i'm wrong!!!

try the program now and let me know!!!