DaniWeb Forum Index > Web Development > PHP

what's wrong in this code?

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

Last »

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

what's wrong in this code?

Aug 21st, 2007

so, i started at php and i'm doing some exercises from the book, but when i type this code into my "view.php", the output is all wrong...

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
  <?php include("dbconnect.php") ?>
 
  <h2>View my GuestBook!!</h2>
 
  <?php
 
  $result=mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row=mysql_fetch_array($result))
  {
     echo "<b>Name:</b>";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($reslut);
  ?>
  <?php include("dbconnect.php") ?>
  
  <h2>View my GuestBook!!</h2>

  <?php

  $result=mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row=mysql_fetch_array($result))
  {
     echo "<b>Name:</b>";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($reslut);
  ?>

the output is like this:

•

View my GuestBook!!

Name:"; echo $row["name"]; echo "
\n"; echo "Location:"; echo $row["location"]; echo "
\n"; echo "Email:"; echo $row["email"]; echo "
\n"; echo "URL:"; echo $row["url"]; echo "
\n"; echo "Comments:"; echo $row["comments"]; echo "
\n"; echo "
\n"; echo "
\n"; } mysql_free_result($reslut); ?>

Sign my GuestBook

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: Jul 2007

Posts: 142

Reputation: MitkOK is an unknown quantity at this point

Solved Threads: 12

MitkOK

Offline

Junior Poster

Re: what's wrong in this code?

Aug 21st, 2007

I think your server doesn't recognize php file, so
it doesn't interpret it. Do you install and configure
correctly PHP ?

- Mitko Kostov

Last edited by MitkOK; Aug 21st, 2007 at 1:26 pm.

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

Aug 21st, 2007

i installed XAMPP... and i already made another php file that worked correctly, which was the one that writes the information this one is supposed to read...

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

Aug 21st, 2007

here are all my codes:

dbconnect.php

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<?php
mysql_connect("localhost","nobody","ydobon")
   or die("<h3>could not connect to MySQL</h3>\n");
mysql_select_db("guestbook")
   or die("<h3>could not select database 'guestbook'</h3>\n");
?>
<?php
mysql_connect("localhost","nobody","ydobon")
   or die("<h3>could not connect to MySQL</h3>\n");
mysql_select_db("guestbook")
   or die("<h3>could not select database 'guestbook'</h3>\n");
?>

sign.php

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <h2>Sign my guestbook!</h2>
  <form method="post" action="create_entry.php">
 
     <b>Name:</b>
     <input type="text" size="40" name="name">
     <br>
     <b>Location:</b>
     <input type="text" size="40" name="location">
     <br>
     <b>Email:</b>
     <input type="text" size="40" name="email">
     <br>
     <b>Home Page URL:</b>
     <input type="text" size="40" name="url">
     <br>
     <b>Comments:</b>
     <textarea name="comments" cols="40" rows="4"
     wrap="virtualv"></textarea>
     <br>
 
     <input type="submit" name="submit" value="Sign!">
     <input type="reset" name="reset" value="Start Over">
 
     </form>
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>

 <BODY>
  <h2>Sign my guestbook!</h2>
  <form method="post" action="create_entry.php">
     
     <b>Name:</b>
     <input type="text" size="40" name="name">
     <br>
     <b>Location:</b>
     <input type="text" size="40" name="location">
     <br>
     <b>Email:</b>
     <input type="text" size="40" name="email">
     <br>
     <b>Home Page URL:</b>
     <input type="text" size="40" name="url">
     <br>
     <b>Comments:</b>
     <textarea name="comments" cols="40" rows="4"
     wrap="virtualv"></textarea>
     <br>

     <input type="submit" name="submit" value="Sign!">
     <input type="reset" name="reset" value="Start Over">

     </form>
 </BODY>
</HTML>

create_entry.php

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <?php
  include("dbconnect.php");
 
  if ($_REQUEST["submit"]=="Sign!")
  {
     $query="insert into guestbook(name,location,email,url,comments) values ('"
            .$_REQUEST["name"]
            ."', '"
            .$_REQUEST["location"]
            ."', '"
            .$_REQUEST["email"]
            ."', '"
            .$_REQUEST["url"]
            ."', '"
            .$_REQUEST["comments"]
            ."') "
     ;
     mysql_query($query);
 ?>
 <h2>Thanks!!</h2>
 <h2><a href="view.php">View my GuestBook!!</a></h2>
 <?php
 }
 else
 {
    include("sign.php");
 }
 ?>
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>

 <BODY>
  <?php
  include("dbconnect.php");

  if ($_REQUEST["submit"]=="Sign!")
  {
     $query="insert into guestbook(name,location,email,url,comments) values ('"
            .$_REQUEST["name"]
            ."', '"
            .$_REQUEST["location"]
            ."', '"
            .$_REQUEST["email"]
            ."', '"
            .$_REQUEST["url"]
            ."', '"
            .$_REQUEST["comments"]
            ."') "
     ;
     mysql_query($query);
 ?>
 <h2>Thanks!!</h2>
 <h2><a href="view.php">View my GuestBook!!</a></h2>
 <?php
 }
 else
 {
    include("sign.php");
 }
 ?>
 </BODY>
</HTML>

view.php

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <?php include("dbconnect.php") ?>
 
  <h2>View my GuestBook!!</h2>
 
  <?php
 
  $result = mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row = mysql_fetch_array($result))
  {
     echo "Name:";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($result);
  ?>
 
  <h2><a href="sign.php">Sign my GuestBook</a></h2>
 
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>

 <BODY>
  <?php include("dbconnect.php") ?>
  
  <h2>View my GuestBook!!</h2>

  <?php

  $result = mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row = mysql_fetch_array($result))
  {
     echo "Name:";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($result);
  ?>

  <h2><a href="sign.php">Sign my GuestBook</a></h2>

 </BODY>
</HTML>

everything works just fine until when it gets to view.php... dunno what the problem is...

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: May 2007

Posts: 4,424

Reputation: Ezzaral has much to be proud of

Solved Threads: 507

Ezzaral

Offline

Industrious Poster

Re: what's wrong in this code?

Aug 21st, 2007

I would suspect this lack of a semi-colon might be causing your problem

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
  <?php include("dbconnect.php") ?>
  <?php include("dbconnect.php") ?>

though I'm not sure why you aren't getting an immediate script error from it.

Last edited by Ezzaral; Aug 21st, 2007 at 7:39 pm.

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

Aug 21st, 2007

according to what i know, it shouldn't affect... since it is a single command...

still... tried it, and no response... the same exact results...

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: May 2007

Posts: 4,424

Reputation: Ezzaral has much to be proud of

Solved Threads: 507

Ezzaral

Offline

Industrious Poster

Re: what's wrong in this code?

Aug 21st, 2007

•

Originally Posted by Nichito

according to what i know, it shouldn't affect... since it is a single command...

still... tried it, and no response... the same exact results...

Yes, I wondered about it and a couple quick tests here came up the same. The semi-colon did not matter. That was the only thing that stood out that might have caused it to switch parsing modes. I don't really see anything else yet that would be problematic.

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

Aug 21st, 2007

did you try it? i mean, the whole 'combo'?

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: May 2007

Posts: 4,424

Reputation: Ezzaral has much to be proud of

Solved Threads: 507

Ezzaral

Offline

Industrious Poster

Re: what's wrong in this code?

Aug 21st, 2007

•

Originally Posted by Nichito

did you try it? i mean, the whole 'combo'?

No, as that would entail creating db tables as well

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

#10

Aug 21st, 2007

true... hehe... i don't think there's a problem with my php setup, since two out of three pages were working just fine...

maybe it's just something unnoticeable... or the example is not well written... i'll try some more and see if it persists...

-->sometimes i wanna take my toaster in a bath<--