•
•
•
•
What is DaniWeb IT Discussion Community?
You're currently browsing the Perl section within the Software Development category of DaniWeb, a massive community of 456,520 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 2,814 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our Perl advertiser: Programming Forums
Views: 1707 | Replies: 8 | Solved
 |
•
•
Join Date: Jun 2007
Location: Albany, NY
Posts: 42
Reputation: 
Rep Power: 2
Solved Threads: 0
Light Poster
whats up everybody? havent been on daniweb in a while. self-motivation like whut....until now. anyways ive got this script that makes an html form with 19 or so fields. its supposed to put the form info into a file (mediaRequest_log.txt). it gets this information by way of
and then to put it into a variable and append it to a file
now i also use this
to format the form element values for a email string ($mail_string) and a display string to display the results when the submit button is clicked ($display_string). long story short, this script works fine except that it does not write anything to the file except for a blank line. why is this happeneing???? can i not use both methods together? if thats not so, how can i fix my script to make it write the form element values to the text file? your help is greatly appreciated.
perl Syntax (Toggle Plain Text)
and then to put it into a variable and append it to a file
perl Syntax (Toggle Plain Text)
now i also use this
perl Syntax (Toggle Plain Text)
to format the form element values for a email string ($mail_string) and a display string to display the results when the submit button is clicked ($display_string). long story short, this script works fine except that it does not write anything to the file except for a blank line. why is this happeneing???? can i not use both methods together? if thats not so, how can i fix my script to make it write the form element values to the text file? your help is greatly appreciated.
Henry Phillips
Web Programmer
Adirondack Area Network, LLC
Web Programmer
Adirondack Area Network, LLC
•
•
Join Date: Jun 2007
Location: Albany, NY
Posts: 42
Reputation:
Rep Power: 2
Solved Threads: 0
Light Poster
perl Syntax (Toggle Plain Text)
Henry Phillips
Web Programmer
Adirondack Area Network, LLC
Web Programmer
Adirondack Area Network, LLC
•
•
Join Date: Mar 2006
Posts: 642
Reputation:
Rep Power: 4
Solved Threads: 36
Practically a Master Poster
why are you mixing that terrible form parsing code in with CGI anyway? Use the CGI module to get all the form data, don't mix it with that insecure code you are using. Also, when the script reads the data from STDIN:
read(STDIN, $text, $ENV{'CONTENT_LENGTH'});
it empties the buffer, so any subsequent attemptsto read the same data will fail. That may explain your situation, but i did not take a close look at your code.
read(STDIN, $text, $ENV{'CONTENT_LENGTH'});
it empties the buffer, so any subsequent attemptsto read the same data will fail. That may explain your situation, but i did not take a close look at your code.
•
•
Join Date: Jun 2007
Location: Albany, NY
Posts: 42
Reputation:
Rep Power: 2
Solved Threads: 0
Light Poster
i am fairly new to perl. can you explain what you mean by this?
"why are you mixing that terrible form parsing code in with CGI anyway? Use the CGI module to get all the form data, don't mix it with that insecure code you are using."
"why are you mixing that terrible form parsing code in with CGI anyway? Use the CGI module to get all the form data, don't mix it with that insecure code you are using."
Henry Phillips
Web Programmer
Adirondack Area Network, LLC
Web Programmer
Adirondack Area Network, LLC
•
•
Join Date: Mar 2006
Posts: 642
Reputation:
Rep Power: 4
Solved Threads: 36
Practically a Master Poster
This is the terrible code I refer to:
You have loaded the CGI module and created a CGI object ($query)
That is what you shoud use to get all the form data, like you do in some parts of the code:
if ( $ENV{'CONTENT_LENGTH'} > 0 )
{
# ~~~~~~~~~~~~~~~~~~~~~~ GETTING FORM INFO FOR $file_string ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# get form info from POST method
read(STDIN, $text, $ENV{'CONTENT_LENGTH'});
my @value_pairs = split (/&/,$text);
my %form_results = ();
foreach $pair (@value_pairs) {
($key, $value) = split (/=/,$pair);
$value =~ tr/+/ /;
$value =~ s/%([\dA-Fa-f][\dA-Fa-f])/pack ("C", hex ($1))/eg;
$form_results{$key} = $value; # store the key in the results hash
}You have loaded the CGI module and created a CGI object ($query)
use CGI; $query = new CGI;
That is what you shoud use to get all the form data, like you do in some parts of the code:
$query->param('bill_to') •
•
Join Date: Jun 2007
Location: Albany, NY
Posts: 42
Reputation:
Rep Power: 2
Solved Threads: 0
Light Poster
•
•
•
•
Originally Posted by KevinADC 
This is the terrible code I refer to:
if ( $ENV{'CONTENT_LENGTH'} > 0 ) { # ~~~~~~~~~~~~~~~~~~~~~~ GETTING FORM INFO FOR $file_string ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # get form info from POST method read(STDIN, $text, $ENV{'CONTENT_LENGTH'}); my @value_pairs = split (/&/,$text); my %form_results = (); foreach $pair (@value_pairs) { ($key, $value) = split (/=/,$pair); $value =~ tr/+/ /; $value =~ s/%([\dA-Fa-f][\dA-Fa-f])/pack ("C", hex ($1))/eg; $form_results{$key} = $value; # store the key in the results hash }
You have loaded the CGI module and created a CGI object ($query)
use CGI; $query = new CGI;
That is what you shoud use to get all the form data, like you do in some parts of the code:
$query->param('bill_to')
well i was using that because it was a fast and easy way to get all the form elements into a string delimited by a '|' character. u keep saying its terrible code.....but why is it terrible code? believe me i would like to do everything using $query->param('watever') but id rather not write out each element to just put it in a string.
btw i was able to do what i want to do without using
perl Syntax (Toggle Plain Text)
if you know of an easy way to get all the form element values into a string delimited by '|' then please share it!!!!
Henry Phillips
Web Programmer
Adirondack Area Network, LLC
Web Programmer
Adirondack Area Network, LLC
•
•
Join Date: Mar 2006
Posts: 642
Reputation:
Rep Power: 4
Solved Threads: 36
Practically a Master Poster
untested but should work
read the CI module documentation. I know it is long and some parts are a bit hard to follow, but the part about importing all the params as a list or hash or array is easy to understand.
use CGI;
my $query = CGI->new;
my %form_results = $query->Vars;
my $file_string = join ('|',map {$form_results{$_}} sort keys %form_results);
print $file_string;read the CI module documentation. I know it is long and some parts are a bit hard to follow, but the part about importing all the params as a list or hash or array is easy to understand.
•
•
Join Date: Jun 2007
Location: Albany, NY
Posts: 42
Reputation:
Rep Power: 2
Solved Threads: 0
Light Poster
thank you for your help that bit of code works great. i still would like to know what is so bad about the other code i was using.....you said it was insecure. what makes it insecure? i guess my question is why should i use the CGI module instead, besides the fact taht its easier.
Henry Phillips
Web Programmer
Adirondack Area Network, LLC
Web Programmer
Adirondack Area Network, LLC
•
•
Join Date: Mar 2006
Posts: 642
Reputation:
Rep Power: 4
Solved Threads: 36
Practically a Master Poster
Some reading if you are interested:
http://users.easystreet.com/ovid/cgi...esson_two.html
You should also be using Taint mode with all CGI scripts.
Ask on www.perlmonks.com why you should not use the form parsing code you posted above and you should get some more opinions. Mine is my own, the opinion of others may vary. Exposure to more opinions may at first be confusing but hopefully it will be educational.
http://users.easystreet.com/ovid/cgi...esson_two.html
You should also be using Taint mode with all CGI scripts.
Ask on www.perlmonks.com why you should not use the form parsing code you posted above and you should get some more opinions. Mine is my own, the opinion of others may vary. Exposure to more opinions may at first be confusing but hopefully it will be educational.
|
•
•
•
•
•
•
•
•
DaniWeb Perl Marketplace
•
•
•
•
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Linear Mode
Similar Threads
- Write to a file in C++ (C++)
- Read/write to same file > once, Help (C++)
- write in file and screen? (C++)
- Write to a file (C)
- line up JTextField GUI java & write to file (Java)
Other Threads in the Perl Forum
- Previous Thread: HELP: AoH to HoH pulling its no value
- Next Thread: can anyone help me to debug this script
