DaniWeb Forum Index > Software Development > C++

File not closing

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Sep 2006

Posts: 22

Reputation: disc is an unknown quantity at this point

Solved Threads: 1

disc

Offline

Newbie Poster

File not closing

Oct 26th, 2007

Hi all,
This is my problem:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void StartRun( void )
{
    std::auto_ptr<Validate> val ( new Validate( "input.txt" ) );
    val->DoIt( );
}
// Destructor
Validate::~WValidate( )
{
  if( mFileIn.is_open())
  {
    mFileIn.close();
  }
  if( mFileOut.is_open() )
  {
    mFileOut.flush();
    mFileOut.close();
  }
}
void StartRun( void )
{
    std::auto_ptr<Validate> val ( new Validate( "input.txt" ) );
    val->DoIt( );
}
// Destructor
Validate::~WValidate( )
{
  if( mFileIn.is_open())
  {
    mFileIn.close();
  }
  if( mFileOut.is_open() )
  {
    mFileOut.flush();
    mFileOut.close();
  }
}

The function DoIt() makes use of a DLL. Now heres the problem:
When there is an exception thrown by the DLL, I should say the
mFileOut should always be closed but it doesn't. I can't delete
the outputfile until I close my application because it says the
file is still open.
It only closes in the 'Debug Build' but not in the 'Release Build'.
Anyone has an idea ??
I use the Borland Developer Studio 2006.

•

Join Date: May 2006

Posts: 1,857

Reputation: ithelp is a name known to all

Solved Threads: 120

ithelp

Offline

Posting Virtuoso

Re: File not closing

Oct 26th, 2007

Can you not catch all exceptions from DoIt ?

•

Join Date: Aug 2005

Posts: 15,585

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1487

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: File not closing

Oct 26th, 2007

My guess is that your program is crashing sooooo bad that the destructor is not getting called, the program is just dumping back to the os without doing any cleanup. You really need to find out what is causing the exception and fix it. Lacking that you should implement exceptions (try/catch blocks) as ithelp suggested.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Sep 2006

Posts: 22

Reputation: disc is an unknown quantity at this point

Solved Threads: 1

disc

Offline

Newbie Poster

Re: File not closing

Oct 26th, 2007

•

Originally Posted by Ancient Dragon

My guess is that your program is crashing sooooo bad that the destructor is not getting called, the program is just dumping back to the os without doing any cleanup. You really need to find out what is causing the exception and fix it. Lacking that you should implement exceptions (try/catch blocks) as ithelp suggested.

The try/catch block is already implemented in the DoIt function but that's not the solution because the exception is caused by a third party DLL.
It's still a fact that in the 'Debug Build' the destructor is called, and the file can be deleted, but in the 'Release Build' it isn't.
So suggestions are still welcome....