User Name Password Register
DaniWeb IT Discussion Community
All
What is DaniWeb IT Discussion Community?
You're currently browsing the C section within the Software Development category of DaniWeb, a massive community of 455,964 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 3,607 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our C advertiser: Programming Forums
Views: 2182 | Replies: 5
Reply
Join Date: Nov 2007
Posts: 2
Reputation: matt nagel is an unknown quantity at this point 
Rep Power: 0
Solved Threads: 0
matt nagel matt nagel is offline Offline
Newbie Poster

Parsing a csv file in C

  #1  
Nov 21st, 2007
Hi there, I am fairly new to programming and trying create a program to parse csv data into an array. I have been following an example I found on this site but I am running into a segmentation fault (even if I copy code directly). I am fairly sure the problem lies in the while loop, I just cant see it.


****Sample Csv Data****
1.0235, 2.1112, 1.9972
3.0139, 1.1876, 2.91785
1.9295, 2.1322, 2.4821

I realize its probably overkill for my purpose so if anyone could point me to a simpler solution that would be appreciated too.

  1. #include <stdio.h>
  2. #include <stdlib.h>
  3. #include <string.h>
  4. #define MAXFLDS 200 /* maximum possible number of fields */
  5. #define MAXFLDSIZE 32 /* longest possible field + 1 = 31 byte field */
  6.  
  7. void parse( char *record, char *delim, char arr[][MAXFLDSIZE],int *fldcnt)
  8. {
  9. char*p=strtok(record,delim);
  10. int fld=0;
  11.  
  12. while(*p)
  13. {
  14. strcpy(arr[fld],p);
  15. fld++;
  16. p=strtok('\0',delim);
  17. }
  18. *fldcnt=fld;
  19. }
  20.  
  21. int main(int argc, char *argv[])
  22. {
  23. char tmp[1024]={0x0};
  24. int fldcnt=0;
  25. char arr[MAXFLDS][MAXFLDSIZE]={0x0};
  26. int recordcnt=0;
  27. FILE *in=fopen(argv[1],"r"); /* open file on command line */
  28.  
  29. if(in==NULL)
  30. {
  31. perror("File open error");
  32. exit(EXIT_FAILURE);
  33. }
  34. while(fgets(tmp,sizeof(tmp),in)!=0) /* read a record */
  35. {
  36. int i=0;
  37. recordcnt++;
  38. printf("Record number: %d\n",recordcnt);
  39. parse(tmp,",",arr,&fldcnt); /* whack record into fields */
  40. for(i=0;i<fldcnt;i++)
  41. { /* print each field */
  42. printf("\tField number: %3d==%s\n",i,arr[i]);
  43. }
  44. }
  45. fclose(in);
  46. return 0;
  47. }
Last edited by Ancient Dragon : Nov 21st, 2007 at 5:31 pm. Reason: add line numbers
AddThis Social Bookmark Button
Reply With Quote  
Join Date: Aug 2005
Location: near St Louis, Missouri, USA
Posts: 11,539
Reputation: Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of Ancient Dragon has much to be proud of 
Rep Power: 40
Solved Threads: 972
Moderator
Featured Poster
Ancient Dragon's Avatar
Ancient Dragon Ancient Dragon is online now Online
Most Valuable Poster

Re: Parsing a csv file in C

  #2  
Nov 21st, 2007
line 12: should be this: while(p) Your program gets segment violation when strtok() returns NULL.

>>I realize its probably overkill for my purpose so if anyone could point me to a simpler solution that would be appreciated too.
In C language that's about the best anyone can do.
Last edited by Ancient Dragon : Nov 21st, 2007 at 5:34 pm.
<<Freelance Programmer>> << Hobby Site>>
Signature links for sale. PM me for details
Reply With Quote  
Join Date: Oct 2007
Posts: 302
Reputation: stilllearning has a spectacular aura about stilllearning has a spectacular aura about 
Rep Power: 3
Solved Threads: 37
stilllearning stilllearning is offline Offline
Posting Whiz

Re: Parsing a csv file in C

  #3  
Nov 22nd, 2007
I am not sure if this is needed or not, but most CSV files have a header record, which is essentially the names of the columns separated by commas. If you are parsing an actual CSV file, you will need to take that into account also.
Reply With Quote  
Join Date: Oct 2007
Location: Cherry Hill, NJ
Posts: 1,878
Reputation: Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold 
Rep Power: 13
Solved Threads: 193
Featured Poster
Duoas's Avatar
Duoas Duoas is offline Offline
Posting Virtuoso

Re: Parsing a csv file in C

  #4  
Nov 22nd, 2007
> I am not sure if this is needed or not, but most CSV files have a header record, which is essentially the names of the columns separated by commas. If you are parsing an actual CSV file, you will need to take that into account also.

That may be true for some, but the vast majority of CSV files in use have no such thing. Unlike something like an XML file, CSV files have no way to tell you what they contain. The reading program must know what to expect when reading any CSV. Even the assumption that CSV is textual data, or fields separated by commas or tabs, and other stuff, is entirely that, assumption.

If you like I'll dig up an old CSV parser I wrote that can handle anything and port it to C for you. (Remember, it can read and write any CSV file, but, again, you must know what that CSV file contains for it to be useful!)
Reply With Quote  
Join Date: Nov 2007
Posts: 2
Reputation: matt nagel is an unknown quantity at this point 
Rep Power: 0
Solved Threads: 0
matt nagel matt nagel is offline Offline
Newbie Poster

Re: Parsing a csv file in C

  #5  
Nov 22nd, 2007
Ahhh thanks for that, a silly mistake.

Duoas if you have it lying around Id love to take a look

Thanks in advance.
Reply With Quote  
Join Date: Oct 2007
Location: Cherry Hill, NJ
Posts: 1,878
Reputation: Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold Duoas is a splendid one to behold 
Rep Power: 13
Solved Threads: 193
Featured Poster
Duoas's Avatar
Duoas Duoas is offline Offline
Posting Virtuoso

Re: Parsing a csv file in C

  #6  
Nov 28th, 2007
Hey there, if you're still interested, don't give up.

I wrote it originally in Object Pascal, and I used a number of very powerful container classes that don't exist in C (...obviously). So I've been coding a replacement for them also... (It's kind of boring actually...)

I should be done pretty soon. Once I give it some basic testing I'll wrap the whole thing up for you and respond here again.
Reply With Quote  
Reply

Only community members can participate in forum threads. You must register or log in to contribute.

DaniWeb C Marketplace
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

 

Thread Tools Display Modes

Similar Threads
Other Threads in the C Forum

All times are GMT -4. The time now is 9:02 am.
Forum system based on vBulletin Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
©2003 - 2008 DaniWeb® LLC