DaniWeb Forum Index > Software Development > C++

C++ RSS

Sorting words alphabetically goes wrong.

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Dec 2007

Posts: 3

Reputation: iCare is an unknown quantity at this point

Solved Threads: 0

iCare

Offline

Newbie Poster

Sorting words alphabetically goes wrong.

Dec 2nd, 2007

I'm using Borland C++ and i need to make program where you enter a string in which the words are seprated by space. After input i need to sort these words into alphabetical order, but something is wrong. Cause when i enter like " x b a" it prints out "a b" but when i enter "abc abb aba" it sorts it ok. Where is the problem? I would be really thankful if anybody could help me. Thank you.

Code:

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
#include <stdio.h>
#include <string.h>
#include <conio.h>
#include <iostream.h>
#include <stdlib.h>
 
void main ()
{
clrscr();
  char rinda[200];
  printf("Enter string [ words are separated with space ]\n");
  gets(rinda);
  char * pch;
  char * pch2[100];
  char * temp[100];
  int words,j;
  j=0;
  words=0;
  pch = strtok (rinda," ");
  while (pch != NULL)
  {
    pch2[j]=pch;
    words=words+1;
    j=j+1;
    pch = strtok (NULL, " ,.-");
  }
cout << "Before sorting:" <<endl;
for (int x=0;x<words;x++) 
cout << pch2[x]<<endl;  
 
for (int i=1; i<=words; i++) {
  for ( int z=0;z<=i;z++ ) {
    if (strcmp(pch2[z],pch2[z+1]) > 0) {
    temp[z]=pch2[z];
    pch2[z]=pch2[z+1];
    pch2[z+1]=temp[z];
 }
  }
}
cout << "After sorting:" <<endl;
for (int g=0;g<words;g++) 
cout << pch2[g]<<endl;  
 
  getche();
}
#include <stdio.h>
#include <string.h>
#include <conio.h>
#include <iostream.h>
#include <stdlib.h>

void main ()
{
clrscr();
  char rinda[200];
  printf("Enter string [ words are separated with space ]\n");
  gets(rinda);
  char * pch;
  char * pch2[100];
  char * temp[100];
  int words,j;
  j=0;
  words=0;
  pch = strtok (rinda," ");
  while (pch != NULL)
  {
    pch2[j]=pch;
    words=words+1;
    j=j+1;
    pch = strtok (NULL, " ,.-");
  }
cout << "Before sorting:" <<endl;
for (int x=0;x<words;x++) 
cout << pch2[x]<<endl;  

for (int i=1; i<=words; i++) {
  for ( int z=0;z<=i;z++ ) {
    if (strcmp(pch2[z],pch2[z+1]) > 0) {
    temp[z]=pch2[z];
    pch2[z]=pch2[z+1];
    pch2[z+1]=temp[z];
 }
  }
}
cout << "After sorting:" <<endl;
for (int g=0;g<words;g++) 
cout << pch2[g]<<endl;  
  
  getche();
}

Last edited by Ancient Dragon; Dec 2nd, 2007 at 9:36 am. Reason: add line numbers to code tags, you did not violate any DaniWeb rules, this is just for convenience

•

Join Date: Aug 2005

Posts: 5,266

Reputation: iamthwee is a splendid one to behold

Solved Threads: 377

iamthwee

Offline

Posting Expert

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

Maybe

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
for (int i=1; i<=words; i++) {
  for ( int z=0;z<=i;z++ ) {
for (int i=1; i<=words; i++) {
  for ( int z=0;z<=i;z++ ) {

should be:-

Help with Code Tags

(Toggle Plain Text)

for (int i=0; i<words; i++) {
  for ( int z=0;z<i;z++ ) {

*Voted best profile in the world*

•

Join Date: Dec 2007

Posts: 3

Reputation: iCare is an unknown quantity at this point

Solved Threads: 0

iCare

Offline

Newbie Poster

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

It doesn't work, inputting "x b a" it prints " b a x"

•

Join Date: Aug 2005

Posts: 5,266

Reputation: iamthwee is a splendid one to behold

Solved Threads: 377

iamthwee

Offline

Posting Expert

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

I'm guessing there is something wrong with your sorting or you need to use strcpy to swap your variables. Using gets() and all the other misnomers probably doesn't help matters.

Last edited by iamthwee; Dec 2nd, 2007 at 8:12 am.

*Voted best profile in the world*

•

Join Date: Aug 2005

Posts: 15,508

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1480

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

line 12: never ever use gets() because it can destroy your program. Use fgets() instead.

line 15: you don't need an array of temp pointers. Just one temp pointer will do.

I've always coded the bubble sort like this: Note that the inner loop begins one slot beyond the current position of the outer loop. There is no point in checking positions 0 to i because they have already been sorted.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
char* temp;
for (int i=0; i< words-1; i++) {
  for ( int z= i+1 ;z <  words; z++ ) {
    if (strcmp(pch2[ i ],pch2[ z ]) > 0) {
           temp = pch2[i];
           pch2[i]=pch2[z];
           pch2[z]=temp;
     }
  }
}
char* temp;
for (int i=0; i< words-1; i++) {
  for ( int z= i+1 ;z <  words; z++ ) {
    if (strcmp(pch2[ i ],pch2[ z ]) > 0) {
           temp = pch2[i];
           pch2[i]=pch2[z];
           pch2[z]=temp;
     }
  }
}

Last edited by Ancient Dragon; Dec 2nd, 2007 at 9:46 am.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Dec 2007

Posts: 3

Reputation: iCare is an unknown quantity at this point

Solved Threads: 0

iCare

Offline

Newbie Poster

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

Ooo, looks like everything is ok now. Thank you Ancient Dragon.

•

Join Date: Nov 2007

Posts: 34

Reputation: tarekkkkk is an unknown quantity at this point

Solved Threads: 0

tarekkkkk

Offline

Light Poster

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

do u want another program than urs if yes plz give me about 20 min reply plz

•

Join Date: May 2006

Posts: 3,117

Reputation: WaltP has much to be proud of

Solved Threads: 282

WaltP

Offline

Posting Sensei

Re: Sorting words alphabetically goes wrong.

Dec 2nd, 2007

tarekkkkk, please use full English so we can all understand you. Don't use web-speak because a lot of people here don't understand it.

The 3 Laws of the Procrastination Society:
1) Never do today that which can be put off until tomorrow
2) Tomorrow never comes

•

Join Date: Nov 2007

Posts: 34

Reputation: tarekkkkk is an unknown quantity at this point

Solved Threads: 0

tarekkkkk

Offline

Light Poster

Ok try next time messaging me first!!!!

Dec 3rd, 2007

Ok its not a big deal for me to speak pure english or british but why did u make a warning stuff about my language well u can just send me a private message about ur problem with me and sorry i dont know u try next time introducing urself to me c ya until next time!

Last edited by tarekkkkk; Dec 3rd, 2007 at 11:32 am.

•

Join Date: Sep 2004

Posts: 7,787

Reputation: Narue has a reputation beyond repute

Solved Threads: 745

Narue

Offline

Code Goddess

Re: Sorting words alphabetically goes wrong.

#10

Dec 3rd, 2007

>but why did u make a warning stuff about my language
Because that's what our policies dictate (see the emphasized areas for your specific case):

•

Keep It Clean
We strive to be a community geared towards the professional. We strongly encourage all posts to be in full-sentence English. Please do not use "leet" speak or "chatroom" speak.

Our privacy policy requires members to be at least 13 years of age, but demographic surveys have shown the average age of our members to be over 30. Mature language and concepts are therefore acceptable on DaniWeb to the point that would be acceptable on daytime family television, but offensive postings are not. To ensure that standards are maintained we have implemented a filter that will edit out inappropriate language in your postings. However, common sense should prevail and if you are unsure if a word is acceptable or not, please don’t post it. It is prohibited to use alternative characters in an attempt to circumvent the bad words filter.

What will happen: Offensive material will be snipped out of offending post or censored by bad words filter.
First offense: Member will be warned via user infraction system. Warning will be documented.
Second offense: 5 point infraction will remain on user's record for 3 months.

I'm here to prove you wrong.