Ad:

C Discussion Thread
Unsolved
Views: 620

Dec 1st, 2008

need urgent responce please!

Expand Post »

i am designing a code that will calculate tomorrows date but there is some problem with the code,
when i enter
year = 2008 or anyother
month =12
day = 31
it gives tmorrows date as 1/2/2008
please help and tell me if i can do more improvements thanks

C Syntax (Toggle Plain Text)
#include<conio.h>
#include<stdio.h>
main(void)
{
 int t;
 int y,d=1,i,m=1;
 printf("Enter the Year: ");
 scanf("%4u",&y);
 if(y<0)
 y=-y;
 printf("Enter the Month: ");
 scanf("%2u",&m);
 if(m<=0 || m>=12)
 m=1;
 i=y%4;
 printf("Enter the Day: ");
 scanf("%2u",&d);
 if (d>=1&&d<28)
 d=d+1;
 else if(d==i&&m==2)
 {d=1;
 m=3;}
 else if (d==30&&m==4||m==6||m==9||m==11)
 {d=1;
 m=m+1;}
 else if (d==31&&m==1||m==2||m==3||m==5||m==7||m==8||m==10)
{
 d=1;
 m=m+1;
 }
 else if(d==31&&m==12)
 { 
 d=1;
 m=1;
 y=y+1;
 }
 printf("Tomorrow's Date is\n  %d/%d/%d ",d,m,y);
 getch();
}
#include<conio.h>
#include<stdio.h>
main(void)
{
 int t;
 int y,d=1,i,m=1;
 printf("Enter the Year: ");
 scanf("%4u",&y);
 if(y<0)
 y=-y;
 printf("Enter the Month: ");
 scanf("%2u",&m);
 if(m<=0 || m>=12)
 m=1;
 i=y%4;
 printf("Enter the Day: ");
 scanf("%2u",&d);
 if (d>=1&&d<28)
 d=d+1;
 else if(d==i&&m==2)
 {d=1;
 m=3;}
 else if (d==30&&m==4||m==6||m==9||m==11)
 {d=1;
 m=m+1;}
 else if (d==31&&m==1||m==2||m==3||m==5||m==7||m==8||m==10)
{
 d=1;
 m=m+1;
 }
 else if(d==31&&m==12)
 { 
 d=1;
 m=1;
 y=y+1;
 }
 printf("Tomorrow's Date is\n  %d/%d/%d ",d,m,y);
 getch();
}

Similar Threads

Urgent help needed > uploading video files in PHP

raja289

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

54 posts
since Jul 2008

Permalink

Dec 1st, 2008

Re: need urgent responce please!

You are kicking off December!

Check if(m<=0 || m>=12) .
It should be if(m<=0 || m>12) .

Also check your leap years handling.

mrboolf

Reputation Points: 134

Solved Threads: 18

Junior Poster

Offline

182 posts
since Jun 2008

Permalink

Dec 1st, 2008

Re: need urgent responce please!

Before you do the above, migrate to the C forum

Chris

Freaky_Chris

Reputation Points: 325

Solved Threads: 118

Master Poster

Offline

702 posts
since Apr 2008

Permalink

Dec 1st, 2008

Re: need urgent responce please!

Can you use the functions in time.h? If you can, then just fill in a struct tm and call mktime() to calculate tomarrow

C Syntax (Toggle Plain Text)
#include <time.h>
...
int main()
{
    int m = 11; // November
    int y = 2008;
    int d = 2;
 
   struct tm tm;
   // clear all members of the structure
   memset(&tm,0,sizeof(struct tm));
 
   tm.tm_year = y-1900;
   tm.tm_mon = m-1;
   tm.tm_day = d;
   // increment tomarrow
   tm.tm_mday++;
   mktime(&tm);
#include <time.h>
...
int main()
{
    int m = 11; // November
    int y = 2008;
    int d = 2;

   struct tm tm;
   // clear all members of the structure
   memset(&tm,0,sizeof(struct tm));

   tm.tm_year = y-1900;
   tm.tm_mon = m-1;
   tm.tm_day = d;
   // increment tomarrow
   tm.tm_mday++;
   mktime(&tm);

Last edited by Ancient Dragon; Dec 1st, 2008 at 7:55 pm.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,947 posts
since Aug 2005

Permalink

Dec 2nd, 2008

Re: need urgent responce please!

http://www.catb.org/~esr/faqs/smart-...ns.html#urgent
Not to mention, the unindented code which is simply awful to look at.

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Dec 2nd, 2008

Re: need urgent responce please!

Click to Expand / Collapse Quote originally posted by Salem ...

Not to mention, the unindented code which is simply awful to look at.

Second that. Also, flow of the code is confusing which is really awful considering the simplicity of the problem.

main returns an integer. So it's int main() not just main(void) .

This test condition is wrong:

C Syntax (Toggle Plain Text)
else if(d==i&&m==2)
else if(d==i&&m==2)

You aren't checking for leap years, although at one point you do find i=y%4; . Comparing this value with the number of days screws up the whole thing.

devnar

Reputation Points: 124

Solved Threads: 18

Junior Poster

Offline

148 posts
since Sep 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: UNIX Client and Server

Next Thread in C Forum Timeline: Trouble with pointers

DaniWeb Message

Cancel Changes

User Name
Password