Ad:

C Discussion Thread
Marked Solved
Views: 832

Dec 4th, 2008

Matrix Multiplication (sorry)

Expand Post »

I know there are multiple threads on Matrix Multiplication but all of them are either different from what i need, or are unanswered. I am trying to multiply two N x N matrices. The two matrices and N are all found in a file via argv[1].

I have spent hours and hours trying to get my code to compile and it finally does. then i ran the program and much to my dissapointment it just output hundreds and hundreds of numbers.

heres my code:

C Syntax (Toggle Plain Text)
#include <stdio.h>
 
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n = fgetc(fin), x[n][n], y[n][n], z[n][n];
 
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++){
      x[i][j] = fgetc(fin);
      printf("%d", x[i][j]);
    }
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) y[i][j] = fgetc(fin);
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) z[i][j] = 0;
 
  MatrixMult( x, y, z, &n );
 
  for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", z[i][j]);
    printf("\n");
  }
  return(0);
}
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;
  for(i = 0; i < *n; i++)
    for(j = 0; j < *n; j++)
      for(k = 0; k < *n; k++)
        z[i][j] += x[i][k] * y[k][j];
 
  return;
}
#include <stdio.h>

void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n = fgetc(fin), x[n][n], y[n][n], z[n][n];

  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++){
      x[i][j] = fgetc(fin);
      printf("%d", x[i][j]);
    }
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) y[i][j] = fgetc(fin);
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) z[i][j] = 0;

  MatrixMult( x, y, z, &n );

  for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", z[i][j]);
    printf("\n");
  }
  return(0);
}
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;
  for(i = 0; i < *n; i++)
    for(j = 0; j < *n; j++)
      for(k = 0; k < *n; k++)
        z[i][j] += x[i][k] * y[k][j];

  return;
}

Similar Threads

matrix multiplication help.. in C
Transpose & Inverse Matrix, Matrix Determinant in C++
Gabor filter in C++
C++ Matrix Multiplication in C++
need help in C

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Dec 4th, 2008

Re: Matrix Multiplication (sorry)

Better use fscanf() to read integers. If you use fgetc(), you'll be reading the ascii values of the integers and not their actual values. Also every digit will be treated as a character. How will you read multiple-digit numbers then?

Also you've used n = fgetc(fin) . Is that what you want? Does the first digit in your file denote the order of the matrix?

You can't treat this as a declaration:

C Syntax (Toggle Plain Text)
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);

And get away with this: (As far as i know)

C Syntax (Toggle Plain Text)
int  x[n][n], y[n][n], z[n][n];
int  x[n][n], y[n][n], z[n][n];

Last edited by devnar; Dec 4th, 2008 at 2:21 pm.

devnar

Reputation Points: 124

Solved Threads: 18

Junior Poster

Offline

148 posts
since Sep 2008

Permalink

Dec 4th, 2008

Re: Matrix Multiplication (sorry)

this is rushed code i have to go take a psych test, thanks for the help so far, how do i return the value of z from the matrixmult function? or how do u think i should do that? thanks for all the help devnar.

C Syntax (Toggle Plain Text)
#include <stdio.h>
 
int MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n, a[n][n], b[n][n], c[n][n];
 
  fscanf( fin, "%d", &n );
 
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++){
      fscanf( fin, "%d", &a[i][j] );
      printf("%d", a[i][j]);
    }
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) fscanf(fin, "%d", &b[i][j] );
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) c[i][j] = 0;
 
  for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", MatrixMult( a, b, c, &n ));
    printf("\n");
  }
  return(0);
}
 
int MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;
  for(i = 0; i < *n; i++)
    for(j = 0; j < *n; j++)
      for(k = 0; k < *n; k++)
        z[i][j] += x[i][k] * y[k][j];
 
  return( z );
}
#include <stdio.h>

int MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n, a[n][n], b[n][n], c[n][n];

  fscanf( fin, "%d", &n );

  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++){
      fscanf( fin, "%d", &a[i][j] );
      printf("%d", a[i][j]);
    }
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) fscanf(fin, "%d", &b[i][j] );
  for(i = 0; i < n; i++)
    for(j = 0; j < n; j++) c[i][j] = 0;

  for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", MatrixMult( a, b, c, &n ));
    printf("\n");
  }
  return(0);
}

int MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;
  for(i = 0; i < *n; i++)
    for(j = 0; j < *n; j++)
      for(k = 0; k < *n; k++)
        z[i][j] += x[i][k] * y[k][j];

  return( z );
}

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Dec 4th, 2008

Re: Matrix Multiplication (sorry)

This is wrong:

C Syntax (Toggle Plain Text)
for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", MatrixMult( a, b, c, &n ));
    printf("\n");
  }
for(i = 0; i < n; i++){
    for(j = 0; j < n; j++) printf(" %d", MatrixMult( a, b, c, &n ));
    printf("\n");
  }

You can't return arrays since they are always passed by reference. Your previous code for displaying the array was correct.

And I think this is still wrong:

C Syntax (Toggle Plain Text)
int a[n][n], b[n][n], c[n][n];
int a[n][n], b[n][n], c[n][n];

It should be:

c Syntax (Toggle Plain Text)
int i, j, n, a[10][50], b[10][50], c[10][50]; //or something similar
int i, j, n, a[10][50], b[10][50], c[10][50]; //or something similar

devnar

Reputation Points: 124

Solved Threads: 18

Junior Poster

Offline

148 posts
since Sep 2008

Permalink

Dec 4th, 2008

Re: Matrix Multiplication (sorry)

thanks a lot i got it to work, i deleted some unnecessary stuff rearranged some lines to make more sense.

heres the final version

C Syntax (Toggle Plain Text)
#include <stdio.h>
 
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n, a[50][50], b[50][50], c[50][50];
 
  fscanf( fin, "%d", &n );
 
  printf("\n\nFirst Matrix:\n");
 
  for(i = 0; i < n; i++){
 
    for(j = 0; j < n; j++){
 
      fscanf( fin, "%d", &a[i][j] );
      printf( " %d", a[i][j] );
    }
 
    printf("\n");
  }
 
  printf("\n\nSecond Matrix:\n");
for(i = 0; i < n; i++){
 
    for(j = 0; j < n; j++){
 
      fscanf( fin, "%d", &b[i][j] );
      printf( " %d", b[i][j] );
 
      c[i][j] = 0;
    }
 
    printf("\n");
  }
 
  MatrixMult( a, b, c, &n );
 
  printf("\n\nProduct of the two Matrices:\n");
 
for(i = 0; i < n; i++){
 
    for(j = 0; j < n; j++) printf( " %d", c[i][j] );
    printf("\n");
 
  }
  return(0);
}
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;
 
  for(i = 0; i < *n; i++)
 
    for(j = 0; j < *n; j++)
 
      for(k = 0; k < *n; k++)
 
        z[i][j] += x[i][k] * y[k][j];
}
#include <stdio.h>

void MatrixMult(int x[][50], int y[][50], int z[][50], int *n);
int main(int argc, char *argv[]){
  FILE *fin = fopen(argv[1], "r");
  int i, j, n, a[50][50], b[50][50], c[50][50];

  fscanf( fin, "%d", &n );

  printf("\n\nFirst Matrix:\n");

  for(i = 0; i < n; i++){

    for(j = 0; j < n; j++){

      fscanf( fin, "%d", &a[i][j] );
      printf( " %d", a[i][j] );
    }

    printf("\n");
  }

  printf("\n\nSecond Matrix:\n");
for(i = 0; i < n; i++){

    for(j = 0; j < n; j++){

      fscanf( fin, "%d", &b[i][j] );
      printf( " %d", b[i][j] );

      c[i][j] = 0;
    }

    printf("\n");
  }

  MatrixMult( a, b, c, &n );

  printf("\n\nProduct of the two Matrices:\n");

for(i = 0; i < n; i++){

    for(j = 0; j < n; j++) printf( " %d", c[i][j] );
    printf("\n");

  }
  return(0);
}
void MatrixMult(int x[][50], int y[][50], int z[][50], int *n ){
  int i, j, k;

  for(i = 0; i < *n; i++)

    for(j = 0; j < *n; j++)

      for(k = 0; k < *n; k++)

        z[i][j] += x[i][k] * y[k][j];
}

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Help with C and MySql

Next Thread in C Forum Timeline: Isn't it wrong? char **argv

DaniWeb Message

Cancel Changes

User Name
Password