Ad:

C Discussion Thread
Marked Solved
Views: 1067

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Mar 30th, 2009

minmax

Expand Post »

ok so im creating a program minmax to find the minimum and maximum numbers of an array. heres my code but i get segmentation fault where do you think im going wrong?

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include <stdlib.h>
 
void minmax( int numberlist[], int n, int *p_min, int *p_max );
 
int main( int argc, char *argv[] ){
 
  int *numberlist, i, n, *min, *max ;
 
  n = atoi( argv[1] );
 
  numberlist = ( int * ) malloc( n * sizeof( int ) );
 
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, min, max );
 
  printf( "The minimum value in your array is: %d", *min );
  printf( "The maximum value in your array is: %d", *max );
 return 0;
}
 
void minmax( int numberlist[], int n, int *p_min, int *p_max ){
 
  int min2, max2, i;
 
  if( n == 1 ) *p_min = *p_max = numberlist[0];
 
  else if( n == 2 ) {
 
    if( numberlist[0] < numberlist[i] ) {
      *p_min = numberlist[0];
      *p_max = numberlist[1];
 
    } else {
      *p_min = numberlist[1];
      *p_max = numberlist[0];
    }
 
  } else {
minmax( numberlist, n / 2, p_min, p_max );
    minmax( numberlist + n / 2, n - ( n / 2 ), &min2, &max2 );
 
    if( min2 < *p_min )
      *p_min = min2;
 
    if( max2 > *p_max )
      *p_max = max2;
  }
}
#include <stdio.h>
#include <stdlib.h>

void minmax( int numberlist[], int n, int *p_min, int *p_max );

int main( int argc, char *argv[] ){

  int *numberlist, i, n, *min, *max ;

  n = atoi( argv[1] );

  numberlist = ( int * ) malloc( n * sizeof( int ) );

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, min, max );

  printf( "The minimum value in your array is: %d", *min );
  printf( "The maximum value in your array is: %d", *max );
 return 0;
}

void minmax( int numberlist[], int n, int *p_min, int *p_max ){

  int min2, max2, i;

  if( n == 1 ) *p_min = *p_max = numberlist[0];

  else if( n == 2 ) {

    if( numberlist[0] < numberlist[i] ) {
      *p_min = numberlist[0];
      *p_max = numberlist[1];

    } else {
      *p_min = numberlist[1];
      *p_max = numberlist[0];
    }

  } else {
minmax( numberlist, n / 2, p_min, p_max );
    minmax( numberlist + n / 2, n - ( n / 2 ), &min2, &max2 );

    if( min2 < *p_min )
      *p_min = min2;

    if( max2 > *p_max )
      *p_max = max2;
  }
}

Last edited by Dewey1040; Mar 30th, 2009 at 11:03 am.

Similar Threads

How do i load a image on the same page ? in Site Layout and Usability
pebble chess in c++ in C++
CSV file in C
Build Failed Issues.. in Java
Overfloat? IE6/win? in HTML and CSS

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Mar 30th, 2009

Re: minmax

This is where you went wrong.

In your program pointers min and max are there but are not pointing to any memory space at all.So when you try to access some memory as *min or *max they try to refer a memory not been allocated hence segmentation fault core dumped.

Try this:

c Syntax (Toggle Plain Text)
int main( int argc, char *argv[] ){
 
int *numberlist, i, n, *min, *max ,minimum,maximum;
 
min=&minimum;
max=&maximum;
//Followed by your code
int main( int argc, char *argv[] ){

int *numberlist, i, n, *min, *max ,minimum,maximum;

min=&minimum;
max=&maximum;
//Followed by your code

By this you will have allocated the memory and then accessing it so no problem. And ya your max and min values will be in maximum and minimum.

Last edited by csurfer; Mar 30th, 2009 at 1:50 pm.

csurfer

Reputation Points: 485

Solved Threads: 88

Posting Pro

Offline

564 posts
since Jan 2009

Permalink

Mar 30th, 2009

Re: minmax

thanks csurfer, ill try that as soon as putty chooses to work again

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Mar 30th, 2009

Re: minmax

Purely for the sake of simplicity, I would go with this route (doesn't use a second set of variables):

C Syntax (Toggle Plain Text)
int main( int argc, char *argv[] ){
  int *numberlist, i, n, min, max ;
 
  n = atoi( argv[1] );
  numberlist = ( int * ) malloc( n * sizeof( int ) );
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, &min, &max );
int main( int argc, char *argv[] ){
  int *numberlist, i, n, min, max ;

  n = atoi( argv[1] );
  numberlist = ( int * ) malloc( n * sizeof( int ) );
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, &min, &max );

death_oclock

Reputation Points: 128

Solved Threads: 43

Posting Whiz

Offline

389 posts
since Apr 2006

Permalink

Mar 30th, 2009

Re: minmax

Think about another approach:

c Syntax (Toggle Plain Text)
struct IntRange { int minval, maxval; };
 
struct IntRange MinMax(const int* arr, int n)
{
    struct IntRange range = { 0, 0 };
    if (arr && 0 < n) {
        int i;
        range.minval = range.maxval = arr[0];
        for (i = 1; i < n; ++i) {
            if (arr[i] < range.minval)
                range.minval = arr[i];
            else if (range.maxval < arr[i])
                range.maxval = arr[i];
        }
    }
    return range;
};
 
int main()
{
    int* numberlist;
    struct Range range;
    ...
    range = MinMax(numberlist,n);
    printf("Min %d\nMax %d\n",range.minval.range.maxval);
	return 0;
}
struct IntRange { int minval, maxval; };

struct IntRange MinMax(const int* arr, int n)
{
    struct IntRange range = { 0, 0 };
    if (arr && 0 < n) {
        int i;
        range.minval = range.maxval = arr[0];
        for (i = 1; i < n; ++i) {
            if (arr[i] < range.minval)
                range.minval = arr[i];
            else if (range.maxval < arr[i])
                range.maxval = arr[i];
        }
    }
    return range;
};

int main()
{
    int* numberlist;
    struct Range range;
    ...
    range = MinMax(numberlist,n);
    printf("Min %d\nMax %d\n",range.minval.range.maxval);
	return 0;
}

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Mar 30th, 2009

Re: minmax

i have to use that function minmax because that is the one that we were assigned to use for the class, and i made the changed death oclock gave, but it just prints out the min and max values are 0... any ideas?

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Mar 30th, 2009

Re: minmax

Ark's approach is much neater and most likely works. Your solution is very hard to read; the looping approach makes more sense.

death_oclock

Reputation Points: 128

Solved Threads: 43

Posting Whiz

Offline

389 posts
since Apr 2006

Permalink

Mar 31st, 2009

Re: minmax

heres my iterative method, the full assigment is to test the recursive method, and iterative method to see when the recursive method begins to be faster then the iterative method. (time both with array sizes of 500, 5000, 50000, 500000 numbers). And at the moment this one also only prints out the min and max values are 0.

C Syntax (Toggle Plain Text)
/*********************************************************************/
/* iterminmax.c                                                       */
/*********************************************************************/
 
#include <stdio.h>
#include <stdlib.h>
 
void minmax( int a[], int n, int *p_min, int *p_max );
 
int main( int argc, char *argv[] ){
 
  int *numberlist, i, n, min, max;
 
  n = atoi( argv[1] );
 
  numberlist = ( int * ) malloc( n * sizeof( int ) );
 
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, &min, &max );
 
  printf( "\nThe minimum value in your array is: %d", min );
  printf( "\nThe maximum value in your array is: %d\n", max );
 
 
  return 0;
}
 
void minmax( int a[], int n, int *p_min, int *p_max ){
 
  int i;
 
  *p_max = *p_min = a[0];
 
  for( i = 1; i < n; i++ ){
 
    if( a[i] > *p_max )
      *p_max = a[i];
 
    if( a[i] < *p_min )
      *p_min = a[i];
  }
}
/*********************************************************************/
/* iterminmax.c                                                       */
/*********************************************************************/

#include <stdio.h>
#include <stdlib.h>

void minmax( int a[], int n, int *p_min, int *p_max );

int main( int argc, char *argv[] ){

  int *numberlist, i, n, min, max;

  n = atoi( argv[1] );

  numberlist = ( int * ) malloc( n * sizeof( int ) );

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, &min, &max );

  printf( "\nThe minimum value in your array is: %d", min );
  printf( "\nThe maximum value in your array is: %d\n", max );


  return 0;
}

void minmax( int a[], int n, int *p_min, int *p_max ){

  int i;

  *p_max = *p_min = a[0];

  for( i = 1; i < n; i++ ){

    if( a[i] > *p_max )
      *p_max = a[i];

    if( a[i] < *p_min )
      *p_min = a[i];
  }
}

Dewey1040

Reputation Points: 17

Solved Threads: 3

Junior Poster

Offline

126 posts
since Dec 2008

Permalink

Mar 31st, 2009

Re: minmax

Look at csurfer's post again!
It was the true solution of your problems (in other words, it was a correction of your mistake

)...

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Mar 31st, 2009

Re: minmax

There is an initialization failure ...

(Toggle Plain Text)

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

mitrmkar

Reputation Points: 1105

Solved Threads: 389

Posting Virtuoso

Offline

1,714 posts
since Nov 2007

Page 1
2
Next

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Need pointer version of this

Next Thread in C Forum Timeline: clearing the text file contents using C

DaniWeb Message

Cancel Changes

User Name
Password