Ad:

C Discussion Thread
Unsolved
Views: 579

May 25th, 2009

String Question

Expand Post »

Hi,
I want to write a code which takes an array of 20 characters and deletes all spaces between characters, it should leave only letters. For example:
input : d a n i w e b
I want to make it : daniweb

I wrote this code, but it didn't change anything:

C Syntax (Toggle Plain Text)
#include <stdio.h>
 
 int main ()
 {
         int i;
         char a[21];
 
 
 
         gets(a);
 
         for(i = 0; i < 20; i++)
         {
                 if(a[i] == 8 || a[i] == 9)
                 {a[i]= a[i+1];
                 i--;}
                 else continue;
         }
 
         printf("%s", a);
         printf("\n");
 
         return 0;
 }
#include <stdio.h>

 int main ()
 {
         int i;
         char a[21];



         gets(a);

         for(i = 0; i < 20; i++)
         {
                 if(a[i] == 8 || a[i] == 9)
                 {a[i]= a[i+1];
                 i--;}
                 else continue;
         }

         printf("%s", a);
         printf("\n");

         return 0;
 }

Can you help me with that? Thank you all...

Similar Threads

pointer to a string, question. in C++
using stringstream for tokenizing a string in C++

newbiecoder

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

60 posts
since Apr 2009

Permalink

May 25th, 2009

Re: String Question

>I wrote this code, but it didn't change anything
You can't compile this code, that's why it didn't change anything: the else alternative has no correspondent if! Didn't you see it?

What did you want to achieve with so strange a[i] == 8 || a[i] == 9 condition?

It's a very simple assignment. Please, think again then caome back with a proper code tag:
[code=c]
source
[/code]

Or search DaniWeb more carefully: there are lots of right solutions of this assignment

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

May 25th, 2009

Re: String Question

How I would do it:

Create a temporary variable of the same length as the one were you want to delete the spaces from
Use a for-loop to loop through the whole string where you want to delete the spaces from, every time you check whether the read character is a space or another character, when the character is a space, don't copy it to the temporary string, otherwise: copy it to the temporary string.
Eventually you could use strcpy to copy the string without the spaces to the variable which was holding the string with the spaces (note that it will be overwritten then!)

Last edited by tux4life; May 25th, 2009 at 4:48 pm.

tux4life

Reputation Points: 2125

Solved Threads: 243

Postaholic

Offline

2,105 posts
since Feb 2009

Permalink

May 25th, 2009

Re: String Question

Remember KISS principle: no need in temporary strings!

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

May 25th, 2009

Re: String Question

Click to Expand / Collapse Quote originally posted by ArkM ...

Remember KISS principle: no need in temporary strings!

I thought that was the simplest way, however he could also just shift each character to the left if there's a space in between. Or do you know the 'ultimate' way?

Last edited by tux4life; May 25th, 2009 at 5:05 pm.

tux4life

Reputation Points: 2125

Solved Threads: 243

Postaholic

Offline

2,105 posts
since Feb 2009

Permalink

May 26th, 2009

Re: String Question

Click to Expand / Collapse Quote originally posted by tux4life ...

Or do you know the 'ultimate' way?

i know the ultimate way

c Syntax (Toggle Plain Text)
#include<jephthah.h>
 
newStr_ptr = removeSpacesAndCondense(myString);
#include<jephthah.h>

newStr_ptr = removeSpacesAndCondense(myString);

it's non-standard and not very portable, but hey, it works on my machine.

jephthah

Reputation Points: 2143

Solved Threads: 178

Posting Maven

Offline

2,567 posts
since Feb 2008

Permalink

May 26th, 2009

Re: String Question

>Or do you know the 'ultimate' way?
Why not?

c Syntax (Toggle Plain Text)
char* condense(char* s)
{
    if (s) {
        char* p = s;
        char* q = s;
        /* (never write so:) */
        do if (*p != ' ')
           *q++ = *p;
        while (*p++);
    }
    return s;
}
char* condense(char* s)
{
    if (s) {
        char* p = s;
        char* q = s;
        /* (never write so:) */
        do if (*p != ' ')
           *q++ = *p;
        while (*p++);
    }
    return s;
}

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: How Do I change Visual Studio 2005 Startup

Next Thread in C Forum Timeline: Encrypting strings with libmcrypt

DaniWeb Message

Cancel Changes

User Name
Password