Ad:

C Discussion Thread
Unsolved
Views: 703

Jul 1st, 2009

extract multidigits from a char* (substring)

Expand Post »

Hi,
given a cstring, I need to extract the digits in it, the digits are prefixed with either a '+' or '-'. Like

C Syntax (Toggle Plain Text)
,.,.,.,+3ACT,.,.,.,.-12,.,.,.,.,.,.,.,actgncgt
#OUTPUT
3
12
,.,.,.,+3ACT,.,.,.,.-12,.,.,.,.,.,.,.,actgncgt
#OUTPUT
3
12

I've made a working program that does what I want,
but it seems overly complicated.
Does anyone have an idea if this can be done smarter, better, faster?

Thanks in advance

Btw I checked the program with valgrind and there are no leaks or errors

c Syntax (Toggle Plain Text)
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
 
int main(){
  char tmp_array[100];
  const char* seq = "+1236,,..,,actgn+3ACT-4CCCC";
  printf("%s\n",seq);
 
  for(int i=0;i<strlen(seq);i++){
    if(seq[i]!='+'&&seq[i]!='-')
      continue;
    int j=i+1;
    while(j<strlen(seq)){
      if(seq[j]>='0' &&seq[j]<='9'){
	j++;
      }else
	break;
 
    }
    strncpy(tmp_array,seq+i+1,j-i-1);
    tmp_array[j-i-1]='\0';
    printf("numbers in substrings are: %d\n",atoi(tmp_array));
  }
 
  return 0;
}
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main(){
  char tmp_array[100];
  const char* seq = "+1236,,..,,actgn+3ACT-4CCCC";
  printf("%s\n",seq);

  for(int i=0;i<strlen(seq);i++){
    if(seq[i]!='+'&&seq[i]!='-')
      continue;
    int j=i+1;
    while(j<strlen(seq)){
      if(seq[j]>='0' &&seq[j]<='9'){
	j++;
      }else
	break;
      
    }
    strncpy(tmp_array,seq+i+1,j-i-1);
    tmp_array[j-i-1]='\0';
    printf("numbers in substrings are: %d\n",atoi(tmp_array));
  }
  
  return 0;
}

Similar Threads

extract numbers from char in C++
How to extract words from char type string in C++
Converting specified elements of array of char in C++

monkey_king

Reputation Points: 70

Solved Threads: 9

Junior Poster

Offline

160 posts
since Aug 2008

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

Quote ...

Does anyone have an idea if this can be done smarter, better, faster?

check out: strtok() ... this breaks a string into tokens at each of one or more delimiters.

use it to break the string at each '+' or '-' (the delimiters), then check if the first one or more characters of each resulting string (the tokens) are numerals.

if it does, then push that number onto your result array. if it doesn't, skip on to the next token.

.

Last edited by jephthah; Jul 1st, 2009 at 7:33 pm. Reason: realized you dont want to save the + or -

jephthah

Reputation Points: 2143

Solved Threads: 178

Posting Maven

Offline

2,567 posts
since Feb 2008

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

untested but here...

C Syntax (Toggle Plain Text)
int main()
{
  char tmp_array[100];
  const char* seq = "+1236,,..,,actgn+3ACT-4CCCC";
  printf("%s\n",seq);
 
   while (*seq)
   {        // pre-scan for +-
      if (*seq != '-' && *seq != '+')
      {
         seq++;
         continue;
      }
 
      char *p = tmparray;
	  *p++ = *seq++;
 
      while (*seq)
	  {
	      if ((*seq < '0') || ('9' < *seq))
		  { 
		     break;
	      }
 
          *p++ = *seq++;
	   }
 
       *p = 0;
 
       printf("numbers in substrings are: %d\n",atoi(tmp_array)); 
  } 
 
  return 0;
}
int main()
{
  char tmp_array[100];
  const char* seq = "+1236,,..,,actgn+3ACT-4CCCC";
  printf("%s\n",seq);

   while (*seq)
   {        // pre-scan for +-
      if (*seq != '-' && *seq != '+')
      {
         seq++;
         continue;
      }

      char *p = tmparray;
	  *p++ = *seq++;

      while (*seq)
	  {
	      if ((*seq < '0') || ('9' < *seq))
		  { 
		     break;
	      }

          *p++ = *seq++;
	   }

       *p = 0;

       printf("numbers in substrings are: %d\n",atoi(tmp_array)); 
  } 

  return 0;
}

wildgoose

Reputation Points: 546

Solved Threads: 99

Practically a Posting Shark

Offline

891 posts
since Jun 2009

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

But if allowed to use off the shelf library functions, then poster jephthah has the right idea!

wildgoose

Reputation Points: 546

Solved Threads: 99

Practically a Posting Shark

Offline

891 posts
since Jun 2009

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

why dont you put an array with stuff you want and extract that to new array?

MrNoob

Reputation Points: 34

Solved Threads: 7

Posting Whiz in Training

Offline

218 posts
since May 2009

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

Double the processing time. No optimal!

Why process a list twice when you can do it once!

wildgoose

Reputation Points: 546

Solved Threads: 99

Practically a Posting Shark

Offline

891 posts
since Jun 2009

Permalink

Jul 1st, 2009

Re: extract multidigits from a char* (substring)

wildgoose: posting "Untested" code on daniweb's C forum is generally risky business

anyhow, being able to use strtok() correctly is tricky for a new user. Also make sure you understand what is going on with strtol()

c Syntax (Toggle Plain Text)
char string[100]="+1236,,..,,actgn+3ACT-4CCCC";
char *token, *ptr;
int value;
 
token = strtok(string,"+-");
printf ("found numbers: ");
 
while (token != NULL)
{	
	value = strtol(token,&ptr,10);
	if (ptr != token)
		printf(" %d,",value);
 
	token = strtok(NULL,"+-");
}
printf("\n");
char string[100]="+1236,,..,,actgn+3ACT-4CCCC";
char *token, *ptr;
int value;
	
token = strtok(string,"+-");
printf ("found numbers: ");
	
while (token != NULL)
{	
	value = strtol(token,&ptr,10);
	if (ptr != token)
		printf(" %d,",value);

	token = strtok(NULL,"+-");
}
printf("\n");

Last edited by jephthah; Jul 1st, 2009 at 8:02 pm.

jephthah

Reputation Points: 2143

Solved Threads: 178

Posting Maven

Offline

2,567 posts
since Feb 2008

Permalink

Jul 2nd, 2009

Re: extract multidigits from a char* (substring)

Thanks ppl,
I need to keep track of the indices,
so the strtok approch wont work.

But thanks again.

monkey_king

Reputation Points: 70

Solved Threads: 9

Junior Poster

Offline

160 posts
since Aug 2008

Permalink

Jul 2nd, 2009

Re: extract multidigits from a char* (substring)

well, that's a nice bit of feature creep to throw out there at the last minute.

do you work in marketing?

jephthah

Reputation Points: 2143

Solved Threads: 178

Posting Maven

Offline

2,567 posts
since Feb 2008

Permalink

Jul 3rd, 2009

Re: extract multidigits from a char* (substring)

Click to Expand / Collapse Quote originally posted by monkey_king ...

Thanks ppl,
I need to keep track of the indices,
so the strtok approch wont work.

But thanks again.

The strtok() approach will work, just with a little added overhead - specifically, tracking the size of tokens you have already passed and either used or discarded.

YrthWyndAndFyre

Reputation Points: 24

Solved Threads: 1

Newbie Poster

Offline

7 posts
since Jul 2009

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: adding from 0 to a number that will be entered by the user .

Next Thread in C Forum Timeline: Program Keeps reading wrong input

DaniWeb Message

Cancel Changes

User Name
Password