Ad:

C Discussion Thread
Unsolved
Views: 503

Aug 6th, 2009

whats wrong about my program?help me...

Expand Post »

what's wrong about this?
why when i compile,it come out expected primary-expression?
what is that?

c Syntax (Toggle Plain Text)
#include<stdio.h>
#include<conio.h>
main()
{
     float Lab,Mid,Pro,Quiz,Final,Total;
 
     printf("\nEnter your mark for Lab:");
     scanf("%f",&Lab);
     printf("\nEnter your mark for Mid Exam:");
     scanf("%f",&Mid);
     printf("\nEnter your mark for Quiz:");
     scanf("%f",&Quiz);
     printf("\nEnter your mark for Project:");
     scanf("%f",&Pro);
     printf("\nEnter your mark for Final Exam:");
     scanf("%f",&Final);
 
     Total=(10/100.0)*Lab+(15/100.0)*Mid+(5/100.0)*Quiz+(20/100.0)*Pro+(50/100.0)*Final;
 
 
     if(Total>=35)
       printf("\nyou are passed");
     else
       printf("\nyou are failed");
 
     if(Total>=80)
       {
       printf("\nyour is grade A",Total);
       printf("\nwell done");
       }
     else if(Total>=75)
       {
        printf("\nyour grade is A-,%f",Total);
        }
     else
       {
        printf("\nyou don't get A-,%f",Total);
        }
     else if(Total>=70)
       {
        printf("\nyour grade is B+,%f",Total);
        }
     else
       {
        printf("\nyou don't get B+,%f",Total);
        }
      else if(Total>=65)
       {
        printf("\nyour grade is B,%f",Total);
        }
      else
       {
        printf("\nyou don't get B,%f",Total);
        }
       else if(Total>=60)
       {
        printf("\nyour grade is B-,%f",Total);
        }
      else 
       {
        printf("\nyou don't get B-,%f",Total);
        }
      else if(Total>=55)
       {
        printf("\nyour grade is C+,%f",Total);
        }
      else 
       {
        printf("\nyou don't get C+,%f",Total);
        }                           
      else if(Total>=50)
       {
        printf("\nyour grade is C,%f",Total);
        }
      else
       {
        printf("\nyou don't get C,%f",Total);
        }
      else if(Total>=45)
       {
        printf("\nyour grade is C-,%f",Total);
        }
      else
       {
        printf("\nyou don't get C-,%f",Total);
        }
      else if(Total>=40)
       {
        printf("\nyour grade is D+,%f",Total);
        }
      else
       {
        printf("\nyou don't get D+,%f",Total);
        }
      else if(Total>=35)
       {
        printf("\nyour grade is D,%f",Total);
        }
      else 
       {
        printf("\nyou don't get D,%f",Total);
        }
 
     getch();
     return 0;
     }
#include<stdio.h>
#include<conio.h>
main()
{
     float Lab,Mid,Pro,Quiz,Final,Total;

     printf("\nEnter your mark for Lab:");
     scanf("%f",&Lab);
     printf("\nEnter your mark for Mid Exam:");
     scanf("%f",&Mid);
     printf("\nEnter your mark for Quiz:");
     scanf("%f",&Quiz);
     printf("\nEnter your mark for Project:");
     scanf("%f",&Pro);
     printf("\nEnter your mark for Final Exam:");
     scanf("%f",&Final);

     Total=(10/100.0)*Lab+(15/100.0)*Mid+(5/100.0)*Quiz+(20/100.0)*Pro+(50/100.0)*Final;


     if(Total>=35)
       printf("\nyou are passed");
     else
       printf("\nyou are failed");

     if(Total>=80)
       {
       printf("\nyour is grade A",Total);
       printf("\nwell done");
       }
     else if(Total>=75)
       {
        printf("\nyour grade is A-,%f",Total);
        }
     else
       {
        printf("\nyou don't get A-,%f",Total);
        }
     else if(Total>=70)
       {
        printf("\nyour grade is B+,%f",Total);
        }
     else
       {
        printf("\nyou don't get B+,%f",Total);
        }
      else if(Total>=65)
       {
        printf("\nyour grade is B,%f",Total);
        }
      else
       {
        printf("\nyou don't get B,%f",Total);
        }
       else if(Total>=60)
       {
        printf("\nyour grade is B-,%f",Total);
        }
      else 
       {
        printf("\nyou don't get B-,%f",Total);
        }
      else if(Total>=55)
       {
        printf("\nyour grade is C+,%f",Total);
        }
      else 
       {
        printf("\nyou don't get C+,%f",Total);
        }                           
      else if(Total>=50)
       {
        printf("\nyour grade is C,%f",Total);
        }
      else
       {
        printf("\nyou don't get C,%f",Total);
        }
      else if(Total>=45)
       {
        printf("\nyour grade is C-,%f",Total);
        }
      else
       {
        printf("\nyou don't get C-,%f",Total);
        }
      else if(Total>=40)
       {
        printf("\nyour grade is D+,%f",Total);
        }
      else
       {
        printf("\nyou don't get D+,%f",Total);
        }
      else if(Total>=35)
       {
        printf("\nyour grade is D,%f",Total);
        }
      else 
       {
        printf("\nyou don't get D,%f",Total);
        }
                                                                                                                                                                                                                                          
     getch();
     return 0;
     }

Last edited by John A; Aug 6th, 2009 at 9:24 pm. Reason: added code tags

Similar Threads

Whats wrong with my computer??? in Viruses, Spyware and other Nasties
Anyone know whats wrong with this union? in C
Can anyone figure out what is wrong in my program? in C++
Please help me i dont understand whats wrong with my code in C++
im wonderin whats wrong in my work in C++

des6043

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

4 posts
since Aug 2009

Permalink

Aug 6th, 2009

Re: whats wrong about my program?help me...

C Syntax (Toggle Plain Text)
printf("\nyour is grade A",Total);
printf("\nyour is grade A",Total);

Take a look at that one. Figure what are you missing.

When you post code you need to wrapped around code tags to present it in a proper format. See here.

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Permalink

Aug 7th, 2009

Re: whats wrong about my program?help me...

Well,It also gives me an error.

C Syntax (Toggle Plain Text)

syntax error before else

every where when you have else statements coming ahead of else if statements.

May be we can alter the structure of the program , if suppose you have a candidate getting less than 35, you still get into the if block

C Syntax (Toggle Plain Text)
if(Total>=80)
.
.
if(Total>=80)
.
.

here and check for grades.

I also don't under the rationale behind the statements like

C Syntax (Toggle Plain Text)
printf("\nyou don't get A-,%f",Total);
.
.
printf("\nyou don't get B,%f",Total);
.
.
printf("\nyou don't get C+,%f",Total);
printf("\nyou don't get A-,%f",Total);
.
.
printf("\nyou don't get B,%f",Total);
.
.
printf("\nyou don't get C+,%f",Total);

I would rather care for my grades than "you don't get" thing.

1st approach:
I would rather have a huge if block which checks whether the toal is greater than 35 and then calculate the grades.

C Syntax (Toggle Plain Text)
const int MINIMUM_PASS_MARKS = 35;
if (total >= MINIMUM_PASS_MARKS) {
    /* and then go on checking for a valid grade*/
}
else {
/* failed*/
}
const int MINIMUM_PASS_MARKS = 35;
if (total >= MINIMUM_PASS_MARKS) {
    /* and then go on checking for a valid grade*/
}
else {
/* failed*/
}

Option 2 :
Well ,you have a set grade for any given marks and a definite increment (5 in your case), So we make an array which holds
marks[] and another array which hold your grades[],it would make things simpler.
Something like this

c Syntax (Toggle Plain Text)
#include<stdio.h>
 
int main(void) {
    const int MAX_MARKS = 100;
    const int mark_range[] = {80, 75, 70, 65, 60, 55, 50, 45, 40, 35};
    const char *grades[] = {"A", "A-", "B+", "B", "B-","C+", "C", "C-",
                     "D+", "D"};
    int total = 0;
    int i = 0;
    int divisons = sizeof (mark_range) / sizeof mark_range[0];
    int passed = 0; /*let 0 represent fail*/
 
    printf("Enter your total ");
    if (scanf("%d", &total) == 1) {
        printf("Your total is %d", total);
            /*Loop through to get your grade*/ 
            for ( i = 0; i < divisons; i++) {
            if (total >= mark_range[i] && total <= MAX_MARKS) {
 
                printf("\nYour grade is %s",grades[i]);
                passed = 1;
                break;
            }
         }
         if (passed == 0)
             printf("\nSorry, you failed.");
    }
    else
        fprintf(stderr, "Error in input");
    return 0;
}
#include<stdio.h>

int main(void) {
    const int MAX_MARKS = 100;
    const int mark_range[] = {80, 75, 70, 65, 60, 55, 50, 45, 40, 35};
    const char *grades[] = {"A", "A-", "B+", "B", "B-","C+", "C", "C-",
                     "D+", "D"};
    int total = 0;
    int i = 0;
    int divisons = sizeof (mark_range) / sizeof mark_range[0];
    int passed = 0; /*let 0 represent fail*/
    
    printf("Enter your total ");
    if (scanf("%d", &total) == 1) {
        printf("Your total is %d", total);
            /*Loop through to get your grade*/ 
            for ( i = 0; i < divisons; i++) {
            if (total >= mark_range[i] && total <= MAX_MARKS) {

                printf("\nYour grade is %s",grades[i]);
                passed = 1;
                break;
            }
         }
         if (passed == 0)
             printf("\nSorry, you failed.");
    }
    else
        fprintf(stderr, "Error in input");
    return 0;
}

Give them a rude shock if someone enters marks > 100

and we don't use non standard headers (aka conio.h and the getch() function)

Last edited by zalezog; Aug 7th, 2009 at 11:44 am.

zalezog

Reputation Points: 53

Solved Threads: 13

Light Poster

Offline

47 posts
since Oct 2008

Permalink

Aug 8th, 2009

Re: whats wrong about my program?help me...

here is the proper code

Attached Files

ONE.C (1.5 KB, 9 views)

sseethalak

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Aug 2009

Permalink

Aug 10th, 2009

Re: whats wrong about my program?help me...

Thanks all you people help...

des6043

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

4 posts
since Aug 2009

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Mastermind program

Next Thread in C Forum Timeline: NEED Help ASAP

DaniWeb Message

Cancel Changes

User Name
Password