Ad:

C Discussion Thread
Marked Solved
Views: 849

Aug 23rd, 2009

can't get fopen to work

Expand Post »

every thing works till the fopen, the sprintf works as i'm printing to check that. i just doing know what is causing this not to work

it prints "cannot open (null)" but the filename var does have something assigned to it.

any help will be welcomed

c Syntax (Toggle Plain Text)
 
	char tmpfilename[10];
	char filename[15];
 
	if(argv[2] == NULL){
		printf("no output file name specified\n");
		printf("would you like to specify one now? (y/n)\n");
		scanf("%c", &a);
		if(a=='y'){
			printf("enter the name of the file to be outputted (less than 10 letters)\n");
			scanf("%s", &tmpfilename);
			sprintf(filename,"%s.ps",tmpfilename);
			printf("%s there should be a string here\n",filename);
 
		--->	if(!(out = fopen(filename, "w"))){
				fprintf(stderr,"Cannot open %s\n",filename);
				exit(2);
			}
		}
		if(a=='n'){
				printf("ok, exiting\n");
		exit(1);
		}
 
		if(a != 'y' && a != 'n'){
			printf("unexpected input...exiting\n");
			exit(1);
		}
	}
	char tmpfilename[10];
	char filename[15];

	if(argv[2] == NULL){
		printf("no output file name specified\n");
		printf("would you like to specify one now? (y/n)\n");
		scanf("%c", &a);
		if(a=='y'){
			printf("enter the name of the file to be outputted (less than 10 letters)\n");
			scanf("%s", &tmpfilename);
			sprintf(filename,"%s.ps",tmpfilename);
			printf("%s there should be a string here\n",filename);
		
		--->	if(!(out = fopen(filename, "w"))){
				fprintf(stderr,"Cannot open %s\n",filename);
				exit(2);
			}
		}
		if(a=='n'){
				printf("ok, exiting\n");
		exit(1);
		}
		
		if(a != 'y' && a != 'n'){
			printf("unexpected input...exiting\n");
			exit(1);
		}
	}

Similar Threads

fopen problem in PHP
Help on PHP fopen in PHP
Why fopen() doesnt work? in C++
printing to the screen after using fopen() in PHP

EvilOrange

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

30 posts
since Jan 2009

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

Post some more code, for example all the other declarations of variables used in this code.

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

there is only 2 var missing and thats:

char a;
FILE *out;

argv[2] is NULL which is why this bit of code comes into play

EvilOrange

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

30 posts
since Jan 2009

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

Click to Expand / Collapse Quote originally posted by EvilOrange ...

there is only 2 var missing and thats:

char a;
FILE *out;

argv[2] is NULL which is why this bit of code comes into play

On the phone
Nick: Doctor, can you cure my cough? It is a horrible cough, I cannot sleep at night.
Dr. Hell: Sorry, Nick, I cannot prescribe the proper medication without seeing you first, make an appointment for tomorrow.
Nick: OK.
Next day at Dr Hell's consult.
Dr Hell: Who are you?
Nick's buddy: I am Nick's best friend. He told me that you needed to see him first, in order for you to prescribe medicine for his cough. So he sent me with his best photograph taken last year at the summer's party.

EvilOrange> there is only 2 var missing and thats:
That's not enough.

Dr Hell guesses that it has to do with...

(Toggle Plain Text)

scanf("%s", &tmpfilename);

Last edited by Aia; Aug 23rd, 2009 at 7:42 pm.

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

ok here his the print out i get from terminal:

C Syntax (Toggle Plain Text)
>./run final.txt
>no output file name specified                       <--Line 20
>would you like to specify one now? (y/n)      <--Line 21
>y                                                               <--Line 22
>enter the name of the file to be outputted (less than 10 letters)  <--Line 24
>hds                                                            <--Line 25
>hds.ps <-there should be a string here             <--Line 27 - proving the scanf("%s", &tmpfilename) is working
>Cannot open (null)                                      <--Line 30
>./run final.txt
>no output file name specified                       <--Line 20
>would you like to specify one now? (y/n)      <--Line 21
>y                                                               <--Line 22
>enter the name of the file to be outputted (less than 10 letters)  <--Line 24
>hds                                                            <--Line 25
>hds.ps <-there should be a string here             <--Line 27 - proving the scanf("%s", &tmpfilename) is working
>Cannot open (null)                                      <--Line 30

and here is the the totality of the file input code:

c Syntax (Toggle Plain Text)
int main(int argc, char *argv[]){
	int i;
	char a;
	char tmpfilename[SIZE];
	char filename[15];
 
 
	FILE *fp, *out;
	Program prog;
 
 
 
	if(!(fp = fopen(argv[1], "r"))){
		fprintf(stderr,"Cannot open %s\n",argv[1]);
		exit(2);
	}
 
 
	if(argv[2] == NULL){
		printf("no output file name specified\n");
		printf("would you like to specify one now? (y/n)\n");
		scanf("%c", &a);
		if(a=='y'){
			printf("enter the name of the file to be outputted (less than 10 letters)\n");
			scanf("%s", &tmpfilename);
			sprintf(filename,"%s.ps",tmpfilename);
			printf("%s there should be a string here\n",filename);
 
			if(!(out = fopen(filename, "w"))){
				fprintf(stderr,"Cannot open %s\n",filename);
				exit(2);
			}
		}
		if(a=='n'){
				printf("ok, exiting\n");
		exit(1);
		}
 
		if(a != 'y' && a != 'n'){
			printf("unexpected input...exiting\n");
			exit(1);
		}
	}
 
	if(!(out = fopen(argv[2], "w"))){
		fprintf(stderr,"Cannot open %s\n",argv[2]);
		exit(2);
	}
int main(int argc, char *argv[]){
	int i;
	char a;
	char tmpfilename[SIZE];
	char filename[15];
	

	FILE *fp, *out;
	Program prog;
	


	if(!(fp = fopen(argv[1], "r"))){
		fprintf(stderr,"Cannot open %s\n",argv[1]);
		exit(2);
	}

	
	if(argv[2] == NULL){
		printf("no output file name specified\n");
		printf("would you like to specify one now? (y/n)\n");
		scanf("%c", &a);
		if(a=='y'){
			printf("enter the name of the file to be outputted (less than 10 letters)\n");
			scanf("%s", &tmpfilename);
			sprintf(filename,"%s.ps",tmpfilename);
			printf("%s there should be a string here\n",filename);
		
			if(!(out = fopen(filename, "w"))){
				fprintf(stderr,"Cannot open %s\n",filename);
				exit(2);
			}
		}
		if(a=='n'){
				printf("ok, exiting\n");
		exit(1);
		}
		
		if(a != 'y' && a != 'n'){
			printf("unexpected input...exiting\n");
			exit(1);
		}
	}
	
	if(!(out = fopen(argv[2], "w"))){
		fprintf(stderr,"Cannot open %s\n",argv[2]);
		exit(2);
	}

Last edited by EvilOrange; Aug 23rd, 2009 at 7:56 pm. Reason: taking out whitespace

EvilOrange

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

30 posts
since Jan 2009

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

EvilOrange> <--Line 27 - proving the scanf("%s", &tmpfilename) is working
Dealing with the format %s in scanf() you must pass the argument as plain tmpfilename or as &tmpfilename[0] , but not as &tmpfilename
EvilOrange> >Cannot open (null) <--Line 30
Are you sure is line 30 and not line 46? fprintf(stderr,"Cannot open %s\n",argv[2]);

Last edited by Aia; Aug 23rd, 2009 at 8:10 pm.

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Permalink

Aug 23rd, 2009

Re: can't get fopen to work

Click to Expand / Collapse Quote originally posted by Aia ...

EvilOrange> <--Line 27 - proving the scanf("%s", &tmpfilename) is working
Dealing with the format %s in scanf() you must pass the argument as plain tmpfilename or as &tmpfilename[0] , but not as &tmpfilename
EvilOrange> >Cannot open (null) <--Line 30
Are you sure is line 30 and not line 46? fprintf(stderr,"Cannot open %s\n",argv[2]);

bit embarrased now... had code duplication early on, and deleted the wrong snippet which is shown on 46, and you where correct about the cannot open (null)

it is a sunday and i shouldn't be working after all, thanks.

EvilOrange

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

30 posts
since Jan 2009

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Why need temperory variables when enterring values for the matrix?

Next Thread in C Forum Timeline: how to fork a grandchild process

DaniWeb Message

Cancel Changes

User Name
Password