Ad:

C Discussion Thread
Unsolved
Views: 551

Nov 2nd, 2009

-1

help with c program

Expand Post »

HI
the prgram below request a user to enter 3 character id number and interger age. a function must be used
that tells the user how many years to retirement. i must pass the age and print
a message in the function. retirement age is 65 for persons over 45 and 70 for all
other persons. the id number is a 3 element character array. the program
should continue to accept user input until the id number entered is 000 or age is
-1.

please help. i am fairly new to c and i am unsure of how to do the function part.

my program is compiling and running but a long number is printing and not the age.

C Syntax (Toggle Plain Text)
#include<stdio.h>
#include<conio.h>
 
int main ()
{
 
	int idnumber, retirement_years, age=0;
 
	//int current_age (int age1);
		do
		{
 
			printf ("\nPlease enter 3 digit id number\n");
			scanf("%d", &idnumber);
			printf("\n Please enter your age\n");
			scanf("%d", &age);
 
			if (age >45) 
			{
				retirement_years = 65-age;
				printf("\n You have %.2d years to retirement\n", &retirement_years);
			}
			else 
			{
				retirement_years = 70-age;
				printf("\n You have %.2d years to retirement\n", &retirement_years);
			}
		}
			while ((idnumber ==000) || (age== -1));
 
 
		getch ();
			return 0;
}
 
 
 
 
 
 
		//int current_age (int age1)
#include<stdio.h>
#include<conio.h>

int main ()
{

	int idnumber, retirement_years, age=0;

	//int current_age (int age1);
		do
		{

			printf ("\nPlease enter 3 digit id number\n");
			scanf("%d", &idnumber);
			printf("\n Please enter your age\n");
			scanf("%d", &age);

			if (age >45) 
			{
				retirement_years = 65-age;
				printf("\n You have %.2d years to retirement\n", &retirement_years);
			}
			else 
			{
				retirement_years = 70-age;
				printf("\n You have %.2d years to retirement\n", &retirement_years);
			}
		}
			while ((idnumber ==000) || (age== -1));
		

		getch ();
			return 0;
}

		




		//int current_age (int age1)

Similar Threads

Interesting C program for Accelerator in C
C program for writing test cases in C
Program help required in Assembly
AutoExecuting a program Without Explorer in Windows NT / 2000 / XP
Help with a program in Java

maubybark

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2009

Permalink

Nov 3rd, 2009

Re: help with c program

Here we go,

Quote ...

my program is compiling and running but a long number is printing and not the age.

you are printing the address of variable

C Syntax (Toggle Plain Text)
printf("\n You have %.2d years to retirement\n", &retirement_years);
printf("\n You have %.2d years to retirement\n", &retirement_years);

is wrong.
remove '&' before retirement_years in both if and else parts.

change this condition to

C Syntax (Toggle Plain Text)
while ((idnumber ==000) || (age== -1));
while ((idnumber ==000) || (age== -1));

C Syntax (Toggle Plain Text)
while ( (idnumber !=0)  ||  (age != -1) );
while ( (idnumber !=0)  ||  (age != -1) );

the program will terminate when idnumber is equal to 0 or age is -1.

1. no need of using getch().
2. remove conio.h
if you require functions you can use the below.

C Syntax (Toggle Plain Text)
int get_retirement_age(int age, int idnumber);
 
int main()
{
  int age, idnumber, valid;
    do {
        printf("enter age and idnumber\n");
        scanf("%d\n",&age);
        printf("Enter idnumber\n");
        scanf("%d\n",&idnumber);
       valid = get_retirement_age(age,idnumber) ;   
      if(valid == 0 )
          printf( "Invalid details entered: terminating program\n");
 
   } while(valid);
return 0;
}
 
int get_retirement_age(int age, int idnumber)
{   
      int retirement_years;
 
      if(age == -1 || idnumber == 0)
             return 0;
 
      if (age >45) {	
             retirement_years = 65-age;			
   printf(" you have %d years to retirement\n",  retirement_years); 
}
     else {	
         retirement_years = 70-age;			
        printf("You have %d years to retirement\n",retirement_years);
}
return 1;
}
int get_retirement_age(int age, int idnumber);

int main()
{
  int age, idnumber, valid;
    do {
        printf("enter age and idnumber\n");
        scanf("%d\n",&age);
        printf("Enter idnumber\n");
        scanf("%d\n",&idnumber);
       valid = get_retirement_age(age,idnumber) ;   
      if(valid == 0 )
          printf( "Invalid details entered: terminating program\n");
           
   } while(valid);
return 0;
}

int get_retirement_age(int age, int idnumber)
{   
      int retirement_years;

      if(age == -1 || idnumber == 0)
             return 0;

      if (age >45) {	
             retirement_years = 65-age;			
   printf(" you have %d years to retirement\n",  retirement_years); 
}
     else {	
         retirement_years = 70-age;			
        printf("You have %d years to retirement\n",retirement_years);
}
return 1;
}

Note : its not compiled or tested just on my head..

Last edited by Iam3R; Nov 3rd, 2009 at 12:11 am. Reason: In tags

Iam3R

Reputation Points: 34

Solved Threads: 4

Junior Poster

Offline

110 posts
since Oct 2009

Permalink

Jan 2nd, 2011

Re: help with c program

Hi,

change this while condition to

while ((idnumber ==000) || (age== -1));

to

while ( (idnumber !=0) || (age != -1) );

Your program will work

uttamclasses

Reputation Points: 11

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Jan 2011

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Beginners Program: Leap Year

Next Thread in C Forum Timeline: Help me please

DaniWeb Message

Cancel Changes

User Name
Password