Ad:

C Discussion Thread
Marked Solved
Views: 1001

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Nov 7th, 2009

Could Someone Try Compiling This On A Different Compiler

Expand Post »

I wrote this very small program that works fine until I remove the comments for the fprintf function.

Basically the program will prompt the user for a numeric value, when the user guesses right(1234) the program exits. When I remove the comments the program never exits...Does anyone have any idea why? I'm completely lost as to why it would behave like this...maybe its my compiler - gcc 4.4.1

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include <stdlib.h>
 
unsigned long testval = 1234;
 
void* foundit(void)
{
	fputs("found it!\n", stdout);
	return (void*)0;
}
 
void* tryit(void)
{
	unsigned long val;
 
	fputs("enter a value/guess->", stdout);
	fscanf(stdin, "%u", &val);
 
	if (val == testval)
	{
		return (void*)&foundit;
	}
	else
	{
		return (void*)&tryit;
	}
}
 
int main(int argc, char**argv)
{
	void *addr = (void*)&tryit;
 
	//fprintf(stdout, "ans->%u\n", 1);	//remove comments and program runs 
							//but fails to exit with correct value
	while ((addr = ((void*(*)(void))addr)()))
	{}
	exit(EXIT_SUCCESS);
}
#include <stdio.h>
#include <stdlib.h>

unsigned long testval = 1234;

void* foundit(void)
{
	fputs("found it!\n", stdout);
	return (void*)0;
}

void* tryit(void)
{
	unsigned long val;

	fputs("enter a value/guess->", stdout);
	fscanf(stdin, "%u", &val);
	
	if (val == testval)
	{
		return (void*)&foundit;
	}
	else
	{
		return (void*)&tryit;
	}
}

int main(int argc, char**argv)
{
	void *addr = (void*)&tryit;

	//fprintf(stdout, "ans->%u\n", 1);	//remove comments and program runs 
							//but fails to exit with correct value
	while ((addr = ((void*(*)(void))addr)()))
	{}
	exit(EXIT_SUCCESS);
}

Similar Threads

Header files, C++ vs C compiler question in C++
Binary Recursion Function Errors - Help!! in C++
Time function in C
EOL is not working and uncheck or unsafe operation in Java
urgent help required plz help in C

gerard4143

Reputation Points: 499

Solved Threads: 367

Postaholic

Online

2,197 posts
since Jan 2008

Permalink

Nov 7th, 2009

-7

Re: Could Someone Try Compiling This On A Different Compiler

>>while ((addr = ((void*(*)(void))addr)())

Didn't your compiler produce an error or warning on that line?? tryit() does not return a value, yet in the above addr is being assigned the return value of tryint(). You can't have it both ways. try this:
while( addr() )

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Nov 7th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

Click to Expand / Collapse Quote originally posted by Ancient Dragon ...

>>while ((addr = ((void*(*)(void))addr)())

Didn't your compiler produce an error or warning on that line?? tryit() does not return a value, yet in the above addr is being assigned the return value of tryint(). You can't have it both ways. try this:
while( addr() )

No the complier had no problems casting a void pointer to a function..should it?
And for tryit() the if statement assures that the function returns a value..

But that isn't the problem...The problem is when I remove the comments from this line

C Syntax (Toggle Plain Text)

//fprintf(stdout, "ans->%u\n", 1);

The program fails to exit correctly...Note the program works as intended while the comments are there...

gerard4143

Reputation Points: 499

Solved Threads: 367

Postaholic

Online

2,197 posts
since Jan 2008

Permalink

Nov 7th, 2009

-7

Re: Could Someone Try Compiling This On A Different Compiler

Worked fine for me using vc++ 2008 express

Quote ...

ans->1
enter a value/guess->1234
found it!
Press any key to continue . . .

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Nov 7th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

Click to Expand / Collapse Quote originally posted by Ancient Dragon ...

Worked fine for me using vc++ 2008 express

Humph...That means I'm going have to walk through some assembler and find out why removing the comments from this line

C Syntax (Toggle Plain Text)
fprintf(stdout, "ans->%u\n", 1);
fprintf(stdout, "ans->%u\n", 1);

causes the program to behave differently...well besides printing 1 to the display..

Thanks for trying the program Ancient Dragon

gerard4143

Reputation Points: 499

Solved Threads: 367

Postaholic

Online

2,197 posts
since Jan 2008

Permalink

Nov 7th, 2009

-7

Re: Could Someone Try Compiling This On A Different Compiler

>>well besides printing 1 to the display..

The reason for that should be obvious.

Also compiled with Code::Blocks using MinGW (gcc 3.4.5) and it worked ok.

Last edited by Ancient Dragon; Nov 7th, 2009 at 9:38 pm.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Nov 8th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

Well I tried compiling the code on GCC 4.3.2 and it worked. I think GCC 4.4.1 may be in need of an update...Thanks again Ancient Dragon

So to recap:

the code will not work correctly on GCC 4.4.1
but it will work correctly on GCC 4.3.2, GCC 3.4.5 and vc++ 2008 express

gerard4143

Reputation Points: 499

Solved Threads: 367

Postaholic

Online

2,197 posts
since Jan 2008

Permalink

Nov 8th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

>No the complier had no problems casting a void pointer to a function..should it?
It might. Technically void* and functions pointers are incompatible and converting between them is undefined behavior. I've seen compilers give both warnings and errors for such a conversion. The good news is that you can avoid this problem entirely by taking advantage of the fact that any function pointer type can be converted to any other function pointer type and back with well defined behavior (provided you call the function pointer with the correct type):

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include <stdlib.h>
 
unsigned long testval = 1234;
 
/*
Define a generic function pointer 
type for temporary conversion
*/
typedef void (*func_t)(void);
 
/*
Define a null value with the 
generic function pointer type
*/
void null_func(void) { }
 
func_t foundit(void)
{
  fputs("found it!\n", stdout);
  return null_function; /* No cast needed */
}
 
func_t tryit(void)
{
  unsigned long val;
 
  fputs("enter a value/guess->", stdout);
 
  /* Note the format specifier. %u was incorrect */
  fscanf(stdin, "%lu", &val);
 
  if (val == testval)
  {
    return (func_t)foundit; /* Safe cast */
  }
  else
  {
    return (func_t)tryit; /* Safe cast */
  }
}
 
int main()
{
  func_t addr = (func_t)tryit; /* Safe cast */
 
  fprintf(stdout, "ans->%u\n", 1U);
 
  while (addr != null_func) {
    /* Cast back to the correct type before calling */
    addr = ((func_t(*)(void))addr)();
  }
 
  /* A call to exit really isn't necessary from main */
  return 0;
}
#include <stdio.h>
#include <stdlib.h>

unsigned long testval = 1234;

/*
Define a generic function pointer 
type for temporary conversion
*/
typedef void (*func_t)(void);

/*
Define a null value with the 
generic function pointer type
*/
void null_func(void) { }

func_t foundit(void)
{
  fputs("found it!\n", stdout);
  return null_function; /* No cast needed */
}

func_t tryit(void)
{
  unsigned long val;

  fputs("enter a value/guess->", stdout);

  /* Note the format specifier. %u was incorrect */
  fscanf(stdin, "%lu", &val);

  if (val == testval)
  {
    return (func_t)foundit; /* Safe cast */
  }
  else
  {
    return (func_t)tryit; /* Safe cast */
  }
}

int main()
{
  func_t addr = (func_t)tryit; /* Safe cast */

  fprintf(stdout, "ans->%u\n", 1U);

  while (addr != null_func) {
    /* Cast back to the correct type before calling */
    addr = ((func_t(*)(void))addr)();
  }

  /* A call to exit really isn't necessary from main */
  return 0;
}

>But that isn't the problem...
>The problem is when I remove the comments from this line
It might actually be. In my experience, when commenting out random unrelated lines suddenly causes a broken program to work, it's often a result of undefined behavior.

>the code will not work correctly on GCC 4.4.1
>but it will work correctly on GCC 4.3.2, GCC 3.4.5
File a bug report and see what comes of it then.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Nov 8th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

Click to Expand / Collapse Quote originally posted by Narue ...

>No the complier had no problems casting a void pointer to a function..should it?
It might. Technically void* and functions pointers are incompatible and converting between them is undefined behavior.

Could you give an example....

Last edited by gerard4143; Nov 8th, 2009 at 11:05 am.

gerard4143

Reputation Points: 499

Solved Threads: 367

Postaholic

Online

2,197 posts
since Jan 2008

Permalink

Nov 8th, 2009

Re: Could Someone Try Compiling This On A Different Compiler

>Could you give an example....
Your code is an example, my fix for your code is a counter-example. What more do you want? How about a quote from the standard:

Quote originally posted by C99 Section 6.3.2.3 ...

1 A pointer to void may be converted to or from a pointer to any incomplete or object
type. A pointer to any incomplete or object type may be converted to a pointer to void
and back again; the result shall compare equal to the original pointer.

The key terms here are incomplete and object type. An object type is distinct from a function type, and incomplete types are defined as object types that lack size information.

I said "technically" in my original post because even the standard lists this as a common extension:

Quote originally posted by C99 Section J.5.7 ...

1 A pointer to an object or to void may be cast to a pointer to a function, allowing data to
be invoked as a function (6.5.4).
2 A pointer to a function may be cast to a pointer to an object or to void, allowing a
function to be inspected or modified (for example, by a debugger) (6.5.4).

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Page 1
2
Next

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Small C program error

Next Thread in C Forum Timeline: Need Help sorting structures

DaniWeb Message

Cancel Changes

User Name
Password