Count Letter A

Expand Post »

I am currently working on a program that inputs a line from a file, then reads the vowels in the file, next I am going to count the number of letter a within the program.

Below is the program I have done but it is not working. It opens the file, reads the line, closes the file. Next it opens the file, and read the vowels within the file. Next it is suppose to open the file and count the number of letter a.

The line "Hgj a dsfsIwgEfeEw a weUfewUfewIfOO" is the frist line of .txt n the hello.txt is the file.

My void count_a_fnc() part seems to have some problems.
Thanks

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include <string.h>
 
char next;
char *str = "Hgj a dsfsIwgEfeEw a weUfewUfewIfOO";
char *ptr;
FILE *file_ptr;
int count_a=0;
int i;
int a;
int read_vowels;
void read_from_file();
void print_vowels_fnc();
void count_a_fnc();
 
int main(int argc, char *argv[])
{
  read_from_file();
 
  printf("vowels read\n\n");
 
  print_vowels_fnc();
 
  printf("letter a\n\n");
 
  count_a_fnc();
 
  printf("\n\n");
 
  system("PAUSE");	
  return 0;
}  
void read_from_file()
{
file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) printf( "%c", next);
              else break;
 
              //*ptr= fgetc(file_ptr);
              //if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
              //        printf( "%c", next);
 
      }    
      fclose( file_ptr );
  }
}
 
void print_vowels_fnc()
{
file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) 
              {
                       if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
                                printf( "%c", next);
                       if(next == 'A' || next == 'E'|| next == 'I' || next == 'O' || next == 'U')
                                printf( "%c", next);
              }
              else break;
 
              //*ptr= fgetc(file_ptr);
              //if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
              //        printf( "%c", next);
 
      }    
      fclose( file_ptr );
  }
}
 void count_a_fnc()
{file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) 
 
 
      ptr=str;
      for(i=1;i<=strlen(str);i++){
                                  count_a_fnc();
                                  ptr++;
                                  if (*ptr == a);
                                  count_a++;
                                  system ("PAUSE");
                                  }
 
 
 
      }    
      fclose( file_ptr );
  }
}
#include <stdio.h>
#include <string.h>

char next;
char *str = "Hgj a dsfsIwgEfeEw a weUfewUfewIfOO";
char *ptr;
FILE *file_ptr;
int count_a=0;
int i;
int a;
int read_vowels;
void read_from_file();
void print_vowels_fnc();
void count_a_fnc();

int main(int argc, char *argv[])
{
  read_from_file();
  
  printf("vowels read\n\n");
  
  print_vowels_fnc();
  
  printf("letter a\n\n");
  
  count_a_fnc();
  
  printf("\n\n");
  
  system("PAUSE");	
  return 0;
}  
void read_from_file()
{
file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) printf( "%c", next);
              else break;
              
              //*ptr= fgetc(file_ptr);
              //if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
              //        printf( "%c", next);
                
      }    
      fclose( file_ptr );
  }
}

void print_vowels_fnc()
{
file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) 
              {
                       if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
                                printf( "%c", next);
                       if(next == 'A' || next == 'E'|| next == 'I' || next == 'O' || next == 'U')
                                printf( "%c", next);
              }
              else break;
              
              //*ptr= fgetc(file_ptr);
              //if(next == 'a' || next == 'e'|| next == 'i' || next == 'o' || next == 'u')
              //        printf( "%c", next);
                
      }    
      fclose( file_ptr );
  }
}
 void count_a_fnc()
{file_ptr = fopen("Hello.txt","r");
  if( file_ptr !=NULL);
  {
      while(1)
      {
              next = fgetc(file_ptr);
              if (next != EOF) 
              
     
      ptr=str;
      for(i=1;i<=strlen(str);i++){
                                  count_a_fnc();
                                  ptr++;
                                  if (*ptr == a);
                                  count_a++;
                                  system ("PAUSE");
                                  }
                                  
      
                    
      }    
      fclose( file_ptr );
  }
}

Last edited by WaltP; Mar 3rd, 2010 at 2:09 pm. Reason: Added CODE tags -- with all the help about them, how could you miss using them????

Similar Threads

Starting Python in Python
Count letter rate in C++
Error of Letter Frequencies in a Text File in C++
Program to read a line and count occurence of each letter and punctuation in Assembly
Program calculate letter occurence in a sentence in C

homesweethome17

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Mar 2010

Permalink

Mar 3rd, 2010

Re: Count Letter A

There is recursion in your count_a_fnc() function (it is calling itself) with no base case. Did you really want to do that? All you need to do is to read one char at a time just like your print_vowels_fnc() function and instead of checking for vowels, check for 'a', and instead of printing just increment your count_a variable and you are done. Of course you will have to print the final result count_a just before you exit the function.

And yes, please put all your code in between code tags to make it easy to read.

Last edited by shah1248; Mar 3rd, 2010 at 12:25 pm.

shah1248

Reputation Points: 15

Solved Threads: 7

Light Poster

Offline

41 posts
since Mar 2010

Permalink

Mar 3rd, 2010

Re: Count Letter A

It seems to me as if your problem is when you try to call your function within your function. I commented it out and the program no longer freezes, although the count is not correct.

Maybe you can work with this, and get it working the way you want:

C Syntax (Toggle Plain Text)
ptr=str;
for(i=1;i<=strlen(str);i++){                          
//count_a_fnc();
ptr++; //why increment this?  
if (*ptr == 'a'); // added the apostrophe's
count_a++;
}
printf( "%d", count_a); //just to see what your count is...it's not correct though
system ("PAUSE"); //placed outside of loop
ptr=str;
for(i=1;i<=strlen(str);i++){                          
//count_a_fnc();
ptr++; //why increment this?  
if (*ptr == 'a'); // added the apostrophe's
count_a++;
}
printf( "%d", count_a); //just to see what your count is...it's not correct though
system ("PAUSE"); //placed outside of loop

MyrtleTurtle

Reputation Points: 63

Solved Threads: 11

Junior Poster

Offline

100 posts
since Feb 2010

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Check if ESC is pressed

Next Thread in C Forum Timeline: How do I make a variable number pyramid?

DaniWeb Message

Cancel Changes

User Name
Password