Linked List

Expand Post »

Dear All.

I have a small problem with the code attached. I am trying to add an object to a linked list. When I try to compile I am getting an error. For the life of me I cant figure out the error. this is after 5hrs of head wrecking searching. Any help would be greatly appreciated. thx in advance Tim.

Attached Files

christmas2.zip (3.9 KB, 17 views)

Similar Threads

TimC

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

42 posts
since May 2005

Permalink

Nov 30th, 2005

Re: Linked List

Tim,

I only time to look at one file. In Sequence.cpp I found this function. I believe this may cause a problem if the index is not valid.

C Syntax (Toggle Plain Text)
SeqItemType Sequence::retrieve(int index)
{
  if ((index < 1) || (index > size())){
    // can't delete something that isn't there
  }
  ListNode *cur = find(index);
  return cur->item;
}
SeqItemType Sequence::retrieve(int index)
{
  if ((index < 1) || (index > size())){
    // can't delete something that isn't there
  }
  ListNode *cur = find(index);
  return cur->item;
}

If the expression in the if statement is true it will still do the last bit of code, unless you wanted and if-else structure.
The find(index) will return zero if index is not valid. Then when it tries to resolve cur->item, that might give you a problem. Look at your code and see if you are ever returning 0 that will be used in a cur->item context. Check for 0. If it is, return or move on without doing anything.

HyperEngineer

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Apr 2005

Permalink

Nov 30th, 2005

Re: Linked List

One would be the missing semicolon in "Sequence.h":

(Toggle Plain Text)

typedef patient SeqItemType;

Others are things like returning a pointer from a function that is not declared as returning a pointer.

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: need you wise advices...

Next Thread in C Forum Timeline: project question?

DaniWeb Message

Cancel Changes

User Name
Password