Ad:

C Discussion Thread
Unsolved
Views: 3807

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Dec 13th, 2005

Memory Leak?

Expand Post »

So I'm writing a program (MFC) that connects to a server w/ windows sockets (YUCK I know). I left it running as part of an endurance test the other day, and my PC ran out of virtual memory. Odd eh? So I ran it again using task manager and noted that it's taking approx. 5,000k or memory everytime it recives and doesn't release the memory until the program is killed. I assume recieves because the amount of memory it takes up is related to how big

C Syntax (Toggle Plain Text)
char *pBuf = new char[1000025];
char *pBuf = new char[1000025];

is. (See code below) The following is code from the ::OnRecive function in my program.

C Syntax (Toggle Plain Text)
{
	char *pBuf = new char[1000025];// yeah yeah i know it's huge!!
	int iBufSize = 10000024;
	int iRcvd;
	CString strRecvd;
	// Receive the message
	iRcvd = m_sConnectSocket.Receive(pBuf, iBufSize);
	// Did we receive anything?
	if (iRcvd == SOCKET_ERROR)
	{
	}
	else
	{
		// Truncate the end of the message
		pBuf[iRcvd] = NULL;
		// Copy the message to a CString
		strRecvd = pBuf;
		m_pBuf = pBuf;
		m_strOutput = strRecvd;
		// Sync the variables with the controls
//		UpdateData(FALSE);
	}
 
}
{
	char *pBuf = new char[1000025];// yeah yeah i know it's huge!!
	int iBufSize = 10000024;
	int iRcvd;
	CString strRecvd;
	// Receive the message
	iRcvd = m_sConnectSocket.Receive(pBuf, iBufSize);
	// Did we receive anything?
	if (iRcvd == SOCKET_ERROR)
	{
	}
	else
	{
		// Truncate the end of the message
		pBuf[iRcvd] = NULL;
		// Copy the message to a CString
		strRecvd = pBuf;
		m_pBuf = pBuf;
		m_strOutput = strRecvd;
		// Sync the variables with the controls
//		UpdateData(FALSE);
	}

}

So!!! Here in lies the question. Why does it keep taking memory and not releasing it (until the program is killed) and how to I get it to release the memory?

Similar Threads

Can't prevent memory leak in C++
can't find my memory leak in C++
“Windows Virtual Memory Size Too Low�? in XP in Windows NT / 2000 / XP
Constructor and Convertion operator are the same,how to avoid memory leak? in C++

atrusmre

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

64 posts
since Mar 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Because you dont release the memory ? (There is no delete matching the new)... (However most implementations of delete would not actually return the memory to the system anyway, it would just put it in the local free lists)...
*Edit)
If you wanted to allocate lots of memory and be sure to return it to the system you could probably use one winapi function to get you a (several?) fresh page(s), use it and then explicitly return it to the system.

perniciosus

Reputation Points: 29

Solved Threads: 4

Junior Poster in Training

Offline

78 posts
since Nov 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Well perni's solution should work. But why cant you use a normal array like

C Syntax (Toggle Plain Text)
char pBuf = char[1000025]
char pBuf = char[1000025]

? It will cleanup itself as it goes out of scope. Saves you a lot of trouble.

WolfPack

Moderator

Reputation Points: 572

Solved Threads: 115

Mentally Challenged Mod.

Offline

1,559 posts
since Jun 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

I suppose you mean char pBuf[LARGE_INTEGER_VALUE], the usual problem with that is you easily get stack overflow due to restrictive stack memory allocation, even if I doubt you need such a large buffer... then again I'm not sure where that limit goes, and it tends to vary between compilers/operative systems (in unix/linux you can usually change it by using limit (or is it ulimit?)).

perniciosus

Reputation Points: 29

Solved Threads: 4

Junior Poster in Training

Offline

78 posts
since Nov 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Quote originally posted by WolfPack ...

Well perni's solution should work. But why cant you use a normal array like
C Syntax (Toggle Plain Text)
char pBuf = char[1000025]
char pBuf = char[1000025]
? It will cleanup itself as it goes out of scope. Saves you a lot of trouble.

What's the difference between

C Syntax (Toggle Plain Text)
char pBuf = char[1000025];
char pBuf = char[1000025];

and

C Syntax (Toggle Plain Text)
char *pBuf = new char[1000025];
char *pBuf = new char[1000025];

when the second one goes out of scope won't it cleanup itself also?

Side note. I tried changing it to what you suggested and I get a bunch of errors.

As clearification<SP>. When the program receives data, it uses say 5,000k. Next time it recieves data it uses another 5,000k. Now my total memory used is 10,000k. This keeps going until I end the program. As you can see this could cause a problem. Eventually I run out of ram. I'm just wondering why? and how to fix it. :cheesy:

atrusmre

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

64 posts
since Mar 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

As I said char pBuf = char[1000025]; is syntax error and does not mean anything...
char pBuf[10000025]; mean declare as local variable and store on stack
char *pBuf = new char[10000025]; mean declare a (local variable) pointer to allocated memory (that must be explicitly deleted)... you do not delete this memory...
all execution paths must include a delete [] pBuf; or hand it over to some other location that must take responsibility for destruction else you will have a memory leak...

perniciosus

Reputation Points: 29

Solved Threads: 4

Junior Poster in Training

Offline

78 posts
since Nov 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Yeah my bad. I meant

C Syntax (Toggle Plain Text)
char pBuf [1000025];
char pBuf [1000025];

I shouldn't have edited your post on the fly. Sorry about that. It should clear itself when going outof scope.

WolfPack

Moderator

Reputation Points: 572

Solved Threads: 115

Mentally Challenged Mod.

Offline

1,559 posts
since Jun 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Quote originally posted by WolfPack ...

Yeah my bad. I meant
C Syntax (Toggle Plain Text)
char pBuf [1000025];
char pBuf [1000025];
I shouldn't have edited your post on the fly. Sorry about that. It should clear itself when going outof scope.

The only problem with that though is that m_sConnectSocket.Receive only takes ( void *lpBuf, int nBufLen, int nFlags = 0) as arguments. if I do what you suggested I get an exception error

atrusmre

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

64 posts
since Mar 2005

Permalink

Dec 13th, 2005

Re: Memory Leak?

Well I dont think you would get an error if you pass it as

C Syntax (Toggle Plain Text)
m_sConnectSocket.Receive( pBuf , 1000025, nFlags)
m_sConnectSocket.Receive( pBuf , 1000025, nFlags)

. A void* should take any kind of pointer.
If it does still give an exception, try doing a cast.

C Syntax (Toggle Plain Text)
m_sConnectSocket.Receive( (void*)pBuf , 1000025, nFlags)
m_sConnectSocket.Receive( (void*)pBuf , 1000025, nFlags)

WolfPack

Moderator

Reputation Points: 572

Solved Threads: 115

Mentally Challenged Mod.

Offline

1,559 posts
since Jun 2005

Permalink

Dec 14th, 2005

Re: Memory Leak?

Still get an exception error, even if I do it both ways.

atrusmre

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

64 posts
since Mar 2005

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Trying to understand this code???

Next Thread in C Forum Timeline: initializing a hash_set ?

DaniWeb Message

Cancel Changes

User Name
Password