Ad:

C Discussion Thread
Marked Solved
Views: 1877

Nov 21st, 2006

How to work with digits when they are characters in a string

Expand Post »

I'm not sure if my title makes sense. My problem is the following: I input a string and the function in my program is supposed to change every digit (except for 0) it finds in the string to a value -1 of that digit (eg 'er345ut' should be changed to 'er234ut'). It should return the number of switches made (that is not a problem) but what's a good way to make the switches?

I did it this way but there MUST be a much better way to do this! I'm a beginner so please don't use any advanced functions...I've heard of atoi, is that what I'm supposed to use? I don't know how to.

c Syntax (Toggle Plain Text)
#include <stdio.h>
#include <string.h>
int one_less(char *);
main(){
char s[20];
printf("Type string\n");
scanf("%s",&s);
printf("number of changes made is %d\n",one_less(s));
printf("changed string is:\n%s",s);
getchar();
getchar();
}
int one_less(char *a){
int i=0,k=0;
while(a[i]!='\0'){
 if (a[i]>='1' && a[i]<='9')
  k++;
    if (a[i]=='1') a[i]='0';
    else if (a[i]=='2') a[i]='1';          /*making the switches the stupidest possible way*/
    else if (a[i]=='3') a[i]='2';
    else if (a[i]=='4') a[i]='3';
    else if (a[i]=='5') a[i]='4';
    else if (a[i]=='6') a[i]='5';
    else if (a[i]=='7') a[i]='6';
    else if (a[i]=='8') a[i]='7';
    else if (a[i]=='9') a[i]='8';
    i++;
    }
return k;
}
#include <stdio.h>
#include <string.h>
int one_less(char *);
main(){
char s[20];
printf("Type string\n");
scanf("%s",&s);
printf("number of changes made is %d\n",one_less(s));
printf("changed string is:\n%s",s);
getchar();
getchar();
}
int one_less(char *a){
int i=0,k=0;
while(a[i]!='\0'){
 if (a[i]>='1' && a[i]<='9')
  k++;
    if (a[i]=='1') a[i]='0';
    else if (a[i]=='2') a[i]='1';          /*making the switches the stupidest possible way*/
    else if (a[i]=='3') a[i]='2';
    else if (a[i]=='4') a[i]='3';
    else if (a[i]=='5') a[i]='4';
    else if (a[i]=='6') a[i]='5';
    else if (a[i]=='7') a[i]='6';
    else if (a[i]=='8') a[i]='7';
    else if (a[i]=='9') a[i]='8';
    i++;
    }
return k;
}

This program works, but I think my teacher is gonna make me do 100 push-ups for doing it this way. Please help.

Similar Threads

Monsignor

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

6 posts
since Nov 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

With something like this:

c Syntax (Toggle Plain Text)
if ((a[i] > '0') && (a[i] <='9'))
{
   a[i] -= 1;
}
if ((a[i] > '0') && (a[i] <='9'))
{
   a[i] -= 1;
}

In the loop.
One remark about your code. You are not obtaining the string the right way. Read this

Last edited by andor; Nov 21st, 2006 at 1:26 pm.

andor

Reputation Points: 251

Solved Threads: 29

Posting Whiz in Training

Offline

274 posts
since Jun 2005

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

Doesn't work now. When I type a string with no numbers it does what it's supposed to but when I include a digit it just does nothing (the black window stays open but nothing appears). Here's the code of the function now:

c Syntax (Toggle Plain Text)
int one_less(char *a){
int i=0,k=0;
while(a[i]!='\0'){
 if ((a[i]>='1') && (a[i]<='9')){
     a-=1;
        k++;
        }
    i++;
    }
return k;
}
int one_less(char *a){
int i=0,k=0;
while(a[i]!='\0'){
 if ((a[i]>='1') && (a[i]<='9')){
     a-=1;
        k++;
        }
    i++;
    }
return k;
}

What's wrong with it now? And I don't quite understand how you can use 'a-=1' when a is a string. ::shrug::

As for scanf...well, I've been told it's not the best choice, but I'm incredibly thick-headed and intend to use it untill it back-fires.

Monsignor

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

6 posts
since Nov 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

First of all dont use scanf() to obtain the string from user, use [search]fgets( )[/search] which is much safer option. Something like:

c Syntax (Toggle Plain Text)
char buffer[BUFSIZ] = { '\0' } ;
printf( "Enter the string: " ) ;
fgets( buffer, BUFSIZ, stdin ) ;
char buffer[BUFSIZ] = { '\0' } ;
printf( "Enter the string: " ) ;
fgets( buffer, BUFSIZ, stdin ) ;

Also there is an inbuilt function in the header file ctype.h known as [search]isdigit( ) [/search] which returns a non zero value if the given character is a digit character.

In your while loop check for digit character, increment the counter, and scale the result in the range 0 - 9 after subtracting the value with 1.

eg.
'0' - 1 = 9

Quote ...

And I don't quite understand how you can use 'a-=1' when a is a string

a is a character array but a[i] is a character and you can add or subtract from a charcter since they are basically represented as integers ASCII values.

If any doubts repost.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 720

Failure as a human

Offline

8,872 posts
since Jun 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

Click to Expand / Collapse Quote originally posted by ~s.o.s~ ...

a is a character array but a[i] is a character and you can add or subtract from a charcter since they are basically represented as integers ASCII values.

Well exactly. I didn't put a[i] in my code, I just put a. Works OK now. I don't think I can use isdigit because I'm not supposed to decremenet 0.

How is '0' - 1 = 9 ?!

And what if my task was to, say, multiply every digit found by two? How would I do that?

Last edited by Monsignor; Nov 21st, 2006 at 2:18 pm.

Monsignor

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

6 posts
since Nov 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

Click to Expand / Collapse Quote originally posted by Monsignor ...

Well exactly. I didn't put a[i] in my code, I just put a.

Even I know that, I was just clarifying Mr. Andors point.

Quote ...

I don't think I can use isdigit because I'm not supposed to decremenet 0.

What does this mean ?

Quote ...

How is '0' - 1 = 9 ?!

If you encounter 0 in your string, how would you handle it.. surely you cant put -1 ?

Quote ...

And what if my task was to, say, multiply every digit found by two? How would I do that?

But suppose your digit is greater than 4.. then how do you propose to do it since it would then imply making spaces for new digits ?

State your program requirements in more detail.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 720

Failure as a human

Offline

8,872 posts
since Jun 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

You didn't read my first post carefully. The program is supposed to decrement digits 1 through 9, but if it comes across a 0 it's supposed to leave it as it is.

Monsignor

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

6 posts
since Nov 2006

Permalink

Nov 21st, 2006

Re: How to work with digits when they are characters in a string

For multiplication:

c Syntax (Toggle Plain Text)
a[i] = ( a[i] - '0' ) * 2 + '0' ;
a[i] = ( a[i] - '0' ) * 2 + '0' ;

But this would work only for digits from 1 to 4.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 720

Failure as a human

Offline

8,872 posts
since Jun 2006

Permalink

Nov 22nd, 2006

Re: How to work with digits when they are characters in a string

c Syntax (Toggle Plain Text)
#include <stdio.h>
#include <string.h>
 
int one_less(char *);
int main()
{
   char s[20];
   printf("Type string\n");
   scanf("%s", s);
   printf("number of changes made is %d\n",one_less(s));
   printf("changed string is:\n%s",s);
   getchar();
   getchar();
   return 0;
}
 
int one_less(char *a)
{
   int i=0,k=0;
   while(a[i]!='\0')
   {
      if (a[i]>='1' && a[i]<='9')
      {
         a[i] -= 1;
         k++;
      }
      i++;
   }
   return k;
}
#include <stdio.h>
#include <string.h>

int one_less(char *);
int main()
{
   char s[20];
   printf("Type string\n");
   scanf("%s", s);
   printf("number of changes made is %d\n",one_less(s));
   printf("changed string is:\n%s",s);
   getchar();
   getchar();
   return 0;
}

int one_less(char *a)
{
   int i=0,k=0;
   while(a[i]!='\0')
   {
      if (a[i]>='1' && a[i]<='9')
      {
         a[i] -= 1;
         k++;
      }
      i++;
   }
   return k;
}

I don't know but this is working for me. Off course I didn't changed the string obtaining.

andor

Reputation Points: 251

Solved Threads: 29

Posting Whiz in Training

Offline

274 posts
since Jun 2005

Permalink

Nov 22nd, 2006

Re: How to work with digits when they are characters in a string

slight modification to your code which gives the same result

c Syntax (Toggle Plain Text)
 
int one_less(char *a)
{   
   for (int k=0; *a ; a++)
       if (*a >='1' && *a<='9') {(*a)-- ; k ++;} 
   return k;
}
 
int one_less(char *a)
{   
   for (int k=0; *a ; a++)
       if (*a >='1' && *a<='9') {(*a)-- ; k ++;} 
   return k;
}

the_count

Reputation Points: 11

Solved Threads: 1

Newbie Poster

Offline

10 posts
since Nov 2006

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Cant figure this out!

Next Thread in C Forum Timeline: Regular expression matching in a string

DaniWeb Message

Cancel Changes

User Name
Password