Ad:

C Discussion Thread
Unsolved
Views: 8449

Page 1
2
3
4
Next

You are currently viewing page 1 of this multi-page discussion thread

Feb 12th, 2007

Convert to Absolute Values

Expand Post »

I have this program to write thats a guessing game. the user specifies the amount of rounds and only 5 attempts per round is allowed a round is over when the user guesses correctly or the number of attempts are up. A Message is displayed to inform the user whether he/she is cold, hot or warm based on a certain criteria:

C Syntax (Toggle Plain Text)
 
#include <stdio.h> 
#include <stdlib.h>
 
/*Funtion Prototypes*/
 
int genRandom(void);
 
 
int main(void)
 
{
/*Declare variables*/
 
int rounds;
int ranNum;
int guess;
int attempts=5;
int score;
 
 
printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);
 
 
do{ 
  ranNum=genRandom();/*Call random function*/
 
  printf("Your rannum is %d\n", ranNum);
 
  do{
  printf("Guess the value of the random number\n");
  scanf("%d",&guess);
 
 if(guess>100)
  {
   printf("Invalid!!!Your source base must be less than 100\n\n");
 
  }
 
  attempts=attempts-1;
 
 
 if (ranNum==guess)
{
   printf("Congratulations,You are correct!\n"); 
 
}
 
 
if ((ranNum-guess) >40)
{
   printf("You are Cold\a\n");
}
else if (10<=(ranNum-guess)<=40)
{	
   printf("You are Warm\a\n"); 
 
}
else if ((ranNum-guess) < 10)
{
   printf("You are Hot!\a\n");
 
}
  }while(attempts!=0);
 
}while(rounds!=0);
 
 
score=5*(5-attempts);
 
printf("Your score is %d\n", score);
 
}/* end of main*/
 
int genRandom(void)
{
  return rand()%100;
}
#include <stdio.h> 
#include <stdlib.h>

/*Funtion Prototypes*/

int genRandom(void);


int main(void)

{
/*Declare variables*/

int rounds;
int ranNum;
int guess;
int attempts=5;
int score;


printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);

  
do{ 
  ranNum=genRandom();/*Call random function*/

  printf("Your rannum is %d\n", ranNum);

  do{
  printf("Guess the value of the random number\n");
  scanf("%d",&guess);

 if(guess>100)
  {
   printf("Invalid!!!Your source base must be less than 100\n\n");

  }
   
  attempts=attempts-1;


 if (ranNum==guess)
{
   printf("Congratulations,You are correct!\n"); 

}


if ((ranNum-guess) >40)
{
   printf("You are Cold\a\n");
}
else if (10<=(ranNum-guess)<=40)
{	
   printf("You are Warm\a\n"); 

}
else if ((ranNum-guess) < 10)
{
   printf("You are Hot!\a\n");

}
  }while(attempts!=0);

}while(rounds!=0);


score=5*(5-attempts);

printf("Your score is %d\n", score);

}/* end of main*/

int genRandom(void)
{
  return rand()%100;
}

1. How do I work with only absolute or positive values for my criteria (say number is less than guess)
2. I want to break out of the loop when the guess is correct or when the attempts are up.

boujibabe

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

123 posts
since Nov 2004

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

Some points:

To guarantee that a particular integer will always be postive (absolute), declare it as an unsigned int.

You check to see if the value the user entered was larger than 100, but you never checked if it was smaller than 0.

You can use break to jump out of a loop if you need to, although a better way would be simply to keep checking the value of a boolean variable which represents if it's time to exit the loop.

This statement makes no sense:
C Syntax (Toggle Plain Text)
```
if (10<=(ranNum-guess)<=40)
```
if (10<=(ranNum-guess)<=40)
Since you already checked that the difference is smaller than 40, just check that the difference isn't smaller than 10.

Proper code indentation is a code habit to practice. Many editors have a built-in feature, so you don't even have to think about it. And it makes code much easier to read and understand.

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

Click to Expand / Collapse Quote originally posted by joeprogrammer ...

Some points:
To guarantee that a particular integer will always be postive (absolute), declare it as an unsigned int.

[LIST]

what if I typecast it
C Syntax (Toggle Plain Text)
((unsigned int)(ranNum-guess) >40)
((unsigned int)(ranNum-guess) >40)
You can use break to jump out of a loop if you need to, although a better way would be simply to keep checking the value of a boolean variable which represents if it's time to exit the loop.

Do you mean like if (attempts>0=1&&rounds>0=1) ?

Proper code indentation is a code habit to practice. Many editors have a built-in feature, so you don't even have to think about it. And it makes code much easier to read and understand.

I been trying to work on my indentation and I thought I was getting better can you suggest a good code editor that would help?

Thanks.

Last edited by boujibabe; Feb 13th, 2007 at 10:53 am.

boujibabe

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

123 posts
since Nov 2004

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

here is the revised code

C Syntax (Toggle Plain Text)
#include <stdio.h> 
#include <stdlib.h>
 
/*Funtion Prototypes*/
int genRandom(void);
 
int main(void)
 
{
/*Declare variables*/
 
int rounds;
int ranNum;
int guess;
int attempts=5;
int score;
 
 
printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);
do{
ranNum=genRandom();/*Call random function*/
--rounds;
  do{
printf("Guess the value of the random number\n");
scanf("%d",&guess);
--attempts;
 
		if((guess>100)||(guess<0))
		{
		  printf("Invalid!!!your number must less than 100 or more than 0\n\n");
		continue;
		}
 
		if (ranNum==guess)
		{
	      printf("Congratulations,You are correct!\n"); 
		break;
		}
 
		if ((unsigned int)(ranNum-guess) >40)
		{
	      printf("You are Cold\n");
		}
		else if (10<=(unsigned int)(ranNum-guess))
		{	
	      printf("You are Warm\n"); 
		}
		else if ((unsigned int)(ranNum-guess) < 10)
		{
		  printf("You are Hot!\n");
		}
	}while(attempts!=0);
 }while(rounds!=0);
 
score=5*(5-attempts);
 
printf("Your score is %d\n", score);
 
}/* end of main*/
 
int genRandom(void)
{
  return rand()%100;
}
#include <stdio.h> 
#include <stdlib.h>

/*Funtion Prototypes*/
int genRandom(void);

int main(void)

{
/*Declare variables*/

int rounds;
int ranNum;
int guess;
int attempts=5;
int score;


printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);
do{
ranNum=genRandom();/*Call random function*/
--rounds;
  do{
printf("Guess the value of the random number\n");
scanf("%d",&guess);
--attempts;

		if((guess>100)||(guess<0))
		{
		  printf("Invalid!!!your number must less than 100 or more than 0\n\n");
		continue;
		}
   
		if (ranNum==guess)
		{
	      printf("Congratulations,You are correct!\n"); 
		break;
		}
		
		if ((unsigned int)(ranNum-guess) >40)
		{
	      printf("You are Cold\n");
		}
		else if (10<=(unsigned int)(ranNum-guess))
		{	
	      printf("You are Warm\n"); 
		}
		else if ((unsigned int)(ranNum-guess) < 10)
		{
		  printf("You are Hot!\n");
		}
	}while(attempts!=0);
 }while(rounds!=0);

score=5*(5-attempts);

printf("Your score is %d\n", score);

}/* end of main*/

int genRandom(void)
{
  return rand()%100;
}

The score is noncumulative and is suppsed to show at the end of each round

boujibabe

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

123 posts
since Nov 2004

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

You are getting incorrect output since you fail to reset the attempts value to 5 again i.e. at the end of the nested do while loop, set the value of attempts again to 5.

Also it is better to decrement the value of attempts at the end of the second do while loop, only after the successful completion of the loop since you seem to be using continue.

And btw, read this thread for getting a good IDE.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

Thanks a bundle. It works now except when I'm correct I can't break out of the loop and print the score, also It isn't starting another round after the failed attempts.

boujibabe

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

123 posts
since Nov 2004

Permalink

Feb 13th, 2007

Re: Convert to Absolute Values

Click to Expand / Collapse Quote originally posted by boujibabe ...

Thanks a bundle. It works now except when I'm correct I can't break out of the loop and print the score, also It isn't starting another round after the failed attempts.

Hmm... the "break" statement works fine for me, except that you aren't calculating the score correctly. You should calculate the score right after the round finishes, and before you reset the attempts.

Like this:

C Syntax (Toggle Plain Text)
        }while(attempts!=0);
        score+=5*(5-attempts);
        }while(attempts!=0);
        score+=5*(5-attempts);

Notice that I put += instead of just =, since the score is supposed to be accumlative. Which means you're going to have to initalize score at the beginning of your program.

You may want to print a "you failed" message before the round ends so that the user knows that he/she ran out of attempts, and additionally, print out the number of attempts remaining after each guess.

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Feb 14th, 2007

Re: Convert to Absolute Values

Click to Expand / Collapse Quote originally posted by boujibabe ...

I been trying to work on my indentation and I thought I was getting better

Here's a tutorial about code formatting. Concentrate on whitespace as well as indentation. A differnt IDE won't do it all for you, and knowing how to format is extremely important.

WaltP

Moderator

Reputation Points: 3281

Solved Threads: 896

Posting Sage

Offline

7,749 posts
since May 2006

Permalink

Feb 14th, 2007

Re: Convert to Absolute Values

Click to Expand / Collapse Quote originally posted by boujibabe ...

Thanks a bundle. It works now except when I'm correct I can't break out of the loop and print the score, also It isn't starting another round after the failed attempts.

Post the updated code so I can see what you have come up with...

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Permalink

Feb 15th, 2007

Re: Convert to Absolute Values

C Syntax (Toggle Plain Text)
#include <stdio.h> 
#include <stdlib.h>
 
/*Funtion Prototypes*/
int genRandom(void);
 
int main(void)
 
{
/*Declare variables*/
 
int rounds;
int ranNum;
int guess;
int attempts=5;
int score;
 
 
printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);
do{
ranNum=genRandom();/*Call random function*/
--rounds;
  do{
printf("Guess the value of the random number\n");
scanf("%d",&guess);
 
 
		if((guess>100)||(guess<0))
		{
		  printf("Invalid!!!your number must less than 100 or more than 0\n\n");
		continue;
		}
 
		if (ranNum==guess)
		{
	      printf("Congratulations,You are correct!\n"); 
		break;
		}
 
		if ((unsigned int)(ranNum-guess) >40)
		{
	      printf("You are Cold\n");
		}
		else if (10<=(unsigned int)(ranNum-guess))
		{	
	      printf("You are Warm\n"); 
		}
		else if ((unsigned int)(ranNum-guess) < 10)
		{
		  printf("You are Hot!\n");
		}
		--attempts;
	}while(attempts!=0);
 
	score+=5*(5-attempts);
  attempts=5;
 
 }while(rounds!=0);
 
printf("Your score is %d\n", score);
 
}/* end of main*/
 
int genRandom(void)
{
  return rand()%100;
}
#include <stdio.h> 
#include <stdlib.h>

/*Funtion Prototypes*/
int genRandom(void);

int main(void)

{
/*Declare variables*/

int rounds;
int ranNum;
int guess;
int attempts=5;
int score;


printf("\nEnter the desired number of rounds\n");
scanf("%d",&rounds);
do{
ranNum=genRandom();/*Call random function*/
--rounds;
  do{
printf("Guess the value of the random number\n");
scanf("%d",&guess);


		if((guess>100)||(guess<0))
		{
		  printf("Invalid!!!your number must less than 100 or more than 0\n\n");
		continue;
		}
   
		if (ranNum==guess)
		{
	      printf("Congratulations,You are correct!\n"); 
		break;
		}
		
		if ((unsigned int)(ranNum-guess) >40)
		{
	      printf("You are Cold\n");
		}
		else if (10<=(unsigned int)(ranNum-guess))
		{	
	      printf("You are Warm\n"); 
		}
		else if ((unsigned int)(ranNum-guess) < 10)
		{
		  printf("You are Hot!\n");
		}
		--attempts;
	}while(attempts!=0);

	score+=5*(5-attempts);
  attempts=5;

 }while(rounds!=0);

printf("Your score is %d\n", score);

}/* end of main*/

int genRandom(void)
{
  return rand()%100;
}

Now I'm going on infinitely instead of breaking after five attempts. A noncumulative score has to be displayed at the end of each round but once the rounds are up a cumulative score is then displayed.

boujibabe

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

123 posts
since Nov 2004

Page 1
2
3
4
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: interfacing et al

Next Thread in C Forum Timeline: how do u find prime numbers in an array

DaniWeb Message

Cancel Changes

User Name
Password