Ad:

C Discussion Thread
Unsolved
Views: 3265

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Mar 21st, 2007

passing data from one function to another in C

Expand Post »

I got this code (written when sleepy, sorry for lack of "expertness")

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include<time.h>
int card1; int card2; int card3;
int total;
int other;
srand(time(NULL));
card1=(rand()%22)+1;
card2=(rand()%22)+1;
other=(rand()%22)+1;
total=card1+card2;
int main()
{
 
 printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");
 
 printf("Your cards are: %d and %d\n", card1, card2);
 printf("total is: %d\n", total);
 
 if(total<21)
 { turn(); }
 
 else if (total>21);
 { printf("BUST! play again?\n"); }
return 0;
}
#include <stdio.h>
#include<time.h>
int card1; int card2; int card3;
int total;
int other;
srand(time(NULL));
card1=(rand()%22)+1;
card2=(rand()%22)+1;
other=(rand()%22)+1;
total=card1+card2;
int main()
{

 printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");

 printf("Your cards are: %d and %d\n", card1, card2);
 printf("total is: %d\n", total);
 
 if(total<21)
 { turn(); }
 
 else if (total>21);
 { printf("BUST! play again?\n"); }
return 0;
}

C Syntax (Toggle Plain Text)
#include<stdio.h>
void turn();
void turn()
{ char ans;
 printf("Twist or bust (t/b)\n");
 ans = getchar();
 switch(ans) 
 { case 't' : draw(); break;
  case 'b' : neg(); break;
 }
}
#include<stdio.h>
void turn();
void turn()
{ char ans;
 printf("Twist or bust (t/b)\n");
 ans = getchar();
 switch(ans) 
 { case 't' : draw(); break;
  case 'b' : neg(); break;
 }
}

C Syntax (Toggle Plain Text)
#include <stdio.h>
void neg();
void neg()
{
 if(total > other)
 { printf("you won! play again?\n"); } 
 else if (other > total)
 {printf("damn nice try. play again?\n"); }
}
#include <stdio.h>
void neg();
void neg()
{
 if(total > other)
 { printf("you won! play again?\n"); } 
 else if (other > total)
 {printf("damn nice try. play again?\n"); }
}

C Syntax (Toggle Plain Text)
#include<stdio.h>
void draw();
void draw()
{
 srand(time(NULL));
card3=(rand()%22)+1;
 total+=card3;
}
#include<stdio.h>
void draw();
void draw()
{
 srand(time(NULL));
card3=(rand()%22)+1;
 total+=card3;
}

it's a card game (twist or bust). so two random numbers are drawn, if they're over 21, you lose, under and you can take another card. if the three cards are over 21 you lose, if not anohter card.. so the total is always changing, how can i pass the value of "total" between the functions? i know there's a way in java placing the variable name in the () of the method, (well i think. it didn't work but i'm new at all of this). any pointers would be appriciated, but like i said, sleepy when i wrote it

Similar Threads

Passing data from forms from one page to another in JavaScript / DHTML / AJAX
Please help with passing data from one form to another form in VB.NET
Passing data from datagridview to textboxes in VB.NET
Passing a matrix from main function to user defined function. in C++
need halp passing array data in C#

hbk619

Reputation Points: 273

Solved Threads: 8

Master Poster

Offline

733 posts
since Oct 2006

Permalink

Mar 21st, 2007

Re: passing data from one function to another in C

Use parameters to pass data between functions.

For example:

c Syntax (Toggle Plain Text)
void myFunction(int amount);
 
// etc.
 
    myFunction(aNumberUserEntered);
}
 
void myFunction(int amount) {
 
    // 'amount' contains whatever was passed inside the ()
    // blah blah
}
void myFunction(int amount);

// etc.

    myFunction(aNumberUserEntered);
}

void myFunction(int amount) {

    // 'amount' contains whatever was passed inside the ()
    // blah blah
}

A few problems with your code:

When splitting up your source files, create a .h that contains ONLY prototypes -- no actual function definitions, those go in the .cpp files
Try to avoid the use of globals in your program, like you did before main(). Whenever possible, pass needed data between functions. It's much easier to track down errors
You're going to have potential problems with getchar because you aren't removing the newline left behind

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

thanks, i moved the variables, and put everything into one files so it looks like this:

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include<time.h>
 
 
int main()
{
 
int card1; int card2; int card3;
int total;
int other;
 
srand(time(NULL));
card1=(rand()%22)+1;
card2=(rand()%22)+1;
other=(rand()%22)+1;
 
total=card1+card2;
 
 
	printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");
 
 
	printf("Your cards are: %d and %d\n", card1, card2);
 
	printf("total is: %d\n", total);
 
	if(total<21)
	{ turn(total, other); }
 
	else if (total>21);
	{ printf("BUST! play again?\n"); }
 
return 0;
}
 
void turn(int total, int other);
 
void turn(int total, int other)
{	char ans;
	printf("Twist or bust (t/b)\n");
	ans = getchar();
while (getchar() != '\n');
 
 
 
	switch(ans)	
	{	case 't' : draw(total); break;
		case 'b' : neg(total, other); break;
	}
 
}
 
 
 
void draw(int total);
 
void draw(int total)
{
	srand(time(NULL));
int card3=(rand()%22)+1;
 
	total+=card3;
total=(int) total;
 
/*will do switch for play again*/
 
}
 
 
 
void neg(int total, int other);
 
void neg(int total, int other)
{
	if(total > other)
	{ printf("you won! play again?\n"); } 
 
	else if (other > total)
	{printf("damn nice try. play again?\n"); }
/*going to do a switch block here linking back to main()*/
}
#include <stdio.h>
#include<time.h>


int main()
{

int card1; int card2; int card3;
int total;
int other;

srand(time(NULL));
card1=(rand()%22)+1;
card2=(rand()%22)+1;
other=(rand()%22)+1;

total=card1+card2;


	printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");


	printf("Your cards are: %d and %d\n", card1, card2);

	printf("total is: %d\n", total);
	
	if(total<21)
	{ turn(total, other); }
	
	else if (total>21);
	{ printf("BUST! play again?\n"); }

return 0;
}

void turn(int total, int other);

void turn(int total, int other)
{	char ans;
	printf("Twist or bust (t/b)\n");
	ans = getchar();
while (getchar() != '\n');



	switch(ans)	
	{	case 't' : draw(total); break;
		case 'b' : neg(total, other); break;
	}

}



void draw(int total);

void draw(int total)
{
	srand(time(NULL));
int card3=(rand()%22)+1;

	total+=card3;
total=(int) total;

/*will do switch for play again*/

}



void neg(int total, int other);

void neg(int total, int other)
{
	if(total > other)
	{ printf("you won! play again?\n"); } 

	else if (other > total)
	{printf("damn nice try. play again?\n"); }
/*going to do a switch block here linking back to main()*/
}

when i compile that i get these errors:

main2.c:36: error: conflicting types for 'turn'
main2.c:28: error: previous implicit declaration of 'turn' was here
main2.c:55: error:conflicting types for 'draw'
main2.c:47: error: previous implicit declaration of 'draw' was here
main2.c:71: error: conflicting types for 'neg'
main2.c:48: error: previous implicit declaration of 'neg' was here

what does that mean?

hbk619

Reputation Points: 273

Solved Threads: 8

Master Poster

Offline

733 posts
since Oct 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

Click to Expand / Collapse Quote originally posted by hbk619 ...

C Syntax (Toggle Plain Text)
 
void turn(int total, int other);
void draw(int total);
void neg(int total, int other);
void turn(int total, int other); void draw(int total); void neg(int total, int other);

These prototypes should be before the main() function or in another head of file included, so the compiler can see what are they.
Also the int total and int other that you wrote inside each function are
different variables with the same name. When you pass those as a
parameter to a function you are creating a copy with the same value, if that value is the one being passed.

Just because it has the same name doesn't mean are the same variables.

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

I moved those three lines an it worked! except the first two numbers totaled 23 so it went straight out.. guess i should get to work on the switch statements eh? thanks for the help

Aia, a copy is being passed, that makes sense. so the total in main is total(copy1), that gets sent to turn but as total( copy2). So if i sent it back to the main (for the if>21 evaluation) would it be total(copy1) or total(copy2)thats evaluated?

C Syntax (Toggle Plain Text)
#include <stdio.h>
#include<time.h>
 
void turn(int total, int other);
void draw(int total, int other);
void neg(int total, int other);
void eval(int total, int other);
int main()
{
int card1; int card2; int card3;
int total;
int other;
srand(time(NULL));
card1=(rand()%13)+1;
card2=(rand()%13)+1;
other=(rand()%13)+1;
total=card1+card2;
 
 printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");
 
 printf("Your cards are: %d and %d\n", card1, card2);
 printf("total is: %d\n", total);
 
 eval(total, other);
 
return 0;
}
 
void eval(int total, int other)
{ char again;
 if(total<21)
 { turn(total, other); }
 
 if (total>21);
 { printf("BUST! play again?\n"); }
 again = getchar();
while (getchar() != '\n');
 switch(again)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }
}
 
void turn(int total, int other)
{ char ans;
 printf("Twist or bust (t/b)\n");
 ans = getchar();
while (getchar() != '\n');
 
 switch(ans) 
 { case 't' : draw(total, other); break;
  case 'b' : neg(total, other); break;
 }
}
void draw(int total, int other)
{
 srand(time(NULL));
int card3=(rand()%13)+1;
printf("next card is: %d\n", card3);
 total+=card3; printf("new total: %d\n", total);
total=(int) total; eval(total, other);
}
 
 
void neg(int total, int other)
{ char win, lose;
 
 if(total > other)
 { printf("Opponents cards: %d\n", other);
  printf("you won! play again?\n");  
win = getchar();
while (getchar() != '\n');
 
switch(win)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }}
 
 else if (other > total)
 {printf("Opponents cards: %d\n", other);
  printf("damn nice try. play again?\n"); 
 
lose = getchar();
while (getchar() != '\n');
 
switch(lose)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }}
}
#include <stdio.h>
#include<time.h>

void turn(int total, int other);
void draw(int total, int other);
void neg(int total, int other);
void eval(int total, int other);
int main()
{
int card1; int card2; int card3;
int total;
int other;
srand(time(NULL));
card1=(rand()%13)+1;
card2=(rand()%13)+1;
other=(rand()%13)+1;
total=card1+card2;

 printf("Hey, welcome to HBK's Twist or bust game. Lets begin\n");

 printf("Your cards are: %d and %d\n", card1, card2);
 printf("total is: %d\n", total);
 
 eval(total, other);

return 0;
}

void eval(int total, int other)
{ char again;
 if(total<21)
 { turn(total, other); }
 
 if (total>21);
 { printf("BUST! play again?\n"); }
 again = getchar();
while (getchar() != '\n');
 switch(again)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }
}

void turn(int total, int other)
{ char ans;
 printf("Twist or bust (t/b)\n");
 ans = getchar();
while (getchar() != '\n');
 
 switch(ans) 
 { case 't' : draw(total, other); break;
  case 'b' : neg(total, other); break;
 }
}
void draw(int total, int other)
{
 srand(time(NULL));
int card3=(rand()%13)+1;
printf("next card is: %d\n", card3);
 total+=card3; printf("new total: %d\n", total);
total=(int) total; eval(total, other);
}
 
 
void neg(int total, int other)
{ char win, lose;

 if(total > other)
 { printf("Opponents cards: %d\n", other);
  printf("you won! play again?\n");  
win = getchar();
while (getchar() != '\n');

switch(win)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }}
 
 else if (other > total)
 {printf("Opponents cards: %d\n", other);
  printf("damn nice try. play again?\n"); 
 
lose = getchar();
while (getchar() != '\n');

switch(lose)
 { case 'y' : main(); break;
  case 'n' : printf("ok, see ya!\n"); break;
 }}
}

thats the new one. here's a game:

Hey, welcome to HBK's Twist or bust game. Lets begin
Your cards are: 3 and 5
total: 8
Twist or bust? (t\b):
t
next card is: 10
new total: 18
BUST! play again?
n
ok, see ya!
BUST! play again?
n
ok, see ya!
BUST! play again?

It got stuck in a loop :-\ . if i don't twist and say no. then it exits as it should. why does it jump back up to the eval function?

now it's getting interesting :-D

Last edited by hbk619; Mar 22nd, 2007 at 1:55 pm.

hbk619

Reputation Points: 273

Solved Threads: 8

Master Poster

Offline

733 posts
since Oct 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

Click to Expand / Collapse Quote originally posted by hbk619 ...

Aia, a copy is being passed, that makes sense. so the total in main is total(copy1), that gets sent to turn but as total( copy2). So if i sent it back to the main (for the if>21 evaluation) would it be total(copy1) or total(copy2)thats evaluated?

No my friend. The total being evaluated in main is not being changed
at all by the functions because you are not returning any value from
the function. So actually, nothing it is send back to main.

I am bad explaining these in words, so I'll give you this little example
and hopefully it would help to understand it.

C Syntax (Toggle Plain Text)
#include <stdio.h>
 
/* function not returning a value */
void double_not(int num)
{
    num *= num;    /* integer is being doubled, but nothing is returned */
}
 
/* same function returning a value */
int double_it(int num) /* a integer is being passed */
{
    return num *= num; /* return that integer doubled */
}
 
int main(void)
{
    int number = 2;
 
    printf("What's in number?: %d\n", number);
 
    double_not(number);
 
    printf("What's in number after double_not function?: %d\n", number);
 
    number = double_it(number); /* number is being here modified */
    printf("What's in number after double_it function?: %d\n", number);
 
    getchar();
    return 0;
}
#include <stdio.h>

/* function not returning a value */
void double_not(int num)
{
    num *= num;    /* integer is being doubled, but nothing is returned */
}

/* same function returning a value */
int double_it(int num) /* a integer is being passed */
{
    return num *= num; /* return that integer doubled */
}

int main(void)
{
    int number = 2;
    
    printf("What's in number?: %d\n", number);

    double_not(number);

    printf("What's in number after double_not function?: %d\n", number);
    
    number = double_it(number); /* number is being here modified */
    printf("What's in number after double_it function?: %d\n", number);
    
    getchar();
    return 0;
}

To avoid confution, I don't like to give the same variable names passed as parameters to functions

Last edited by Aia; Mar 22nd, 2007 at 3:32 pm.

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

Simply said, in pass by value, a copy of the value of the variable is paseed to the function while the original variable remains unchanged.

c Syntax (Toggle Plain Text)
void doubleValue (int i)
{
    i = i * 2;
    printf ("\ni inside function is %d", i);
}
 
int main (void)
{
    int i = 9;
    printf ("\ni before function call is %d", i);
    doubleValue (i);
    printf ("\ni after function call  is %d",i);    
 
    getchar ();
    return 0;
}
void doubleValue (int i)
{
    i = i * 2;
    printf ("\ni inside function is %d", i);
}

int main (void)
{
    int i = 9;
    printf ("\ni before function call is %d", i);
    doubleValue (i);
    printf ("\ni after function call  is %d",i);    

    getchar ();
    return 0;
}

Run the above code and you would understand the function has its own copy of the variable "i". I used the same variables so that you would know they are not the same.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

ok, that makes sense. so i need to use the return keyword to change the original value (up date it)

C Syntax (Toggle Plain Text)
int draw(int total, int other)
{
 srand(time(NULL));
int card3=(rand()%13)+1;
printf("next card is: %d\n", card3);
 total+=card3; printf("new total: %d\n", total);
total=(int) total; return total; eval(total, other);
}
int draw(int total, int other)
{
 srand(time(NULL));
int card3=(rand()%13)+1;
printf("next card is: %d\n", card3);
 total+=card3; printf("new total: %d\n", total);
total=(int) total; return total; eval(total, other);
}

like that? will that mean the total in eval function (in my previous post) is updated? .. except apparently not because the total for one go is 15, which is less than 21 but it goes to BUST! play again?

Last edited by hbk619; Mar 22nd, 2007 at 5:00 pm. Reason: changed coding

hbk619

Reputation Points: 273

Solved Threads: 8

Master Poster

Offline

733 posts
since Oct 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

Don't know what this line's supposed to do:

c Syntax (Toggle Plain Text)
total=(int) total;
total=(int) total;

But whatever.

>will that mean the total in eval function (in my previous post) is updated?
Only if you assign the return value to a variable, eg.

c Syntax (Toggle Plain Text)
    // ...
    total = draw(blah, blah);
}
    // ...
    total = draw(blah, blah);
}

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 22nd, 2007

Re: passing data from one function to another in C

hbk619 your code is getting very confusing right now. And very hard
to read because is not following a proper format. Read these sugestions about formating.

Also use tags when you post your code. For example, for C you write
[code=c]at the beginning, and end of your c code[/code]
For C++ you write
[code=cplusplus]at the start of your C++ code, and end of it [/code]

Aia

Reputation Points: 2224

Solved Threads: 218

Nearly a Posting Maven

Offline

2,304 posts
since Dec 2006

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: c and argv[]

Next Thread in C Forum Timeline: Linked List

DaniWeb Message

Cancel Changes

User Name
Password