Ad:

C Discussion Thread
Unsolved
Views: 3367

Nov 2nd, 2007

Some issues with #define "string" and the write function (unix socket related).

Expand Post »

I am writing a server function and an error message is defined as:

#define UNKNOWN "Unknown"

I have a function:

C Syntax (Toggle Plain Text)
void search(int sockfd)  {
 
     FILE *file;
     char arg1[MAXLINE], arg2[MAXLINE], title[MAXLINE], line[MAXLINE];
 
     file = Fopen (PATH, "r");
 
     while (true) {
 
           if (Readline(sockfd, title, MAXLINE) == 0) return;
 
           Fgets (line, MAXLINE, file);
           sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
 
           while (strcasecmp(title, arg1)!=0 && !feof(file))  {
 
                 Fgets (line, MAXLINE, file);
                 sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
 
                 }
 
           if (strcasecmp(title, arg1)==0)
           Writen(sockfd, arg2, strlen(arg2));
 
           else
           Writen(sockfd, UNKNOWN, strlen(UNKNOWN));
 
           rewind(file);
 
           }
 
           Fclose(file);
 
}
void search(int sockfd)  {
     
     FILE *file;
     char arg1[MAXLINE], arg2[MAXLINE], title[MAXLINE], line[MAXLINE];
     
     file = Fopen (PATH, "r");
     
     while (true) {
           
           if (Readline(sockfd, title, MAXLINE) == 0) return;
           
           Fgets (line, MAXLINE, file);
           sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
           
           while (strcasecmp(title, arg1)!=0 && !feof(file))  {
                 
                 Fgets (line, MAXLINE, file);
                 sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
                 
                 }
                 
           if (strcasecmp(title, arg1)==0)
           Writen(sockfd, arg2, strlen(arg2));
           
           else
           Writen(sockfd, UNKNOWN, strlen(UNKNOWN));
           
           rewind(file);
           
           }
          
           Fclose(file);
           
}

The problem is with the following statement:

C Syntax (Toggle Plain Text)
Writen(sockfd, UNKNOWN, strlen(UNKNOWN));
Writen(sockfd, UNKNOWN, strlen(UNKNOWN));

If I put any of the c-strings I use above in there, it will write everything correctly. With UNKNOWN, nothing happens.... it just keeps asking for more input.

By the way, this function works just as expected if implemented standalone this way:

C Syntax (Toggle Plain Text)
int main ()  {
 
     FILE *file;
     char arg1[MAXLINE], arg2[MAXLINE], title[MAXLINE], line[MAXLINE];
 
     file = Fopen (PATH, "r");
 
     while (true) {
 
           if (gets (title) == 0) return;
 
           Fgets (line, MAXLINE, file);
           sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
 
           while (strcasecmp(title, arg1)!=0 && !feof(file))  {
 
                 Fgets (line, MAXLINE, file);
                 sscanf (line, "%[^:]:%[^:]:", arg1, arg2);
 
                 }
 
           if (strcasecmp(title, arg1)==0)
           printf ("%s", arg2);
 
           else {
           printf("%s", UNKNOWN);
           }
 
           rewind(file);
 
           }
 
           Fclose(file);
 
exit(0);
}
int main ()  {

     FILE *file;
     char arg1[MAXLINE], arg2[MAXLINE], title[MAXLINE], line[MAXLINE];

     file = Fopen (PATH, "r");

     while (true) {

           if (gets (title) == 0) return;

           Fgets (line, MAXLINE, file);
           sscanf (line, "%[^:]:%[^:]:", arg1, arg2);

           while (strcasecmp(title, arg1)!=0 && !feof(file))  {

                 Fgets (line, MAXLINE, file);
                 sscanf (line, "%[^:]:%[^:]:", arg1, arg2);

                 }

           if (strcasecmp(title, arg1)==0)
           printf ("%s", arg2);

           else {
           printf("%s", UNKNOWN);
           }

           rewind(file);

           }

           Fclose(file);

exit(0);
}

Any ideas?
Thanks.

Last edited by Ratte; Nov 2nd, 2007 at 2:36 am.

Similar Threads

JAVA Expert Help me.. Write a function that accepts an array of integers and returns in Java
Help using "include" inside of "echo" in PHP
char * = "string" and strcpy = SegFault? in C++
my #include <string> wont make "string" bold in C++
google "keyword" question in Search Engine Optimization

Ratte

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

38 posts
since Oct 2007

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

most probably because you can't do strlen(UNKNOWN). It's like saying strlen("hello") which obviously ain't gonna work.

Why not just initialise it properly? If you don't know how, you're way out of your depths.

Also Fgets why the capitalization? gets why?
feof Again why? I could go on.

Last edited by iamthwee; Nov 2nd, 2007 at 4:32 pm.

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

>It's like saying strlen("hello") which obviously ain't gonna work.
And why is that?

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

Click to Expand / Collapse Quote originally posted by Narue ...

>It's like saying strlen("hello") which obviously ain't gonna work.
And why is that?

Missing a semicolon.

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

Actually, you can do strlen(UNKNOWN). Give it a try and see that it works.

C Syntax (Toggle Plain Text)
#define UNKNOWN "Unknown"
#include <stdio.h>
 
 
int main ()
{
 
printf ("%d", strlen(UNKNOWN));
 
}
#define UNKNOWN "Unknown"
#include <stdio.h>


int main ()
{

printf ("%d", strlen(UNKNOWN));
    
}

The above program prints 7.

I do it with #DEFINE because that is how the instructor wants it. If I did it otherwise, I would get penalized. It already happened before.

Fgets is because I use a wrapper function for fgets (also required). This code is all based on stuff in a UNIX socket programming book.

I just found out what the problem was. The client uses Readline (sort of an fgets) for reading the server output... so everything that I send from the server has to be \n terminated. Yes, I know. I also can't beleive how much time I wasted on something this trivial.

Ratte

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

38 posts
since Oct 2007

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

I dunno, I don't really use c. I don't know what you mean by add a newline at the string. But glad you sorted it.

Last edited by iamthwee; Nov 2nd, 2007 at 4:54 pm.

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

fgets reads until x (size of buffer) amount of characters are read OR a newline character is encountered. In my case, the buffer was quite large, so the client's fgets was waiting till either the buffer was full, or a newline character was sent.... and since I wasn't sending a \n, it kept waiting. That was the problem.

Ratte

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

38 posts
since Oct 2007

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

>Missing a semicolon.
Do you practice being obtuse?

>I dunno, I don't really use c.
Then maybe you shouldn't be trying to answer questions about C.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Nov 2nd, 2007

Re: Some issues with #define "string" and the write function (unix socket related).

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C Forum Timeline: Copy argv to string in C(newbie question)

Next Thread in C Forum Timeline: Need help writing a wrapper function for fork() and signal functions.

DaniWeb Message

Cancel Changes

User Name
Password