Ad:

C++ Discussion Thread
Unsolved
Views: 3276

Sep 17th, 2004

Problem with pointers

Expand Post »

I am storing the address of an Object in more than one entry in a vector;
At the time of Deallocating the memory, I am retriving the Pointers one by one and Deleting it; The problem is that say &Obj is stored at indexes 1, 3;
delete works first time; But it fails at 3rd index since it has been deleted in the first iteration itself; Could any body help me out to solve this ;
Here is the Sample Code;

class A{//...};
typedef map<int, A*> Type_t;
Type_t MyMap;
A *p = new A();
MyMap[1] = p;
MyMap[2] = p;
MyMap[3] = p;
//...
A* dPtr;
for( Type_t::iterator iter = MyMap.begin(); iter != MyMap.end(); iter++)
{
dPtr = (*iter).second;
delete dptr; //Works fine for the first time, But fails from 2nd Iteration
}
-Narayan

Similar Threads

Problem with pointers in C++
The Problem with Pointers in C++
swapping with pointers ... in C
Converting Struct to class lost with pointers in C++
Problem About Pointers in C++

Narayan

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since Sep 2004

Permalink

Sep 17th, 2004

Re: Problem with pointers

Maybe something like this?

C++ Syntax (Toggle Plain Text)
	  dptr = iter->second;
 	  if(dptr != NULL)
 	  {
 		 delete dptr;
 		 iter->second = NULL;
 	  }
	  dptr = iter->second;
 	  if(dptr != NULL)
 	  {
 		 delete dptr;
 		 iter->second = NULL;
 	  }

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

Permalink

Sep 22nd, 2004

Re: Problem with pointers

I tried this also, but still i am facing the same problem.

Narayan

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since Sep 2004

Permalink

Sep 22nd, 2004

Re: Problem with pointers

Quote originally posted by Narayan ...

I tried this also, but still i am facing the same problem.

Quote originally posted by Narayan ...

C++ Syntax (Toggle Plain Text)
MyMap[1] = p;
 MyMap[2] = p;
 MyMap[3] = p;
MyMap[1] = p; MyMap[2] = p; MyMap[3] = p;

Why start at 1 when element 0 is the first element?

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

Permalink

Sep 22nd, 2004

Re: Problem with pointers

Take a look at this.Maybe It can give you some ideas.

C++ Syntax (Toggle Plain Text)
#include <vector>
#include <iostream>
#include <algorithm>
#include <boost/shared_ptr.hpp>
 
struct Foo
{ 
  Foo( int _x ) : x(_x) {}
  ~Foo() { std::cout << "Destructing a Foo with x=" << x << "\n"; }
  int x;
  /* ... */
};
 
typedef boost::shared_ptr<Foo> FooPtr;
 
struct FooPtrOps
{
  bool operator()( const FooPtr & a, const FooPtr & b )
    { return a->x < b->x; }
  void operator()( const FooPtr & a )
    { std::cout << " " << a->x; }
};
 
int main()
{
  std::vector<FooPtr> foo_vector;
 
  foo_vector.push_back( FooPtr(new Foo(3)) );
  foo_vector.push_back( FooPtr(new Foo(2)) );
  foo_vector.push_back( FooPtr(new Foo(1)) );
 
  std::cout << "Original foo_vector:";
  std::for_each( foo_vector.begin(), foo_vector.end(), FooPtrOps() );
  std::cout << "\n";
 
  std::sort( foo_vector.begin(), foo_vector.end(), FooPtrOps() );
 
  std::cout << "Sorted foo_vector:";
  std::for_each( foo_vector.begin(), foo_vector.end(), FooPtrOps() );
  std::cout << "\n";
  return 0;
}
#include <vector>
#include <iostream>
#include <algorithm>
#include <boost/shared_ptr.hpp>

struct Foo
{ 
  Foo( int _x ) : x(_x) {}
  ~Foo() { std::cout << "Destructing a Foo with x=" << x << "\n"; }
  int x;
  /* ... */
};

typedef boost::shared_ptr<Foo> FooPtr;

struct FooPtrOps
{
  bool operator()( const FooPtr & a, const FooPtr & b )
    { return a->x < b->x; }
  void operator()( const FooPtr & a )
    { std::cout << " " << a->x; }
};

int main()
{
  std::vector<FooPtr> foo_vector;

  foo_vector.push_back( FooPtr(new Foo(3)) );
  foo_vector.push_back( FooPtr(new Foo(2)) );
  foo_vector.push_back( FooPtr(new Foo(1)) );

  std::cout << "Original foo_vector:";
  std::for_each( foo_vector.begin(), foo_vector.end(), FooPtrOps() );
  std::cout << "\n";

  std::sort( foo_vector.begin(), foo_vector.end(), FooPtrOps() );

  std::cout << "Sorted foo_vector:";
  std::for_each( foo_vector.begin(), foo_vector.end(), FooPtrOps() );
  std::cout << "\n";
  return 0;
}

big146

Reputation Points: 14

Solved Threads: 0

Newbie Poster

Offline

18 posts
since Jul 2004

Permalink

Oct 5th, 2004

Re: Problem with pointers

could you help me in some questions

samar

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Oct 2004

Permalink

Oct 5th, 2004

Re: Problem with pointers

>could you help me in some questions
If you bother to ask them, and in a separate thread unless they are directly related to the original question asked in this thread or one of the replies.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: State abbreviations

Next Thread in C++ Forum Timeline: Help Using For Loop To Display Ordered Numbers

DaniWeb Message

Cancel Changes

User Name
Password