Ad:

C++ Discussion Thread
Marked Solved
Views: 2080

You are currently viewing page 2 of this multi-page discussion thread; Jump to the first page

Mar 21st, 2008

Re: Object compiler errors

one die header:

C++ Syntax (Toggle Plain Text)
#ifndef ONEDIE_H
#define ONEDIE_H
 
class onedie
{
	public:
		void rollit();
		int getroll();
 
	private:
		int result;
};
 
#endif
#ifndef ONEDIE_H
#define ONEDIE_H

class onedie
{
	public:
		void rollit();
		int getroll();

	private:
		int result;
};

#endif

threedice header:

C++ Syntax (Toggle Plain Text)
#ifndef THREEDICE_H
#define THREEDICE_H
 
class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
 
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};
 
#endif
#ifndef THREEDICE_H
#define THREEDICE_H

class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
		
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};

#endif

noclass header:

C++ Syntax (Toggle Plain Text)
#ifndef NOCLASS_H
#define NOCLASS_H
 
void statistics (int rolls[],int rollsize, int allresults[]);  //prototype given by instructor
 
//display function here
 
#endif
#ifndef NOCLASS_H
#define NOCLASS_H

void statistics (int rolls[],int rollsize, int allresults[]);  //prototype given by instructor

//display function here

#endif

onedie.cpp

C++ Syntax (Toggle Plain Text)
#include "onedie.h"
#include <iostream>
#include <cstdlib>
#include <ctime>
 
using namespace std;
 
 
void onedie::rollit()
{
	srand(time_t(NULL));
	result= 1 + rand() % 6;
}
 
int onedie::getroll()
{
	return result;
}
#include "onedie.h"
#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;


void onedie::rollit()
{
	srand(time_t(NULL));
	result= 1 + rand() % 6;
}

int onedie::getroll()
{
	return result;
}

threedice.cpp

C++ Syntax (Toggle Plain Text)
#include "threedice.h"
#include <iostream>
 
using namespace std;
 
void threedice::rollem()
{
	die1.rollit();
	die2.rollit();
	die3.rollit();
}
 
int threedice::getsumFaces()
{
	return die1.getroll()+die2.getroll()+die3.getroll();
}
#include "threedice.h"
#include <iostream>

using namespace std;

void threedice::rollem()
{
	die1.rollit();
	die2.rollit();
	die3.rollit();
}

int threedice::getsumFaces()
{
	return die1.getroll()+die2.getroll()+die3.getroll();
}

noclass.cpp

C++ Syntax (Toggle Plain Text)
#include "noclass.h"
#include "threedice.h"
#include <iostream>
 
using namespace std;
 
void statistics (int rolls[], int rollsize,int allresults[])
{
	threedice tryerluck;
	rollsize=200;
	rolls[rollsize];
	allresults[16];
 
	for(int i=0;i<200;i++)
	{
		tryerluck.rollem();
		rolls[i]= tryerluck.getsumFaces();
	}
}
#include "noclass.h"
#include "threedice.h"
#include <iostream>

using namespace std;

void statistics (int rolls[], int rollsize,int allresults[])
{
	threedice tryerluck;
	rollsize=200;
	rolls[rollsize];
	allresults[16];

	for(int i=0;i<200;i++)
	{
		tryerluck.rollem();
		rolls[i]= tryerluck.getsumFaces();
	}
}

Okay, that's all of it. Where did I screw up please?

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

In your THREEDICE.H add the following forward declaration

(Toggle Plain Text)

#define THREEDICE_H
class onedie;
class threedice
...

Then the statistics() function is a bit odd, if you think it will be called from e.g. main(),
it probably should look like

C++ Syntax (Toggle Plain Text)
int main()
{
    const int roll_count = 200;
    int rolls[roll_count] = {0};
    // I'm not actually sure what the allresults should be
    int allresults[roll_count] = {0}; 
    // Then you can make the statistics() call ...
    statistics (rolls, roll_count, allresults);
    return 0;
}
 
void statistics (int rolls[], int count, int allresults[])
{
    threedice tryerluck;
    for(int i=0;i<count;i++)
    {
        tryerluck.rollem();
        rolls[i]= tryerluck.getsumFaces();
    }
 
    // and maybe do something here with the allresults too    
}
int main()
{
    const int roll_count = 200;
    int rolls[roll_count] = {0};
    // I'm not actually sure what the allresults should be
    int allresults[roll_count] = {0}; 
    // Then you can make the statistics() call ...
    statistics (rolls, roll_count, allresults);
    return 0;
}

void statistics (int rolls[], int count, int allresults[])
{
    threedice tryerluck;
    for(int i=0;i<count;i++)
    {
        tryerluck.rollem();
        rolls[i]= tryerluck.getsumFaces();
    }

    // and maybe do something here with the allresults too    
}

mitrmkar

Reputation Points: 1105

Solved Threads: 389

Posting Virtuoso

Offline

1,714 posts
since Nov 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

I put the class onedie; in the threedice header and it says undefined class...did I leave something out or have I incorrectly defined it in onedie.cpp?

I was indeed going to call the statistics function in main and there will be more to it. After the for loop, I have to make another one (I think) with a switch to fill the allresults with the spread of results between 3 and 18.

update:
I changed it from class onedie; to #include onedie.h and now it compiles, is that correct?

Last edited by henpecked1; Mar 21st, 2008 at 10:40 pm.

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

I got it to compile without error. Problem seems to be here

C++ Syntax (Toggle Plain Text)
#ifndef THREEDICE_H
#define THREEDICE_H
 
#include "onedie.h" // <<<<<<<<<<<<<<<<<< ADD THIS LINE
 
class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
 
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};
 
#endif
#ifndef THREEDICE_H
#define THREEDICE_H

#include "onedie.h" // <<<<<<<<<<<<<<<<<< ADD THIS LINE

class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
		
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};

#endif

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,950 posts
since Aug 2005

Permalink

Mar 21st, 2008

Re: Object compiler errors

that's what I did...ooo...I almost figured something out on my own...lol.

Okay, now I have to try the loop to fill allresults. I'm thinking a for loop with a switch, does that sound right....or at least like it would work?

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

Okay, the switch isn't working, I'm getting a bunch of illegal cases. Do I have the wrong condition?

C++ Syntax (Toggle Plain Text)
 
for (int i=0;i<rollsize;i++)
{
        switch (rolls[i])
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        case 5:allresults[2] = allresults [2]+1; break;
        case 6:allresults[3] = allresults [3]+1; break;
        case 7:allresults[4] = allresults [4]+1; break;
        case 8:allresults[5] = allresults [5]+1; break;
        case 9:allresults[6] = allresults [6]+1; break;
        case 10:allresults[7] = allresults [7]+1; break;
        case 11:allresults[8] = allresults [8]+1; break;
        case 12:allresults[9] = allresults [9]+1; break;
        case 13:allresults[10] = allresults [10]+1; break;
        case 14:allresults[11] = allresults [11]+1; break;
        case 15:allresults[12] = allresults [12]+1; break;
        case 16:allresults[13] = allresults [13]+1; break;
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
}
for (int i=0;i<rollsize;i++)
{
        switch (rolls[i])
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        case 5:allresults[2] = allresults [2]+1; break;
        case 6:allresults[3] = allresults [3]+1; break;
        case 7:allresults[4] = allresults [4]+1; break;
        case 8:allresults[5] = allresults [5]+1; break;
        case 9:allresults[6] = allresults [6]+1; break;
        case 10:allresults[7] = allresults [7]+1; break;
        case 11:allresults[8] = allresults [8]+1; break;
        case 12:allresults[9] = allresults [9]+1; break;
        case 13:allresults[10] = allresults [10]+1; break;
        case 14:allresults[11] = allresults [11]+1; break;
        case 15:allresults[12] = allresults [12]+1; break;
        case 16:allresults[13] = allresults [13]+1; break;
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
}

Last edited by WolfPack; Mar 21st, 2008 at 11:45 pm. Reason: Corrected indenting.

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

Either you didn't know that you should use braces, or you forgot.

cpp Syntax (Toggle Plain Text)
for (int i=0;i<rollsize;i++)
{
    switch (rolls[i])
    { // Forgot this
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        /* ......... */ 
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
    } // And this
}
for (int i=0;i<rollsize;i++)
{
    switch (rolls[i])
    { // Forgot this
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        /* ......... */ 
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
    } // And this
}

Last edited by WolfPack; Mar 21st, 2008 at 11:50 pm. Reason: Corrected indenting.

WolfPack

Moderator

Reputation Points: 572

Solved Threads: 115

Mentally Challenged Mod.

Offline

1,559 posts
since Jun 2005

Permalink

Mar 21st, 2008

Re: Object compiler errors

okay, I feel stupid now

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Permalink

Mar 21st, 2008

Re: Object compiler errors

you don't need that switch statement at all

C++ Syntax (Toggle Plain Text)
for (int i=0;i<rollsize;i++)
{
        allresults[i] = allresults [i]+1;
}
for (int i=0;i<rollsize;i++)
{
        allresults[i] = allresults [i]+1;
}

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,950 posts
since Aug 2005

Permalink

Mar 22nd, 2008

Re: Object compiler errors

AD, does that increment the different elements of the results array so you know which numbers are rolled how many times? I used the switch because that's what the prof has in the lesson plan, but I'm just as keen on keeping things simple.

Okay, main looks like it's outputting a memory address instead of a bunch of dice rolls. Should I just move that statistics and display functions to main instead of calling them? Or I might have screwed up the display function....it's supposed to print each element of the allresults array.

Here is main:

C++ Syntax (Toggle Plain Text)
#include "threedice.h"
#include "noclass.h"
#include <iostream>
 
using namespace std;
 
int main ()
{
	const int rollsize = 200;
    int rolls[rollsize] = {0};
	int allresults[16]={0};
 
 
	statistics(rolls,rollsize,allresults);
	displayResults(allresults);
 
 
	return 0;
}
#include "threedice.h"
#include "noclass.h"
#include <iostream>

using namespace std;

int main ()
{
	const int rollsize = 200;
    int rolls[rollsize] = {0};
	int allresults[16]={0};


	statistics(rolls,rollsize,allresults);
	displayResults(allresults);


	return 0;
}

The display function

C++ Syntax (Toggle Plain Text)
void displayResults(int allresults[])
	{
		cout << allresults << endl;
	}
void displayResults(int allresults[])
	{
		cout << allresults << endl;
	}

Last edited by henpecked1; Mar 22nd, 2008 at 12:23 am.

henpecked1

Reputation Points: 10

Solved Threads: 2

Posting Whiz in Training

Offline

244 posts
since Dec 2007

Previous
1
Page 2
3
4
Next

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: confusion in virtual

Next Thread in C++ Forum Timeline: math operations

DaniWeb Message

Cancel Changes

User Name
Password