Ad:

C++ Discussion Thread
Unsolved
Views: 1312

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Apr 27th, 2008

My simple game: what would i use

Expand Post »

EDIT: I've got a while loop in my code, just now when player 1 goes to have his/her second attack the hp is reset to 99,

c++ Syntax (Toggle Plain Text)
#include <conio.h>
#include <iostream>
 
using namespace std;
 
int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
 
    p1hp = 99;
    p2hp = 99;
 
    system("TITLE Game.");
 
    while(p1hp > 0 && p2hp > 0)
    {
 
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
 
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 99 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
 
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 99 + 1; 
         cout << "You hit " << p2attack << "!" << endl;
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
 
    p1hp -= attack;
    }
 
 
}
getch();
}
#include <conio.h>
#include <iostream>

using namespace std;

int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
    
    p1hp = 99;
    p2hp = 99;
    
    system("TITLE Game.");
    
    while(p1hp > 0 && p2hp > 0)
    {
   
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
    
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 99 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
    
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 99 + 1; 
         cout << "You hit " << p2attack << "!" << endl;
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    
    p1hp -= attack;
    }
    

}
getch();
}

Last edited by Black Magic; Apr 27th, 2008 at 1:28 pm.

Similar Threads

C++ game? in C++
How do i create a simple game using c++?? in C++
build java game in Java

Black Magic

Reputation Points: 25

Solved Threads: 4

Junior Poster

Offline

177 posts
since Apr 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

> p1hp -= attack;
This isn't the value you calculated.

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

I've changed it to: p1hp -= p2attack;
But p1hp still stays 99

Black Magic

Reputation Points: 25

Solved Threads: 4

Junior Poster

Offline

177 posts
since Apr 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

Hey Black Magic i have solved your problem.

Well just examine That you have typed this code in

C++ Syntax (Toggle Plain Text)

p1hp -= p2attack;

Line 54. Which probarbly doesnt get executed because there are break; statements above it.

So You actually need to paste the code in between Line 46 and line 47 so that the value gets changed.

So here is the total program with the adjustment.

C++ Syntax (Toggle Plain Text)
#include <conio.h>
#include <iostream>
 
using namespace std;
 
int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
 
    p1hp = 99;
    p2hp = 99;
 
    system("TITLE Game.");
 
    while(p1hp > 0 && p2hp > 0)
    {
 
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
 
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 99 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
 
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 99 + 1; 
         p1hp -= p2attack;
         cout << "You hit " << p2attack << "!" << endl;
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
 
 
    }
 
 
}
getch();
}
#include <conio.h>
#include <iostream>

using namespace std;

int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
    
    p1hp = 99;
    p2hp = 99;
    
    system("TITLE Game.");
    
    while(p1hp > 0 && p2hp > 0)
    {
   
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
    
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 99 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
    
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 99 + 1; 
         p1hp -= p2attack;
         cout << "You hit " << p2attack << "!" << endl;
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    
    
    }
    

}
getch();
}

Sky Diploma

Reputation Points: 673

Solved Threads: 125

Practically a Posting Shark

Offline

818 posts
since Mar 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

Or, if you'd like to keep in consistent with the code for player 1's attack, you could simply put it outside of the switch statement but inside the while loop (like line 57 or 58 in Sky Diploma's program). If you do do that though, remember to take away that same code from line 47.

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

I actually put the code in 47 Keeping in mind that there is an option for an attacker not to attack also. right

For example if the user enters something other than "A".

Sky Diploma

Reputation Points: 673

Solved Threads: 125

Practically a Posting Shark

Offline

818 posts
since Mar 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

Click to Expand / Collapse Quote originally posted by Sky Diploma ...

I actually put the code in 47 Keeping in mind that there is an option for an attacker not to attack also. right

For example if the user enters something other than "A".

Hmm.... yes you're very correct. In fact, the same thing should be done to the player1 code, because if p2hp -= p1attack; is called and p1attack hasn't been initialized, you'll get not so optimal results.

So either change it, or in the beginning of the loop set p1attack and p2attack to 0.

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Permalink

Apr 27th, 2008

Re: My simple game: what would i use

Yes . That is also a good solution

Cool Gamer 48

I dint think of that.

Sky Diploma

Reputation Points: 673

Solved Threads: 125

Practically a Posting Shark

Offline

818 posts
since Mar 2008

Permalink

Apr 28th, 2008

Re: My simple game: what would i use

Thanks guys, now i was wondering now if i should make it so the other player cannot make your hp a negative number, how could this be done? Please reply.

c++ Syntax (Toggle Plain Text)
#include <conio.h>
#include <iostream>
 
using namespace std;
 
int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
 
    p1hp = 99;
    p2hp = 99;
 
    system("TITLE Game.");
 
    while(p1hp > 0 && p2hp > 0)
    {
 
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
 
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 50 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
 
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
 
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 50 + 1; 
         p1hp -= p2attack;
         cout << "You hit " << p2attack << "!" << endl << endl;
    break;
 
    default:
         cout << endl << "INVALID SELECTION!";
    break;
 
 
    }
 
 
}
getch();
}
#include <conio.h>
#include <iostream>

using namespace std;

int main()
{
    int p1attack, p2attack, p1hp, p2hp;
    char attack;
    
    p1hp = 99;
    p2hp = 99;
    
    system("TITLE Game.");
    
    while(p1hp > 0 && p2hp > 0)
    {
   
    cout << "Player 1 (HP:" << p1hp << ") Press 'A' to attack : ";
    cin >> attack;
    
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p1attack = rand() % 50 + 1; 
         cout << "You hit " << p1attack << "!";
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    }
    p2hp -= p1attack;
    
    cout << endl << endl << "Player 2 (HP:" << p2hp << ") Press 'A' to attack : ";
    cin >> attack;
    switch(attack)
    {
                      
    case 'a':
    case 'A': 
         srand ( time(NULL) );
         p2attack = rand() % 50 + 1; 
         p1hp -= p2attack;
         cout << "You hit " << p2attack << "!" << endl << endl;
    break;
    
    default:
         cout << endl << "INVALID SELECTION!";
    break;
    
    
    }
    

}
getch();
}

Black Magic

Reputation Points: 25

Solved Threads: 4

Junior Poster

Offline

177 posts
since Apr 2008

Permalink

Apr 28th, 2008

Re: My simple game: what would i use

Right after p2hp -= p1attack; , add:

C++ Syntax (Toggle Plain Text)
if(p2hp < 0)
    p2hp = 0;
if(p2hp < 0)
    p2hp = 0;

You may also try making the health values unsigned, though the above method should work well enough

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: game code help

Next Thread in C++ Forum Timeline: Using functions without calling them from any class

DaniWeb Message

Cancel Changes

User Name
Password