Ad:

C++ Discussion Thread
Unsolved
Views: 2718

Jun 7th, 2008

toupper function

Expand Post »

I've got a pretty simple question. I'm trying to ask the player for to choose a difficulty. I want the case to be to not affect his choice, so I am using the toupper() function. Unfortunately, when I try to return the value of the difficulty, no matter what difficulty I choose, I receive 2009768935. However, when I enter an answer is all caps, avoiding the use of the toupper() function, everything turns out great.

Here is my code.

C++ Syntax (Toggle Plain Text)
    cout << "Choose a difficulty among Easy, Intermediate, and Hard.";
    string x;
    int difficulty;
    cin >> x;
    for (int i =0; i <=12; i++)
    { x[i] = x[toupper(i)]; }
    if (x == "EASY" )
    { difficulty = 0; }
    if (x == "INTERMEDIATE" ) 
    { difficulty = 1; }
    if (x == "HARD" )
    { difficulty = 2; }
 
    cout << difficulty;
    cout << "Choose a difficulty among Easy, Intermediate, and Hard.";
    string x;
    int difficulty;
    cin >> x;
    for (int i =0; i <=12; i++)
    { x[i] = x[toupper(i)]; }
    if (x == "EASY" )
    { difficulty = 0; }
    if (x == "INTERMEDIATE" ) 
    { difficulty = 1; }
    if (x == "HARD" )
    { difficulty = 2; }
    
    cout << difficulty;

Similar Threads

zoner7

Reputation Points: 34

Solved Threads: 4

Junior Poster

Offline

114 posts
since Dec 2007

Permalink

Jun 7th, 2008

Re: toupper function

Hi
I think
x [i] = toupper (x[i]) ;

selvaganapathy

Reputation Points: 44

Solved Threads: 101

Posting Pro

Offline

547 posts
since Feb 2008

Permalink

Jun 7th, 2008

Re: toupper function

Hi
I think
x [i] = toupper (x[i]) ;
Also iterate to the length of the String. Not the fixed value. In the coding u specified 0 to 12.

selvaganapathy

Reputation Points: 44

Solved Threads: 101

Posting Pro

Offline

547 posts
since Feb 2008

Permalink

Jun 7th, 2008

Re: toupper function

why dont you do something like this

C++ Syntax (Toggle Plain Text)
    if (x == "EASY" || "easy" )
    { 
       difficulty = 0; 
    }
// and so on..
    if (x == "EASY" || "easy" )
    { 
       difficulty = 0; 
    }
// and so on..

joshmo

Reputation Points: 19

Solved Threads: 20

Posting Whiz in Training

Offline

280 posts
since Oct 2007

Permalink

Jun 7th, 2008

Re: toupper function

i believe your syntax is wrong
here i is an integer and you are converting that integer into upper case which is absurd.
the use of toupper function works differently

Quote ...

x[i]=toupper(x[i]);

Arpy Giri

Reputation Points: 11

Solved Threads: 3

Newbie Poster

Offline

14 posts
since Jan 2008

Permalink

Jun 7th, 2008

Re: toupper function

Quote originally posted by joshmo ...

> why dont you do something like this
> if (x == "EASY" || "easy" )

You've written (with red bits for clarity)
if ( ( x == "EASY" ) || ( "easy" != NULL ) )
In essence, it's always true, because the right hand side is always true, and the OR makes the whole thing true.

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Jun 7th, 2008

Re: toupper function

thanx for the correction...didnt see it there.. but actully this was the intetion

C++ Syntax (Toggle Plain Text)
if (x == "EASY" || x=="easy" )
if (x == "EASY" || x=="easy" )

Last edited by joshmo; Jun 7th, 2008 at 6:40 am.

joshmo

Reputation Points: 19

Solved Threads: 20

Posting Whiz in Training

Offline

280 posts
since Oct 2007

Permalink

Jun 7th, 2008

Re: toupper function

[edit] sorry multiple post

Last edited by joshmo; Jun 7th, 2008 at 6:45 am.

joshmo

Reputation Points: 19

Solved Threads: 20

Posting Whiz in Training

Offline

280 posts
since Oct 2007

Permalink

Jun 7th, 2008

Re: toupper function

C++ Syntax (Toggle Plain Text)
#include <cctype> // for toupper()
#include <algorithm> // for transform()
 
transform(x.begin(), x.end(), x.begin(), toupper);
#include <cctype> // for toupper()
#include <algorithm> // for transform()

transform(x.begin(), x.end(), x.begin(), toupper);

try this

Last edited by Cybulski; Jun 7th, 2008 at 7:27 am.

Cybulski

Reputation Points: 15

Solved Threads: 3

Light Poster

Offline

47 posts
since Apr 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Use a function from a different file (C++)

Next Thread in C++ Forum Timeline: Vector and virtual function questions

DaniWeb Message

Cancel Changes

User Name
Password