Ad:

C++ Discussion Thread
Unsolved
Views: 781

Jul 8th, 2008

function not working cant figure problem

Expand Post »

been working on this code for 2-3 hours using the basic c++ information. tearing out my hair trying to figure out what is wrong writing hangman programm but trying to use functions to initialize programm and enter and response computer saying little or no error but wont launch can't figure out what to do plz help me. there are two types ive tried

OPTION 1:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>
 
using namespace std;
 
char getGuess();
 
string inWord();
 
int main()
{
    // set-up
    const int MAX_WRONG = 8; 
 
    vector<string> words;
    words.push_back("GUESS");
    words.push_back("HANGMAN");
    words.push_back("DIFFICULT");
 
	srand(time(0));
    random_shuffle(words.begin(), words.end());
    const string THE_WORD = words[0];            
    int wrong = 0;                               
    string soFar(THE_WORD.size(), '-');          
    string used = "";                            
 
    cout << "welcome to hangman!!";
 
 
}char getGuess()
{
     char guess;
        cout << "\n\nEnter your guess: ";
        cin >> guess;
        guess = toupper(guess);
        return guess;
        }
 
string inWord()
        {
        vector<string> words;
        char guess;
        const string THE_WORD = words[0];  
        char guess1 = THE_WORD.find(guess);
        int wrong = 0;
        string soFar(THE_WORD.size(), '-');
        if (guess1 != string::npos)
        {
            cout << "That's right! " << guess << " is in the word.\n";
 
 
            for (int i = 0; i < THE_WORD.length(); ++i)
                if (THE_WORD[i] == guess)
                    soFar[i] = guess;
        }
        else
        {
            cout << "Sorry, " << guess << " isn't in the word.\n";
            ++wrong;
        }
        return soFar;
    }
 
   while ((wrong < MAX_WRONG) && (soFar != THE_WORD));
   {
         cout << "\n\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
         cout << "\nYou've used the following letters:\n" << used << endl;
         cout << "\nSo far, the word is:\n" << soFar << endl;
 
         getGuess()
         while (used.find(guess) != string::npos)
        {
            cout << "\nYou've already guessed " << guess << endl;
            cout << "Enter your guess: ";
            cin >> guess;
            guess = toupper(guess);
        }
 
        used += guess;
 
        inWord()
 
            // shut down
    if (wrong == MAX_WRONG)
        cout << "\nYou've been hanged!";
    else
        cout << "\nYou guessed it!";
 
    cout << "\nThe word was " << THE_WORD << endl;
 
    return 0;
}
#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>

using namespace std;

char getGuess();

string inWord();

int main()
{
    // set-up
    const int MAX_WRONG = 8; 

    vector<string> words;
    words.push_back("GUESS");
    words.push_back("HANGMAN");
    words.push_back("DIFFICULT");

	srand(time(0));
    random_shuffle(words.begin(), words.end());
    const string THE_WORD = words[0];            
    int wrong = 0;                               
    string soFar(THE_WORD.size(), '-');          
    string used = "";                            
    
    cout << "welcome to hangman!!";
    

}char getGuess()
{
     char guess;
        cout << "\n\nEnter your guess: ";
        cin >> guess;
        guess = toupper(guess);
        return guess;
        }
        
string inWord()
        {
        vector<string> words;
        char guess;
        const string THE_WORD = words[0];  
        char guess1 = THE_WORD.find(guess);
        int wrong = 0;
        string soFar(THE_WORD.size(), '-');
        if (guess1 != string::npos)
        {
            cout << "That's right! " << guess << " is in the word.\n";

            
            for (int i = 0; i < THE_WORD.length(); ++i)
                if (THE_WORD[i] == guess)
                    soFar[i] = guess;
        }
        else
        {
            cout << "Sorry, " << guess << " isn't in the word.\n";
            ++wrong;
        }
        return soFar;
    }
  
   while ((wrong < MAX_WRONG) && (soFar != THE_WORD));
   {
         cout << "\n\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
         cout << "\nYou've used the following letters:\n" << used << endl;
         cout << "\nSo far, the word is:\n" << soFar << endl;
         
         getGuess()
         while (used.find(guess) != string::npos)
        {
            cout << "\nYou've already guessed " << guess << endl;
            cout << "Enter your guess: ";
            cin >> guess;
            guess = toupper(guess);
        }
        
        used += guess;
        
        inWord()
        
            // shut down
    if (wrong == MAX_WRONG)
        cout << "\nYou've been hanged!";
    else
        cout << "\nYou guessed it!";
    
    cout << "\nThe word was " << THE_WORD << endl;
   
    return 0;
}

OPTION 2:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>
 
using namespace std;
 
char getGuess();
 
string inWord();
 
int main()
{
    const int MAX_WRONG = 8;  
 
    char guess;
    vector<string> words;  
    words.push_back("GUESS");
    words.push_back("HANGMAN");
    words.push_back("DIFFICULT");
 
	srand(time(0));
    random_shuffle(words.begin(), words.end());
    const string THE_WORD = words[0];            
    int wrong = 0;                               
    string soFar(THE_WORD.size(), '-');          
    string used = "";                            
 
    cout << "welcome to hangman!!";
 
   while ((wrong < MAX_WRONG) && (soFar != THE_WORD))
   {
         cout << "\n\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
         cout << "\nYou've used the following letters:\n" << used << endl;
         cout << "\nSo far, the word is:\n" << soFar << endl;
 
         getGuess();
 
         while (used.find(guess) != string::npos)
        {
            cout << "\nYou've already guessed " << guess << endl;
            cout << "Enter your guess: ";
            cin >> guess;
            guess = toupper(guess);
        }
 
        used += guess;
 
        inWord();
 
 
    if (wrong == MAX_WRONG)
 
        cout << "\nYou've been hanged!";  
    else
 
        cout << "\nYou guessed it!";
 
    cout << "\nThe word was " << THE_WORD << endl;
 
    return 0;
}
}
 
char getGuess()
{
     char guess;
        cout << "\n\nEnter your guess: ";
        cin >> guess;
        guess = toupper(guess);
        return guess;
        }
 
string inWord()
        {
        vector<string> words;
        char guess;
        const string THE_WORD = words[0];  
        char guess1 = THE_WORD.find(guess);
        int wrong = 0;
        string soFar(THE_WORD.size(), '-');
        if (guess1 != string::npos)
        {
            cout << "That's right! " << guess << " is in the word.\n";
 
 
            for (int i = 0; i < THE_WORD.length(); ++i)
                if (THE_WORD[i] == guess)
                    soFar[i] = guess;
		}
        else
        {
            cout << "Sorry, " << guess << " isn't in the word.\n";
            ++wrong;
        }
        return soFar;
    }
#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>

using namespace std;

char getGuess();

string inWord();

int main()
{
    const int MAX_WRONG = 8;  

    char guess;
    vector<string> words;  
    words.push_back("GUESS");
    words.push_back("HANGMAN");
    words.push_back("DIFFICULT");

	srand(time(0));
    random_shuffle(words.begin(), words.end());
    const string THE_WORD = words[0];            
    int wrong = 0;                               
    string soFar(THE_WORD.size(), '-');          
    string used = "";                            
    
    cout << "welcome to hangman!!";
    
   while ((wrong < MAX_WRONG) && (soFar != THE_WORD))
   {
         cout << "\n\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
         cout << "\nYou've used the following letters:\n" << used << endl;
         cout << "\nSo far, the word is:\n" << soFar << endl;
         
         getGuess();
         
         while (used.find(guess) != string::npos)
        {
            cout << "\nYou've already guessed " << guess << endl;
            cout << "Enter your guess: ";
            cin >> guess;
            guess = toupper(guess);
        }
        
        used += guess;
        
        inWord();
        
            
    if (wrong == MAX_WRONG)
        
        cout << "\nYou've been hanged!";  
    else
        
        cout << "\nYou guessed it!";
    
    cout << "\nThe word was " << THE_WORD << endl;

    return 0;
}
}

char getGuess()
{
     char guess;
        cout << "\n\nEnter your guess: ";
        cin >> guess;
        guess = toupper(guess);
        return guess;
        }
        
string inWord()
        {
        vector<string> words;
        char guess;
        const string THE_WORD = words[0];  
        char guess1 = THE_WORD.find(guess);
        int wrong = 0;
        string soFar(THE_WORD.size(), '-');
        if (guess1 != string::npos)
        {
            cout << "That's right! " << guess << " is in the word.\n";

            
            for (int i = 0; i < THE_WORD.length(); ++i)
                if (THE_WORD[i] == guess)
                    soFar[i] = guess;
		}
        else
        {
            cout << "Sorry, " << guess << " isn't in the word.\n";
            ++wrong;
        }
        return soFar;
    }

Last edited by Ancient Dragon; Jul 8th, 2008 at 8:42 am. Reason: add code tags

Similar Threads

Sony Vaio Fn key problem in USB Devices and other Peripherals
Shopping Cart Not Working in ASP.NET
C++ function to check validity of sudoku in C++
for loop not working right in C++
Wireless Connection Excellent but working intermitently in Networking

chickenlord500

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Jun 2008

Permalink

Jul 8th, 2008

Re: function not working cant figure problem

In OPTION 2 comment the following line
//inWord();
in your main function.

Last edited by RenjithVR; Jul 8th, 2008 at 2:41 am.

RenjithVR

Reputation Points: 12

Solved Threads: 7

Light Poster

Offline

41 posts
since Mar 2008

Permalink

Jul 8th, 2008

Re: function not working cant figure problem

And learn how to use CODE-TAGS as you were told before.

Last edited by Nick Evan; Jul 8th, 2008 at 3:54 am.

Nick Evan

Moderator

Featured Poster

Reputation Points: 4142

Solved Threads: 394

Industrious Poster

Offline

4,132 posts
since Oct 2006

Permalink

Jul 8th, 2008

Re: function not working cant figure problem

Use code tags and we might help.

And you should really work on your code formatting. That looks terrible.

hacker9801

Reputation Points: 59

Solved Threads: 16

Junior Poster

Offline

129 posts
since Aug 2007

Permalink

Jul 8th, 2008

Re: function not working cant figure problem

Click to Expand / Collapse Quote originally posted by hacker9801 ...

And you should really work on your code formatting. That looks terrible.

If the poster doesn't use code-tags, all formatting will be automatically lost, so the code might actually be properly formatted....

Nick Evan

Moderator

Featured Poster

Reputation Points: 4142

Solved Threads: 394

Industrious Poster

Offline

4,132 posts
since Oct 2006

Permalink

Jul 10th, 2008

Re: function not working cant figure problem

We dont use code-tags in our c++ tags but if you guys say they are suppose to be there i might have to self teach myself them because we are using he C++ beginning from thomson course technology. and it doesnt mention code-tags

Click to Expand / Collapse Quote originally posted by niek_e ...

If the poster doesn't use code-tags, all formatting will be automatically lost, so the code might actually be properly formatted....

chickenlord500

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Jun 2008

Permalink

Jul 10th, 2008

Re: function not working cant figure problem

>and it doesnt mention code-tags
Code tags are a feature of Daniweb's forum. You take your code and wrap it in code tags like so when you want to post it here:

[code=cplusplus]
<code from your book here>
[/code]

This preserves the formatting of your code rather than trimming all leading whitespace from it. With the cplusplus attribute, line numbers and color coding are also added. Here's how code looks without code tags:

#include <iostream>

int main()
{
for ( int i = 0; i < 10; i++ )
std::cout<<"Hello, world!\n";
}

And here's the same code with code tags:

C++ Syntax (Toggle Plain Text)
#include <iostream>
 
int main()
{
  for ( int i = 0; i < 10; i++ )
    std::cout<<"Hello, world!\n";
}
#include <iostream>

int main()
{
  for ( int i = 0; i < 10; i++ )
    std::cout<<"Hello, world!\n";
}

Notice the difference?

p.s. We give you about 10 posts to learn how to use code tags, then start issuing infractions for each failure to use them. At 2 points per infraction, that means you can get off five posts before you're automatically banned for not following our rules.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Jul 10th, 2008

Re: function not working cant figure problem

In the function inword() , i dont understand why you are creating new vector words and a character variable guess.

Instead of doing that. Pass them as arguments for the function or declare them globally and dont declare them again in the function itself.

Sky Diploma

Reputation Points: 673

Solved Threads: 125

Practically a Posting Shark

Offline

818 posts
since Mar 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Transferring images..

Next Thread in C++ Forum Timeline: Re: Making a .dat file

DaniWeb Message

Cancel Changes

User Name
Password