Ad:

C++ Discussion Thread
Marked Solved
Views: 2688

Jul 9th, 2008

Virtual Inheritance Question

Expand Post »

c++ Syntax (Toggle Plain Text)
#include <iostream>
 
using namespace std;
 
class Lock
{
	friend class First;
	private:
		Lock()
		{
		}
};
 
class First : virtual public Lock
{
	public:
		void function()
		{
			cout << "function1" << endl;
		}
};
 
class Second: public First
{
	public:
		void function2()
		{
			cout << "function2" << endl;
		}
};
 
int main()
{
	First f;
	f.function();
 
	Second s;
	s.function2();
}
#include <iostream>

using namespace std;

class Lock
{
	friend class First;
	private:
		Lock()
		{
		}
};

class First : virtual public Lock
{
	public:
		void function()
		{
			cout << "function1" << endl;
		}
};

class Second: public First
{
	public:
		void function2()
		{
			cout << "function2" << endl;
		}
};

int main()
{
	First f;
	f.function();

	Second s;
	s.function2();
}

Error:
classVirtDer.cpp(39) : error C2248: 'Lock::Lock' : cannot access private member declared in class 'Lock'
classVirtDer.cpp(9) : see declaration of 'Lock::Lock'
classVirtDer.cpp(6) : see declaration of 'Lock'
This diagnostic occurred in the compiler generated function 'Second:

econd'

But when i remove the class Second, it works fine. Can someone explain?

Similar Threads

problem in database creation in C++
casting from userData in C++
'this' in initializer list - bad, or irrelevant? in C++
I have another homework question that i'm not sure what the answer is. in C
virtual methods and inheritance in C++

Agni

Featured Poster

Reputation Points: 431

Solved Threads: 116

Practically a Master Poster

Offline

654 posts
since Dec 2007

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

Friendship isn't inherited.

You declared a private constructor for the Lock class, in which it is only accessible either within that class or within a scope that has the right to access that Constructor.

Also because you've defined a constructor there is no default/dummy constructor provided.

Because First is a friend of Lock, First has the right to access Lock's private constructor.

Second does not inherit friendship of Lock despite the fact that Second derives from First.

In order to make the code work, you'll have to make Lock declare Second as a friend also--

c++ Syntax (Toggle Plain Text)
#include <iostream>
 
using namespace std;
 
class Lock
{
	friend class First;
	friend class Second;
	private:
		Lock()
		{
		}
};
 
class First : virtual public Lock
{
	public:
		void function()
		{
			cout << "function1" << endl;
		}
};
 
class Second: public First
{
	public:
		void function2()
		{
			cout << "function2" << endl;
		}
};
 
int main()
{
	First f;
	f.function();
 
	Second s;
	s.function2();
	cin.get();
       return 0;
}
#include <iostream>

using namespace std;

class Lock
{
	friend class First;
	friend class Second;
	private:
		Lock()
		{
		}
};

class First : virtual public Lock
{
	public:
		void function()
		{
			cout << "function1" << endl;
		}
};

class Second: public First
{
	public:
		void function2()
		{
			cout << "function2" << endl;
		}
};

int main()
{
	First f;
	f.function();

	Second s;
	s.function2();
	cin.get();
       return 0;
}

Last edited by Alex Edwards; Jul 9th, 2008 at 2:57 am.

Alex Edwards

Reputation Points: 392

Solved Threads: 108

Posting Shark

Offline

971 posts
since Jun 2008

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

i think its more because of the keyword 'virtual', just try and remove that and it compiles and excutes fine. Normally the class Second wil call the ctor of class First and then class First will call the ctor of Lock so i dont need to make 'Second' a friend of 'Lock'. but when i derive from the class 'Lock' virtually this doesnt happen.

Agni

Featured Poster

Reputation Points: 431

Solved Threads: 116

Practically a Master Poster

Offline

654 posts
since Dec 2007

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

http://www.computing.net/answers/pro...why/11546.html

RenjithVR

Reputation Points: 12

Solved Threads: 7

Light Poster

Offline

41 posts
since Mar 2008

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

I think I figured out the problem.

The link http://nxgenesis.blogspot.com/2007/1...-and-side.html states that Virtual Base classes are constructed before any Non-virtual Base class.

"virtual base classes and inheritance offer a set of rules which every c++ programmar should be aware of. Specifically:
virtual base classes are constructed before all non-virtual base classes.
virtual base class's constructor is directly invoked by the most-derived class's constructor."

When Second is instantiated, before the First constructor can run the Lock constructor runs before the First and because of that it's as if Second is trying to directly access Lock's private method since Second is the most-derived class and attempts to directly call the Lock constructor.

As stated previously, Friendship isn't inherited so even though First is a friend of Lock and Second derives from First, Second isn't a friend of Lock.

I'm fairly certain that this is the reason.

Alex Edwards

Reputation Points: 392

Solved Threads: 108

Posting Shark

Offline

971 posts
since Jun 2008

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

Change the private constructor into a public constructor..

.....???

Last edited by cikara21; Jul 9th, 2008 at 5:06 am.

cikara21

Reputation Points: 47

Solved Threads: 69

Posting Whiz

Offline

340 posts
since Jul 2008

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

thanks Edwards, that makes sense. Need to understand the virtual base classes more.

>Change the private constructor into a public constructor..

yes but then we wouldn't have faced the problem and wouldn't have come to know all this. it was just something i was trying to do.

Agni

Featured Poster

Reputation Points: 431

Solved Threads: 116

Practically a Master Poster

Offline

654 posts
since Dec 2007

Permalink

Jul 9th, 2008

Re: Virtual Inheritance Question

dont use the public constructor use private constructor in place of public constructor

Last edited by Narue; Jul 9th, 2008 at 10:15 am. Reason: Removed fake signature

ash05

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

6 posts
since Jul 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Convert to ANSI

Next Thread in C++ Forum Timeline: pointers to function problem

DaniWeb Message

Cancel Changes

User Name
Password