Ad:

C++ Discussion Thread
Unsolved
Views: 1611

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Jul 13th, 2008

Program works but shorter code?

Expand Post »

Hello, I'm new to this forum and have a brief knowledge of C++. I made this program to ask the user for a word and make it so the word would not be allowed any "i's". I completed the task just my code looks a bit to much I think. Can you suggest ways i shorten it. Thank you.

C++ Syntax (Toggle Plain Text)
// Code Shark
 
#include <iostream>
 
using namespace std;
 
int main() {
    char word[20];
    int i = 0;
 
    cout << "Enter a word which includes NO i's : ";
    cin >> word;
 
    do {
        word[i];
 
        if(word[i] == 'i') {
                   i++;
                   cout << endl << "I asked for no i's!";
                   cin.get();
                   cin.get();
        }
    }
 
    while(i);
 
    return 0;
 
    cin.get();
    cin.get();
}
// Code Shark

#include <iostream>

using namespace std;

int main() {
    char word[20];
    int i = 0;
    
    cout << "Enter a word which includes NO i's : ";
    cin >> word;
    
    do {
        word[i];
        
        if(word[i] == 'i') {
                   i++;
                   cout << endl << "I asked for no i's!";
                   cin.get();
                   cin.get();
        }
    }
    
    while(i);
    
    return 0;
        
    cin.get();
    cin.get();
}

Similar Threads

Candidate Program in C++
sorting the "news" in C
Open In New Window Php in PHP
currency conversion program error in C++
continuous string in C

Code Shark

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

14 posts
since Jul 2008

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

line 15: does nothing so you might as well delete it.
The loop lines 14-25 can be rewritten like this:

C++ Syntax (Toggle Plain Text)
char word[20];
while(1)
{
   cout << "Enter a word which includes NO i's : ";
   cin >> word;
 
   if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
   else
       break;
}
char word[20];
while(1)
{
   cout << "Enter a word which includes NO i's : ";
   cin >> word;

   if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
   else
       break;
}

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Online

21,950 posts
since Aug 2005

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

I guess it is C++ , you can use std::string apis like find , your code will reduce drastically.

ithelp

Reputation Points: 769

Solved Threads: 128

Banned

Offline

1,910 posts
since May 2006

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

@AncientDragon
Doesn't the loop you give continually ask for strings until you enter one that doesn't have an 'i'? The original program just asked for one, and check if there was an 'i' in it, then ended. You can reduce lines 14-25 to

C++ Syntax (Toggle Plain Text)
if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }

You can also remove line 9, the deceleration of the variable i, if you employ this method.

Also, the program terminates after return 0; , so there's no point in the two cin.get() statements after that. They can either be removed, or, you can put them before return 0; if you want them to be executed.

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

Never never never use cin >> char array!

C++ Syntax (Toggle Plain Text)
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin   >> word,
         word.find('i') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;
string word;

while (cout << "Enter a word which includes NO i's : ",
         cin   >> word,
         word.find('i') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

Sorry, more robust code (Ctrl-Z reaction added):

cpp Syntax (Toggle Plain Text)
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;
string word;

while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;

Last edited by Tekmaven; Jul 13th, 2008 at 5:29 pm. Reason: Added syntax to code tags

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

Click to Expand / Collapse Quote originally posted by ArkM ...

Sorry, more robust code (Ctrl-Z reaction added):
cpp Syntax (Toggle Plain Text)
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;
string word; while (cout << "Enter a word which includes NO i's : ", cin >> word && word.find_first_of('iI') != string::npos ) cout << "I asked for no i's!" << endl; cout << "Thank you. Bye..." << endl;string word;

Wait, when will the loop terminate? And what does the && operator do with left-operand istream and right-operand size_t? Is that even defined?

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Permalink

Jul 13th, 2008

Re: Program works but shorter code?

OK I tink if code pass all unit tests it's good code. Your code is good, but use std::string not char array with cin >>. If you want to catch all words that have ' , you can use boost regex lib http://www.boost.org/doc/libs/1_35_0...tml/index.html

C++ Syntax (Toggle Plain Text)
#include <boost/regex.hpp>
#include <iostream>
#include<string>
 
int main()
{
  std::string word;
  boost::regex e = "\b.+?[^'].+\b";
  boost::smatch what;
  std::cout << "Enter a word";
  std::cin >> word;
  if(boost::regex_match(word, what, e)
  {
    std::cout << "The word can not include ' " << std::endl;
  }
  std::cout << "Thank you. Bye..." << std::endl;
}
#include <boost/regex.hpp>
#include <iostream>
#include<string>

int main()
{
  std::string word;
  boost::regex e = "\b.+?[^'].+\b";
  boost::smatch what;
  std::cout << "Enter a word";
  std::cin >> word;
  if(boost::regex_match(word, what, e)
  {
    std::cout << "The word can not include ' " << std::endl;
  }
  std::cout << "Thank you. Bye..." << std::endl;
}

galin

Reputation Points: 10

Solved Threads: 2

Newbie Poster

Offline

10 posts
since Aug 2007

Permalink

Jul 13th, 2008

-1

Re: Program works but shorter code?

Click to Expand / Collapse Quote originally posted by galin ...

OK I tink if code pass all unit tests it's good code. Your code is good, but use std::string not char array with cin >>. If you want to catch all words that have ' , you can use boost regex lib http://www.boost.org/doc/libs/1_35_0...tml/index.html

I think you have over complicated things for this assignment. All the op wants is for the program to detect when the word includes the letter 'i'. Doing regular expressions if far far beyond the scope of this assignment.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Online

21,950 posts
since Aug 2005

Permalink

Jul 14th, 2008

Re: Program works but shorter code?

Some explanations:

Stream operator >> (and << too) returns reference to stream (that's why we may couple expressions in

cpp Syntax (Toggle Plain Text)

cin >> first >> second;
// (cin >> first) >> second - again stream >> target

Stream classes have conversion to bool (inherited from the common ancestor). It returns true if stream is OK otherwise false). Operator && is a simple C logical AND.

So the loop will been terminated when:
cin returns false (end of input stream or i/o error)
AND
find_first_of() returns std::string::npos value (no i's in the world).

The while stmt condition follows by the template:
Do_prompt , input_OK AND word_with_i

Do_prompt is the 1st arg of a comma operator (do this and forget then do the 2nd arg).

Some correction of my prev post:
1. Of course, the literal must "iI", not 'iI'
2. Discard string word in the tail (careless copy/paste op artifact

Sorry if this post is duplicated: I have some Inet troubles now...

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Hi I need of procedural

Next Thread in C++ Forum Timeline: ethernet

DaniWeb Message

Cancel Changes

User Name
Password