Ad:

C++ Discussion Thread
Unsolved
Views: 605

Jul 14th, 2008

Is this correct?

Expand Post »

Hello, I made this program that has random values and you have to choose to say if the next number will be higher - or lower. I completed the code and successfully had no errors but when the user is mistaken nothing comes up. Am I missing something?

C++ Syntax (Toggle Plain Text)
// Code Shark
 
#include <iostream>
#include <windows.h>
#include <string>
 
using namespace std;
 
int main() {
    srand(time(NULL));
 
    unsigned int digit = 0, digit2 = 0, correct = 0, wrong = 0;
    string answer;
 
    do {
        system("Cls");
 
        digit = rand() % 9 + 1;
        digit2 = rand() % 9 + 1;
 
        cout << "Digit : " << digit << endl;
        cout << "Correct : " << correct << endl << endl;
        cout << "Will the next value be Higher, Lower or Equal : ";
        cin >> answer;
 
        if(answer == "H") {
                  if(digit2 > digit) {
                            cout << endl << "Correct!";
                            correct++;
                  }
        }
 
        else if(answer == "L") {
             if(digit > digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
        }
 
        else if(answer == "E") {
             if(digit == digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
        }
 
        else if(answer == "H") {
             if(digit2 < digit || digit2 == digit) {
                       wrong++;
             }
        }
 
         else if(answer == "L") {
             if(digit2 > digit || digit2 == digit) {
                       wrong++;
             }
        }
 
         else if(answer == "E") {
             if(digit2 > digit || digit2 < digit) {
                       wrong++;
             }
        }
 
        Sleep(1000);
 
        }
 
        while(!wrong);
 
        cout << "You were correct " << correct << " times.";
 
        cin.get();
        cin.get();
 
        return 0;
}
// Code Shark

#include <iostream>
#include <windows.h>
#include <string>

using namespace std;

int main() {
    srand(time(NULL));
    
    unsigned int digit = 0, digit2 = 0, correct = 0, wrong = 0;
    string answer;
    
    do {
        system("Cls");
        
        digit = rand() % 9 + 1;
        digit2 = rand() % 9 + 1;
        
        cout << "Digit : " << digit << endl;
        cout << "Correct : " << correct << endl << endl;
        cout << "Will the next value be Higher, Lower or Equal : ";
        cin >> answer;
        
        if(answer == "H") {
                  if(digit2 > digit) {
                            cout << endl << "Correct!";
                            correct++;
                  }
        }
        
        else if(answer == "L") {
             if(digit > digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
        }
        
        else if(answer == "E") {
             if(digit == digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
        }
        
        else if(answer == "H") {
             if(digit2 < digit || digit2 == digit) {
                       wrong++;
             }
        }
        
         else if(answer == "L") {
             if(digit2 > digit || digit2 == digit) {
                       wrong++;
             }
        }
        
         else if(answer == "E") {
             if(digit2 > digit || digit2 < digit) {
                       wrong++;
             }
        }
        
        Sleep(1000);
        
        }
        
        while(!wrong);
        
        cout << "You were correct " << correct << " times.";
        
        cin.get();
        cin.get();
        
        return 0;
}

Similar Threads

database won't give correct permissions in MS SQL
Help function not returning correct value in C++
Returning a correct python list in Python
help me to correct this part of my program in C++
I cant correct these two errors in C++

Code Shark

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

14 posts
since Jul 2008

Permalink

Jul 14th, 2008

Re: Is this correct?

I think this is what you meant--

c++ Syntax (Toggle Plain Text)
// Code Shark
 
#include <iostream>
#include <windows.h>
#include <string>
 
using namespace std;
 
int main() {
    srand(time(NULL));
 
    unsigned int digit = 0, digit2 = 0, correct = 0, wrong = 0;
    string answer;
 
    do {
        system("Cls");
 
        digit = rand() % 9 + 1;
        digit2 = rand() % 9 + 1;
 
        cout << "Digit : " << digit << endl;
        cout << "Correct : " << correct << endl << endl;
        cout << "Will the next value be Higher, Lower or Equal : ";
        cin >> answer;
 
        if(answer == "H") {
                  if(digit2 > digit) {
                            cout << endl << "Correct!";
                            correct++;
                  }
                  else if(digit2 < digit || digit2 == digit) {
                       wrong++;
             }
        }
 
        else if(answer == "L") {
             if(digit > digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
             else if(digit2 > digit || digit2 == digit) {
                       wrong++;
             }
        }
 
        else if(answer == "E") {
             if(digit == digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
             else if(digit2 > digit || digit2 < digit) {
                       wrong++;
             }
        }
 
        Sleep(1000);
 
        }
 
        while(!wrong);
 
        cout << "You were correct " << correct << " times.";
 
        cin.get();
        cin.get();
 
        return 0;
}
// Code Shark

#include <iostream>
#include <windows.h>
#include <string>

using namespace std;

int main() {
    srand(time(NULL));
    
    unsigned int digit = 0, digit2 = 0, correct = 0, wrong = 0;
    string answer;
    
    do {
        system("Cls");
        
        digit = rand() % 9 + 1;
        digit2 = rand() % 9 + 1;
        
        cout << "Digit : " << digit << endl;
        cout << "Correct : " << correct << endl << endl;
        cout << "Will the next value be Higher, Lower or Equal : ";
        cin >> answer;
        
        if(answer == "H") {
                  if(digit2 > digit) {
                            cout << endl << "Correct!";
                            correct++;
                  }
                  else if(digit2 < digit || digit2 == digit) {
                       wrong++;
             }
        }
        
        else if(answer == "L") {
             if(digit > digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
             else if(digit2 > digit || digit2 == digit) {
                       wrong++;
             }
        }
        
        else if(answer == "E") {
             if(digit == digit2) {
                      cout << endl << "Correct!";
                      correct++;
             }
             else if(digit2 > digit || digit2 < digit) {
                       wrong++;
             }
        }
        
        Sleep(1000);
        
        }
        
        while(!wrong);
        
        cout << "You were correct " << correct << " times.";
        
        cin.get();
        cin.get();
        
        return 0;
}

Last edited by Alex Edwards; Jul 14th, 2008 at 1:51 pm.

Alex Edwards

Reputation Points: 392

Solved Threads: 108

Posting Shark

Offline

971 posts
since Jun 2008

Permalink

Jul 19th, 2008

Re: Is this correct?

Hello, I was wondering if all i need to add was another do loop outside of the current do loop for the program to keep asking H, L, or E when an invalid character was entered?

Code Shark

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

14 posts
since Jul 2008

Permalink

Jul 19th, 2008

Re: Is this correct?

Click to Expand / Collapse Quote originally posted by Code Shark ...

Hello, I was wondering if all i need to add was another do loop outside of the current do loop for the program to keep asking H, L, or E when an invalid character was entered?

You can make another loop (I would actually put it inside the current loop rather than outside if you do that) or you can just keep it the way it is. Running Alex's revised code, it already asks again when it gets bad input. If you want to add an error message to display when the user enters bad data, add an "else" statement after the if-else statements that displays the error message, but doesn't change the correct or wrong variables.

VernonDozier

Featured Poster

Reputation Points: 2614

Solved Threads: 687

Posting Expert

Offline

5,372 posts
since Jan 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Operator Overloading in Namespace, not working, printing address

Next Thread in C++ Forum Timeline: C++ help needed please

DaniWeb Message

Cancel Changes

User Name
Password