random number guess

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

40 posts
since Oct 2007

Jul 24th, 2008

Re: random number guess

Have you compiled and run this?

This:

C++ Syntax (Toggle Plain Text)

avgNoOfGuesses=sum/noofgamesplayed;

seems like it would generate an error, since noofgamesplayed is 0, and you're dividing by it. Besides, that statement and the one above it are unnecessary.

Do you need to write the functions, or do you simply need to call them? Either way, the functions seems to have a betting system that your current game doesn't implement.

Last edited by CoolGamer48; Jul 24th, 2008 at 9:38 pm. Reason: grammar

CoolGamer48

Reputation Points: 77

Solved Threads: 40

Posting Pro in Training

Offline

401 posts
since Jan 2008

Jul 24th, 2008

Re: random number guess

i just compiled it and I found the error. Here is the code that I got to work:

c++ Syntax (Toggle Plain Text)
 
#include <iostream>
 
#include <fstream>
 
#include <string>
 
#include <cstdlib>
 
#include <iomanip>
 
#include <ctime>
 
using namespace std;
 
int main ()
 
{
 
int num;
 
int guess;
 
bool done;
 
int numOfGuesses;
 
int ncount=0;
 
int sum=0;
 
int numofgamesplayed=0;
 
int avgnumOfGuesses=0;
 
char choice ;
 
char n;
 
char y;
 
cout << "=============================================" << endl;
 
cout << " Welcome to the High Low betting Game. " << endl;
 
cout << " You have a $1000 to begin game. " << endl;
 
cout << " Valid guesses are number between 1 and 100. " << endl;
 
cout << "=============================================" << endl << endl;
 
do
 
{
 
num = (rand() + time(0)) % 100;
 
done = false;
 
++numofgamesplayed;
 
numOfGuesses = 1;
 
while ((numOfGuesses < 7) && (!done))
 
{
 
cout << " Guess " << numOfGuesses << " : ";
 
cin >> guess;
 
cout << endl;
 
numOfGuesses++;
 
if (guess == num)
 
{ 
 
cout << " You guessed the correct number. " << endl << endl;
 
done = true;
 
}
 
else
 
if (guess < num)
 
cout << " Your guess is lower than the number. " << endl << endl;
 
else
 
cout << " Your guess is higher than the number. " << endl << endl;
 
}
 
sum+= numOfGuesses ;
 
cout << " Sorry... the correct answer was " << num << endl;
 
cout<<"\n Number of Games played "<<numofgamesplayed;
 
cout<<"\n Total number of guesses :"<< sum;
 
cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;
 
} 
 
while( choice != y);
 
cout<< endl << " Like to try the game again <y or n>? ";
 
cin>> choice;
 
return 0;
 
}

#include <iostream>

#include <fstream>

#include <string>

#include <cstdlib>

#include <iomanip>

#include <ctime>

using namespace std;

int main ()

{

int num;

int guess;

bool done;

int numOfGuesses;

int ncount=0;

int sum=0;

int numofgamesplayed=0;

int avgnumOfGuesses=0;

char choice ;

char n;

char y;

cout << "=============================================" << endl;

cout << " Welcome to the High Low betting Game. " << endl;

cout << " You have a $1000 to begin game. " << endl;

cout << " Valid guesses are number between 1 and 100. " << endl;

cout << "=============================================" << endl << endl;

do

{

num = (rand() + time(0)) % 100;

done = false;

++numofgamesplayed;

numOfGuesses = 1;

while ((numOfGuesses < 7) && (!done))

{

cout << " Guess " << numOfGuesses << " : ";

cin >> guess;

cout << endl;

numOfGuesses++;

if (guess == num)

{ 

cout << " You guessed the correct number. " << endl << endl;

done = true;

}

else

if (guess < num)

cout << " Your guess is lower than the number. " << endl << endl;

else

cout << " Your guess is higher than the number. " << endl << endl;

}

sum+= numOfGuesses ;

cout << " Sorry... the correct answer was " << num << endl;

cout<<"\n Number of Games played "<<numofgamesplayed;

cout<<"\n Total number of guesses :"<< sum;

cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;

} 

while( choice != y);

cout<< endl << " Like to try the game again <y or n>? ";

cin>> choice;

return 0;

}

I know i wasn't able to get the beting system to work.

Last edited by student4lyfe; Jul 24th, 2008 at 9:55 pm. Reason: answer the last part of the response to my question

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

40 posts
since Oct 2007

Jul 24th, 2008

Re: random number guess

I'll start you off with the first function, PrintHeading(int). This is simply taking lines 44 through 52 above, taking them out of main, and putting them into PrintHeading(int). In addition, the $1000 is no longer hard-coded in the cout statement, but instead now uses the parameter passed to the function. Lines 44 through 52 are replaced with the function call, and a function declaration is added before main. This is the easiest of your functions, but hopefully it'll help. Give the others a try. Also, not sure if you noticed, but your srand line was accidentally cut off from your program when you were splitting the program in two in your first post. Not sure where it was originally, but I found it at the bottom of the functions code in your first post and put it at the top of main.

C++ Syntax (Toggle Plain Text)
 
#include <iostream>
 
#include <fstream>
 
#include <string>
 
#include <cstdlib>
 
#include <iomanip>
 
#include <ctime>
 
using namespace std;
 
void PrintHeading(int money);
 
int main ()
 
{
 
srand((unsigned)time(NULL));    
 
int num;
 
int guess;
 
bool done;
 
int numOfGuesses;
 
int ncount=0;
 
int sum=0;
 
int numofgamesplayed=0;
 
int avgnumOfGuesses=0;
 
char choice ;
 
char n;
 
char y;
 
PrintHeading (1000);
 
do
 
{
 
num = (rand() + time(0)) % 100;
 
done = false;
 
++numofgamesplayed;
 
numOfGuesses = 1;
 
while ((numOfGuesses < 7) && (!done))
 
{
 
cout << " Guess " << numOfGuesses << " : ";
 
cin >> guess;
 
cout << endl;
 
numOfGuesses++;
 
if (guess == num)
 
{ 
 
cout << " You guessed the correct number. " << endl << endl;
 
done = true;
 
}
 
else
 
if (guess < num)
 
cout << " Your guess is lower than the number. " << endl << endl;
 
else
 
cout << " Your guess is higher than the number. " << endl << endl;
 
}
 
sum+= numOfGuesses ;
 
cout << " Sorry... the correct answer was " << num << endl;
 
cout<<"\n Number of Games played "<<numofgamesplayed;
 
cout<<"\n Total number of guesses :"<< sum;
 
cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;
 
} 
 
while( choice != y);
 
cout<< endl << " Like to try the game again <y or n>? ";
 
cin>> choice;
 
return 0;
 
} 
 
/*
PrintHeading simply prints the introductory output.
Parameters: initial amount of money received
*/
void PrintHeading(int money)
{
     cout << "=============================================" << endl;
     cout << " Welcome to the High Low betting Game. " << endl;
     cout << " You have $" << money << " to begin game. " << endl;
     cout << " Valid guesses are number between 1 and 100. " << endl;
     cout << "=============================================" << endl << endl;
}
#include <iostream>

#include <fstream>

#include <string>

#include <cstdlib>

#include <iomanip>

#include <ctime>

using namespace std;

void PrintHeading(int money);

int main ()

{
    
srand((unsigned)time(NULL));    

int num;

int guess;

bool done;

int numOfGuesses;

int ncount=0;

int sum=0;

int numofgamesplayed=0;

int avgnumOfGuesses=0;

char choice ;

char n;

char y;

PrintHeading (1000);

do

{

num = (rand() + time(0)) % 100;

done = false;

++numofgamesplayed;

numOfGuesses = 1;

while ((numOfGuesses < 7) && (!done))

{

cout << " Guess " << numOfGuesses << " : ";

cin >> guess;

cout << endl;

numOfGuesses++;

if (guess == num)

{ 

cout << " You guessed the correct number. " << endl << endl;

done = true;

}

else

if (guess < num)

cout << " Your guess is lower than the number. " << endl << endl;

else

cout << " Your guess is higher than the number. " << endl << endl;

}

sum+= numOfGuesses ;

cout << " Sorry... the correct answer was " << num << endl;

cout<<"\n Number of Games played "<<numofgamesplayed;

cout<<"\n Total number of guesses :"<< sum;

cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;

} 

while( choice != y);

cout<< endl << " Like to try the game again <y or n>? ";

cin>> choice;

return 0;

} 

/*
PrintHeading simply prints the introductory output.
Parameters: initial amount of money received
*/
void PrintHeading(int money)
{
     cout << "=============================================" << endl;
     cout << " Welcome to the High Low betting Game. " << endl;
     cout << " You have $" << money << " to begin game. " << endl;
     cout << " Valid guesses are number between 1 and 100. " << endl;
     cout << "=============================================" << endl << endl;
}

Featured Poster

Reputation Points: 2614

Solved Threads: 687

Posting Expert

Offline

5,374 posts
since Jan 2008

Jul 25th, 2008

Re: random number guess

Ok, this is what I wrote for my next function but I am getting an error saying that bet is not declared. Can someone tell me what I am doing wrong?

c++ Syntax (Toggle Plain Text)
#include <iostream>
#include <fstream>
#include <string>
#include <cstdlib>
#include <iomanip>
#include <ctime>
using namespace std;
/* ----------------------------------------------------------------- */
/*						Function Prototypes                          */
/* ----------------------------------------------------------------- */
	void PrintHeading(int money);
	void GetBet(int money, int& bet);
/* ----------------------------------------------------------------- */
 int main ()
 
 {
 
	srand((unsigned)time(NULL));
	int money = 1000;
	int num;
 
	int guess;
	int numOfGuesses;
	int ncount=0;
	int sum=0;
	int numofgamesplayed=0;
	int avgnumOfGuesses=0;
	bool done;
	const int numMax = 7;
	const int numMin = 0;
	const int guessMax = 100;
	const int guessMin = 1;
	char choice ;
	//char n;
	char y;
	GetBet( money, bet);
	PrintHeading(money);
	do
	{
		num = (rand() + time(0)) % 100;
		done = false;
		++numofgamesplayed;
		numOfGuesses = 1;
 
	while ((numOfGuesses < 7) && (!done))
	{
		cout << " Guess " << numOfGuesses << " : ";
		cin >> guess;
		cout << endl;
		numOfGuesses++;
 
	if (guess == num)
	{ 
		cout << " You guessed the correct number. " << endl << endl;
		done = true;
	}
	else
		if (guess < num)
		cout << " Your guess is lower than the number. " << endl << endl;
	else
		cout << " Your guess is higher than the number. " << endl << endl;
	}
		sum+= numOfGuesses ;
		cout << " Sorry... the correct answer was " << num << endl;
		cout<<"\n Number of Games played "<<numofgamesplayed;
		cout<<"\n Total number of guesses :"<< sum;
		cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;
	} 
		while( choice != y);
		cout<< endl << " Like to try the game again <y or n>? ";
		cin>> choice;
 
	return 0;
} 
	/*
	PrintHeading simply prints the introductory output.
	Parameters: initial amount of money received
	*/
 
	void PrintHeading(int money)
 
	{
 
 
		cout << "=============================================" << endl;
		cout << " Welcome to the High Low betting Game. " << endl;
		cout << " You have $" << money << " to begin game. " << endl;
		cout << " Valid guesses are number between 1 and 100. " << endl;
		cout << "=============================================" << endl << endl;
 
}
	/*
	GetBet prompts for and reads in a bet. The function performs all
	error checking necessary to insure that a valid bet is read in
	and does not return until a valid bet is entered.
	Parameters:
	money: the amount of money the player currently has
	bet: the bet chosen by the user
	*/
	void GetBet(int money, int& bet);
	{
		int bet;
		while (( bet <= money ) && ( bet > 0))
		cout << " Enter bet : " << bet;
		cin >> bet;
	}
#include <iostream>
#include <fstream>
#include <string>
#include <cstdlib>
#include <iomanip>
#include <ctime>
using namespace std;
/* ----------------------------------------------------------------- */
/*						Function Prototypes                          */
/* ----------------------------------------------------------------- */
	void PrintHeading(int money);
	void GetBet(int money, int& bet);
/* ----------------------------------------------------------------- */
 int main ()

 {

	srand((unsigned)time(NULL));
	int money = 1000;
	int num;
	
	int guess;
	int numOfGuesses;
	int ncount=0;
	int sum=0;
	int numofgamesplayed=0;
	int avgnumOfGuesses=0;
	bool done;
	const int numMax = 7;
	const int numMin = 0;
	const int guessMax = 100;
	const int guessMin = 1;
	char choice ;
	//char n;
	char y;
	GetBet( money, bet);
	PrintHeading(money);
	do
	{
		num = (rand() + time(0)) % 100;
		done = false;
		++numofgamesplayed;
		numOfGuesses = 1;
	
	while ((numOfGuesses < 7) && (!done))
	{
		cout << " Guess " << numOfGuesses << " : ";
		cin >> guess;
		cout << endl;
		numOfGuesses++;
	
	if (guess == num)
	{ 
		cout << " You guessed the correct number. " << endl << endl;
		done = true;
	}
	else
		if (guess < num)
		cout << " Your guess is lower than the number. " << endl << endl;
	else
		cout << " Your guess is higher than the number. " << endl << endl;
	}
		sum+= numOfGuesses ;
		cout << " Sorry... the correct answer was " << num << endl;
		cout<<"\n Number of Games played "<<numofgamesplayed;
		cout<<"\n Total number of guesses :"<< sum;
		cout<<"\n Guessing Average = :"<<sum/numofgamesplayed;
	} 
		while( choice != y);
		cout<< endl << " Like to try the game again <y or n>? ";
		cin>> choice;

	return 0;
} 
	/*
	PrintHeading simply prints the introductory output.
	Parameters: initial amount of money received
	*/
	
	void PrintHeading(int money)
	
	{
		

		cout << "=============================================" << endl;
		cout << " Welcome to the High Low betting Game. " << endl;
		cout << " You have $" << money << " to begin game. " << endl;
		cout << " Valid guesses are number between 1 and 100. " << endl;
		cout << "=============================================" << endl << endl;
		
}
	/*
	GetBet prompts for and reads in a bet. The function performs all
	error checking necessary to insure that a valid bet is read in
	and does not return until a valid bet is entered.
	Parameters:
	money: the amount of money the player currently has
	bet: the bet chosen by the user
	*/
	void GetBet(int money, int& bet);
	{
		int bet;
		while (( bet <= money ) && ( bet > 0))
		cout << " Enter bet : " << bet;
		cin >> bet;
	}

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

40 posts
since Oct 2007

Jul 25th, 2008

Re: random number guess

Here are your variable declarations in main.

C++ Syntax (Toggle Plain Text)
	int money = 1000;
	int num;
 
	int guess;
	int numOfGuesses;
	int ncount=0;
	int sum=0;
	int numofgamesplayed=0;
	int avgnumOfGuesses=0;
	bool done;
	const int numMax = 7;
	const int numMin = 0;
	const int guessMax = 100;
	const int guessMin = 1;
	char choice ;
	//char n;
	char y;
	int money = 1000;
	int num;
	
	int guess;
	int numOfGuesses;
	int ncount=0;
	int sum=0;
	int numofgamesplayed=0;
	int avgnumOfGuesses=0;
	bool done;
	const int numMax = 7;
	const int numMin = 0;
	const int guessMax = 100;
	const int guessMin = 1;
	char choice ;
	//char n;
	char y;

bet is not among them, so when the compiler gets to this line, it doesn't know what bet is.

C++ Syntax (Toggle Plain Text)

GetBet( money, bet);

Note that this line at the top doesn't allow you to use bet in main:

(Toggle Plain Text)

void GetBet(int money, int& bet);

That's a function declaration that lets you use the GetBet function, not the variable bet.

Nor does the fact that you declare bet later in the GetBet function itself allow you to use bet in main. You need to add this line:

C++ Syntax (Toggle Plain Text)

int bet;

inside main before you use this line:

C++ Syntax (Toggle Plain Text)

GetBet( money, bet);

Featured Poster

Reputation Points: 2614

Solved Threads: 687

Posting Expert

Offline

5,374 posts
since Jan 2008

Jul 25th, 2008

Re: random number guess

I was told that you are suppose to declare your variables in your functions

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

40 posts
since Oct 2007

Jul 25th, 2008

Re: random number guess

Click to Expand / Collapse Quote originally posted by student4lyfe ...

I was told that you are suppose to declare your variables in your functions

That's a very broad statement. main IS a function so if you are going to use a variable in main and you don't want to declare it globally, which you usually don't, and you haven't done so here, you need to declare it in main.

Featured Poster

Reputation Points: 2614

Solved Threads: 687

Posting Expert

Offline

5,374 posts
since Jan 2008

Jul 25th, 2008

Re: random number guess

also itried what you said and still got an error. Imust be missing a step.

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

40 posts
since Oct 2007

Jul 25th, 2008

Re: random number guess

Click to Expand / Collapse Quote originally posted by student4lyfe ...

also itried what you said and still got an error. Imust be missing a step.

I said you had an error. I didn't say that was the only error. You need to state what the error is rather than just say you have an error.

At minimum you have two errors in this function:

(Toggle Plain Text)

	void GetBet(int money, int& bet);
	{
		int bet;
		while (( bet <= money ) && ( bet > 0))
		cout << " Enter bet : " << bet;
		cin >> bet;
	}

One, the function declaration has a semicolon at the end of it, but not the function itself. Delete the semicolon in red. Two, You've already declared bet in the function parameters, so don't do it in the function itself. Delete int bet; here.