Ad:

C++ Discussion Thread
Marked Solved
Views: 576

Jul 29th, 2008

C to C++

Expand Post »

Hi, I would like to ask you for help in converting this code from C to C++. It's my little friend 's homework, but I can't help him 'cause I know nothing about C

In fact, I just can't figure the "scanf" part out, I think the other part is similar to C++. Thanks in advance !

C++ Syntax (Toggle Plain Text)
#include <stdio.h>
#include <string.h>
void main()
{
int i,br=0,d=0;
char r[200];
printf("Vnesete Recenica\n");
gets(r);
d=strlen(r);
for(i=0;i<=d;i++)
{
if((r[i]=='n')&&(r[i+1]=='o'))
{
r[i]=' ';
r[i+1]=' ';
br++;
}
}
printf("Vo Vasata recenica se pronajdeni i izbrisani %d no zborovi\n",br);
scanf("%d",&i);
}
#include <stdio.h>
#include <string.h>
void main()
{
int i,br=0,d=0;
char r[200];
printf("Vnesete Recenica\n");
gets(r);
d=strlen(r);
for(i=0;i<=d;i++)
{
if((r[i]=='n')&&(r[i+1]=='o'))
{
r[i]=' ';
r[i+1]=' ';
br++;
}
}
printf("Vo Vasata recenica se pronajdeni i izbrisani %d no zborovi\n",br);
scanf("%d",&i);
}

Last edited by Ancient Dragon; Jul 29th, 2008 at 9:13 am. Reason: add code tags

robertmacedonia

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

85 posts
since Jul 2008

Permalink

Jul 29th, 2008

Re: C to C++

First of all use code tags. Second do not use void main..main has to always return something. Then, what is the program supposed to do and what dont you understand about scanf..what kind of errors are you getting when you compile your code?

joshmo

Reputation Points: 19

Solved Threads: 20

Posting Whiz in Training

Offline

280 posts
since Oct 2007

Permalink

Jul 29th, 2008

Re: C to C++

Click to Expand / Collapse Quote originally posted by robertmacedonia ...

Hi, I would like to ask you for help in converting this code from C to C++. It's my little friend 's homework, but I can't help him 'cause I know nothing about C In fact, I just can't figure the "scanf" part out, I think the other part is similar to C++. Thanks in advance !
[
#include <stdio.h>
#include <string.h>
void main()
{
int i,br=0,d=0;
char r[200];
printf("Vnesete Recenica\n");
gets(r);
d=strlen(r);
for(i=0;i<=d;i++)
{
if((r[i]=='n')&&(r[i+1]=='o'))
{
r[i]=' ';
r[i+1]=' ';
br++;
}
}
printf("Vo Vasata recenica se pronajdeni i izbrisani %d no zborovi\n",br);
scanf("%d",&i);
}

]

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
 
void main()
{
	int i,br=0,d=0;
	//char r[200];
	std::string r;
	//printf("Vnesete Recenica\n");
	std::cout<<"Vnesete Recenica\n"<<std::endl;
	//gets(r);
	std::cin>>r;
	//d=strlen(r);
	//for(i=0;i<=r.length();i++)
	/*
	for(i=0;i<r.length() - 1 ;i++) //THIS WAS INCORRECT IN THE 1st IMPLEMENTATION  TOO, BUFFER OVERRUN !!
	{
		if((r.at(i)=='n')&&(r.at(i+1)=='o'))
		{
			r[i]=' ';
			r[i+1]=' ';
			br++;
		}
	}
	*/
	std::string::size_type poz = -1;
	while ( true )
		if (  ( poz = r.find( "no", poz + 1 ) ) != std::string::npos )
			br++;
		else 
			break;
 
 
	//printf("Vo Vasata recenica se pronajdeni i izbrisani %d no zborovi\n",br);
	std::cout<<"Vo Vasata recenica se pronajdeni i izbrisani "<<br<<" no zborovi\n"<<std::endl;
	//scanf("%d",&i);
	std::cin>>i;
}
#include <iostream>
#include <string>

void main()
{
	int i,br=0,d=0;
	//char r[200];
	std::string r;
	//printf("Vnesete Recenica\n");
	std::cout<<"Vnesete Recenica\n"<<std::endl;
	//gets(r);
	std::cin>>r;
	//d=strlen(r);
	//for(i=0;i<=r.length();i++)
	/*
	for(i=0;i<r.length() - 1 ;i++) //THIS WAS INCORRECT IN THE 1st IMPLEMENTATION  TOO, BUFFER OVERRUN !!
	{
		if((r.at(i)=='n')&&(r.at(i+1)=='o'))
		{
			r[i]=' ';
			r[i+1]=' ';
			br++;
		}
	}
	*/
	std::string::size_type poz = -1;
	while ( true )
		if (  ( poz = r.find( "no", poz + 1 ) ) != std::string::npos )
			br++;
		else 
			break;
	

	//printf("Vo Vasata recenica se pronajdeni i izbrisani %d no zborovi\n",br);
	std::cout<<"Vo Vasata recenica se pronajdeni i izbrisani "<<br<<" no zborovi\n"<<std::endl;
	//scanf("%d",&i);
	std::cin>>i;
}

the last scanf/cin is placed there so that the program won't end untill the user sees the output and presses some key.
I placed the old C implementation between coments. It was also incorrect as it was causing buffer overuns on the char*

kux

Reputation Points: 66

Solved Threads: 11

Junior Poster

Offline

119 posts
since Jan 2008

Permalink

Jul 29th, 2008

Re: C to C++

Click to Expand / Collapse Quote originally posted by robertmacedonia ...

Hi, I would like to ask you for help in converting this code from C to C++.

Code, that you posted is correct C++ code, except nonstandard main declaration.

But to be "just more C++", you may rewrite it as follows:

C++ Syntax (Toggle Plain Text)
#include <string>
#include <iostream>
 
int main(void)
{  
  std::string r;
  std::cout << "Vnesete Recenica" << std::endl;
  std::getline(std::cin, r);
  size_t d = r.size();
  int br = 0;
  for(int i = 0; i != d; ++i){
    if((r[i]=='n')&&(r[i+1]=='o')){
      r[i]=' ';
      r[i+1]=' ';
      br++;
    }
  }
  std::cout << "Vo Vasata recenica se pronajdeni i izbrisani " << br << " no zborovi" << std::endl;
  std::cin >> d;
  return 0;
}
#include <string>
#include <iostream>

int main(void)
{  
  std::string r;
  std::cout << "Vnesete Recenica" << std::endl;
  std::getline(std::cin, r);
  size_t d = r.size();
  int br = 0;
  for(int i = 0; i != d; ++i){
    if((r[i]=='n')&&(r[i+1]=='o')){
      r[i]=' ';
      r[i+1]=' ';
      br++;
    }
  }
  std::cout << "Vo Vasata recenica se pronajdeni i izbrisani " << br << " no zborovi" << std::endl;
  std::cin >> d;
  return 0;
}

Also, we may use iterators and std::replace from <algorithm> header to make this code "really C++", but this simple task you may solve by yourself, I think.

Tilir

Reputation Points: 46

Solved Threads: 2

Newbie Poster

Offline

14 posts
since Jul 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: writing to a file

Next Thread in C++ Forum Timeline: Files and Arrays

DaniWeb Message

Cancel Changes

User Name
Password